From nobody Mon Feb 9 07:55:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500307120592456.1297533784948; Mon, 17 Jul 2017 08:58:40 -0700 (PDT) Received: from localhost ([::1]:51153 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dX8Pt-0003zu-B7 for importer@patchew.org; Mon, 17 Jul 2017 11:58:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dX8O2-0002os-M6 for qemu-devel@nongnu.org; Mon, 17 Jul 2017 11:56:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dX8O1-0007Ys-RK for qemu-devel@nongnu.org; Mon, 17 Jul 2017 11:56:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44806) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dX8Nz-0007WW-Q8; Mon, 17 Jul 2017 11:56:39 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A449683F45; Mon, 17 Jul 2017 15:56:38 +0000 (UTC) Received: from red.redhat.com (ovpn-120-160.rdu2.redhat.com [10.10.120.160]) by smtp.corp.redhat.com (Postfix) with ESMTP id F415760E3E; Mon, 17 Jul 2017 15:56:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A449683F45 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=eblake@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A449683F45 From: Eric Blake To: qemu-devel@nongnu.org Date: Mon, 17 Jul 2017 10:56:29 -0500 Message-Id: <20170717155632.12754-3-eblake@redhat.com> In-Reply-To: <20170717155632.12754-1-eblake@redhat.com> References: <20170717155632.12754-1-eblake@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 17 Jul 2017 15:56:38 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 2/5] nbd: Use simpler QAPI_TO_QOBJECT() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Paolo Bonzini , armbru@redhat.com, "open list:Network Block Dev..." , Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Use the new macro to avoid some boilerplate. Signed-off-by: Eric Blake --- block/nbd.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index a50d24b50a..f90ac76d1f 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -519,7 +519,6 @@ static void nbd_refresh_filename(BlockDriverState *bs, = QDict *options) BDRVNBDState *s =3D bs->opaque; QDict *opts =3D qdict_new(); QObject *saddr_qdict; - Visitor *ov; const char *host =3D NULL, *port =3D NULL, *path =3D NULL; if (s->saddr->type =3D=3D SOCKET_ADDRESS_TYPE_INET) { @@ -548,10 +547,9 @@ static void nbd_refresh_filename(BlockDriverState *bs,= QDict *options) "nbd://%s:%s", host, port); } - ov =3D qobject_output_visitor_new(&saddr_qdict); - visit_type_SocketAddress(ov, NULL, &s->saddr, &error_abort); - visit_complete(ov, &saddr_qdict); - visit_free(ov); + saddr_qdict =3D QAPI_TO_QOBJECT(SocketAddress, s->saddr, &error_abort); + assert(qobject_type(saddr_qdict) =3D=3D QTYPE_QDICT); + qdict_put_obj(opts, "server", saddr_qdict); if (s->export) { --=20 2.13.3