[Qemu-devel] [PATCH] iotests: Remove a few tests from 'quick' group

Eric Blake posted 1 patch 6 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170717142620.6970-1-eblake@redhat.com
Test FreeBSD passed
Test checkpatch passed
Test docker passed
Test s390x passed
tests/qemu-iotests/group | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[Qemu-devel] [PATCH] iotests: Remove a few tests from 'quick' group
Posted by Eric Blake 6 years, 9 months ago
A run of './check -qcow2 -g quick' on my machine produced only
two tests that took longer than 5 seconds; 178 took 18, and
189 took 7.  Remove them from the quick group.

Signed-off-by: Eric Blake <eblake@redhat.com>
---
 tests/qemu-iotests/group | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
index 2aba585287..01f12d6781 100644
--- a/tests/qemu-iotests/group
+++ b/tests/qemu-iotests/group
@@ -175,11 +175,11 @@
 175 auto quick
 176 rw auto backing
 177 rw auto quick
-178 auto quick
+178 auto
 179 rw auto quick
 181 rw auto migration
 182 rw auto quick
 183 rw auto migration
 185 rw auto
 188 rw auto quick
-189 rw auto quick
+189 rw auto
-- 
2.13.3


Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: Remove a few tests from 'quick' group
Posted by John Snow 6 years, 9 months ago

On 07/17/2017 10:26 AM, Eric Blake wrote:
> A run of './check -qcow2 -g quick' on my machine produced only
> two tests that took longer than 5 seconds; 178 took 18, and
> 189 took 7.  Remove them from the quick group.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  tests/qemu-iotests/group | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
> index 2aba585287..01f12d6781 100644
> --- a/tests/qemu-iotests/group
> +++ b/tests/qemu-iotests/group
> @@ -175,11 +175,11 @@
>  175 auto quick
>  176 rw auto backing
>  177 rw auto quick
> -178 auto quick
> +178 auto
>  179 rw auto quick
>  181 rw auto migration
>  182 rw auto quick
>  183 rw auto migration
>  185 rw auto
>  188 rw auto quick
> -189 rw auto quick
> +189 rw auto
> 

Seems about as scientific as the existing methods used to define the
quick group, so why not?

Reviewed-by: John Snow <jsnow@redhat.com>

Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: Remove a few tests from 'quick' group
Posted by Jeff Cody 6 years, 9 months ago
On Mon, Jul 17, 2017 at 09:26:20AM -0500, Eric Blake wrote:
> A run of './check -qcow2 -g quick' on my machine produced only
> two tests that took longer than 5 seconds; 178 took 18, and
> 189 took 7.  Remove them from the quick group.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  tests/qemu-iotests/group | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
> index 2aba585287..01f12d6781 100644
> --- a/tests/qemu-iotests/group
> +++ b/tests/qemu-iotests/group
> @@ -175,11 +175,11 @@
>  175 auto quick
>  176 rw auto backing
>  177 rw auto quick
> -178 auto quick
> +178 auto
>  179 rw auto quick
>  181 rw auto migration
>  182 rw auto quick
>  183 rw auto migration
>  185 rw auto
>  188 rw auto quick
> -189 rw auto quick
> +189 rw auto
> -- 
> 2.13.3
> 
> 

Reviewed-by: Jeff Cody <jcody@redhat.com>


Re: [Qemu-devel] [PATCH] iotests: Remove a few tests from 'quick' group
Posted by Stefan Hajnoczi 6 years, 9 months ago
On Mon, Jul 17, 2017 at 09:26:20AM -0500, Eric Blake wrote:
> A run of './check -qcow2 -g quick' on my machine produced only
> two tests that took longer than 5 seconds; 178 took 18, and
> 189 took 7.  Remove them from the quick group.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  tests/qemu-iotests/group | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Re: [Qemu-devel] [PATCH] iotests: Remove a few tests from 'quick' group
Posted by Kevin Wolf 6 years, 8 months ago
Am 17.07.2017 um 16:26 hat Eric Blake geschrieben:
> A run of './check -qcow2 -g quick' on my machine produced only
> two tests that took longer than 5 seconds; 178 took 18, and
> 189 took 7.  Remove them from the quick group.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>

Thanks, applied to the block branch.

Kevin