From nobody Mon Feb 9 13:22:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500112436360396.81334617939217; Sat, 15 Jul 2017 02:53:56 -0700 (PDT) Received: from localhost ([::1]:41345 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWJlr-0004hH-4r for importer@patchew.org; Sat, 15 Jul 2017 05:53:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWJbe-0003rd-LL for qemu-devel@nongnu.org; Sat, 15 Jul 2017 05:43:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWJbc-0003K7-1j for qemu-devel@nongnu.org; Sat, 15 Jul 2017 05:43:22 -0400 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:36176) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dWJbb-0003Jx-Rn for qemu-devel@nongnu.org; Sat, 15 Jul 2017 05:43:19 -0400 Received: by mail-pg0-x242.google.com with SMTP id y129so13365547pgy.3 for ; Sat, 15 Jul 2017 02:43:19 -0700 (PDT) Received: from bigtime.twiddle.net (rrcs-173-197-98-123.west.biz.rr.com. [173.197.98.123]) by smtp.gmail.com with ESMTPSA id c63sm27368589pfk.79.2017.07.15.02.43.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Jul 2017 02:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mvhIU7DX/mMTo28o5nf9x91G/4ismitFOm/iYo00IMI=; b=Zd8paXne1JLkzMrkCHJNb/WaUTafF+csSduFrKQd+PBaQedK5IYuqRejjNw/jtLVb6 ClwD6IlZCZIlT3vBrCqbFopfQNMr79JacWKNPPE3dUKfcj+ra1aeuV86T+TvKZn12EgX hK71N/McLvf+k3hPqUNiVu1eLhMdASESrXdCt4GBiaxo9SAAqK82/qFAerF0xwRkTy+w EzVpMRVfPZH/q1NlZ7G3XQP1WoCkoyyivgf9wf8e7k7M/1ME5wVWZWCmox4fpuMdhaKY 7PVwXtiG5nkGI8IgFad0SFGsl+dLyOT4cUQJXuAOGFbPy4fnsmUAO5W8rzlePDQYKbp/ fuqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=mvhIU7DX/mMTo28o5nf9x91G/4ismitFOm/iYo00IMI=; b=SrFZeXgD8JFjSIXIV+qzIMXhmYNZyV0LCF8gZenjR80yNMQYD9GL7jMeVVODUfw2EE ZqyArfQhhSPnBDrKmw6LQl4cSrcfrqIZabZjB42WlVLQe2SHhq5yQo/l5SdVdBMp6DqL JXDug7Pwtz1+7b50IM1tIDCowY/iHIIhr6LBxatEmu1wMg6E1908gnbz+S8datSNpqX5 1kzrV149SnsFIP+2AhBqaIou++7PQj11COH/F39nb5+QGRXmZPUtwAD0d266AN7bvViR 2tPd/sSdGWe6XExStpqEX7CXwVQiLdYCVPs+uevkAjxXx4U6KoFcIfxZtX/mv8wEIt/F q+hw== X-Gm-Message-State: AIVw112va3lew9S83yl67FBuE8tBuMsCmvtPBOzJYYi+/BpqIHlOpXk5 9iCF8kba0zkT+BZGNHU= X-Received: by 10.84.128.47 with SMTP id 44mr20142998pla.213.1500111798735; Sat, 15 Jul 2017 02:43:18 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 14 Jul 2017 23:42:23 -1000 Message-Id: <20170715094243.28371-15-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170715094243.28371-1-rth@twiddle.net> References: <20170715094243.28371-1-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::242 Subject: [Qemu-devel] [PATCH v14 14/34] target/i386: [tcg] Port to tb_stop X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, cota@braap.org, alex.bennee@linaro.org, vilanova@ac.upc.edu, crosthwaite.peter@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Llu=C3=ADs Vilanova Incrementally paves the way towards using the generic instruction translati= on loop. Signed-off-by: Llu=C3=ADs Vilanova Reviewed-by: Emilio G. Cota Reviewed-by: Richard Henderson Message-Id: <150002219289.22386.17959138704858928730.stgit@frigg.lan> Signed-off-by: Richard Henderson --- target/i386/translate.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index d350699..8238533 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -8487,8 +8487,6 @@ static void i386_tr_translate_insn(DisasContextBase *= dcbase, CPUState *cpu) /* if irq were inhibited with HF_INHIBIT_IRQ_MASK, we clear the flag and abort the translation to give the irqs a chance to happen */ - gen_jmp_im(pc_next - dc->cs_base); - gen_eob(dc); dc->base.is_jmp =3D DISAS_TOO_MANY; } else if ((dc->base.tb->cflags & CF_USE_ICOUNT) && ((dc->base.pc_next & TARGET_PAGE_MASK) @@ -8501,18 +8499,24 @@ static void i386_tr_translate_insn(DisasContextBase= *dcbase, CPUState *cpu) If current instruction already crossed the bound - it's ok, because an exception hasn't stopped this code. */ - gen_jmp_im(pc_next - dc->cs_base); - gen_eob(dc); dc->base.is_jmp =3D DISAS_TOO_MANY; } else if ((pc_next - dc->base.pc_first) >=3D (TARGET_PAGE_SIZE - 32))= { - gen_jmp_im(pc_next - dc->cs_base); - gen_eob(dc); dc->base.is_jmp =3D DISAS_TOO_MANY; } =20 dc->base.pc_next =3D pc_next; } =20 +static void i386_tr_tb_stop(DisasContextBase *dcbase, CPUState *cpu) +{ + DisasContext *dc =3D container_of(dcbase, DisasContext, base); + + if (dc->base.is_jmp =3D=3D DISAS_TOO_MANY) { + gen_jmp_im(dc->base.pc_next - dc->cs_base); + gen_eob(dc); + } +} + /* generate intermediate code for basic block 'tb'. */ void gen_intermediate_code(CPUState *cs, TranslationBlock *tb) { @@ -8569,23 +8573,21 @@ void gen_intermediate_code(CPUState *cs, Translatio= nBlock *tb) /* if single step mode, we generate only one instruction and generate an exception */ if (dc->base.singlestep_enabled) { - gen_jmp_im(dc->base.pc_next - dc->cs_base); - gen_eob(dc); + dc->base.is_jmp =3D DISAS_TOO_MANY; break; } /* if too long translation, stop generation too */ if (tcg_op_buf_full() || num_insns >=3D max_insns) { - gen_jmp_im(dc->base.pc_next - dc->cs_base); - gen_eob(dc); + dc->base.is_jmp =3D DISAS_TOO_MANY; break; } if (singlestep) { - gen_jmp_im(dc->base.pc_next - dc->cs_base); - gen_eob(dc); + dc->base.is_jmp =3D DISAS_TOO_MANY; break; } } + i386_tr_tb_stop(&dc->base, cs); if (tb->cflags & CF_LAST_IO) gen_io_end(); gen_tb_end(tb, num_insns); --=20 2.9.4