From nobody Wed Feb 11 05:53:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500032478051729.148301482058; Fri, 14 Jul 2017 04:41:18 -0700 (PDT) Received: from localhost ([::1]:37180 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVyy8-0003U4-Lb for importer@patchew.org; Fri, 14 Jul 2017 07:41:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVyuP-00089Q-Ci for qemu-devel@nongnu.org; Fri, 14 Jul 2017 07:37:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVyuO-0006rk-Bp for qemu-devel@nongnu.org; Fri, 14 Jul 2017 07:37:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38744) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dVyuO-0006qx-36 for qemu-devel@nongnu.org; Fri, 14 Jul 2017 07:37:20 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1B52B80478 for ; Fri, 14 Jul 2017 11:37:19 +0000 (UTC) Received: from vader.redhat.com (ovpn-117-45.ams2.redhat.com [10.36.117.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 504BD65EAD; Fri, 14 Jul 2017 11:37:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1B52B80478 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=otubo@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1B52B80478 From: Eduardo Otubo To: qemu-devel@nongnu.org Date: Fri, 14 Jul 2017 13:36:59 +0200 Message-Id: <20170714113700.21319-6-otubo@redhat.com> In-Reply-To: <20170714113700.21319-1-otubo@redhat.com> References: <20170714113700.21319-1-otubo@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 14 Jul 2017 11:37:19 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 5/6] seccomp: add resourcecontrol argument to command line X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Otubo Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This patch adds [,resourcecontrol=3Ddeny] to `-sandbox on' option. It blacklists all process affinity and scheduler priority system calls to avoid any bigger of the process. Signed-off-by: Eduardo Otubo --- include/sysemu/seccomp.h | 1 + qemu-options.hx | 5 ++++- qemu-seccomp.c | 27 +++++++++++++++++++++++++++ vl.c | 11 +++++++++++ 4 files changed, 43 insertions(+), 1 deletion(-) diff --git a/include/sysemu/seccomp.h b/include/sysemu/seccomp.h index f1614d6514..c7003dd197 100644 --- a/include/sysemu/seccomp.h +++ b/include/sysemu/seccomp.h @@ -18,6 +18,7 @@ #define OBSOLETE 0x0001 #define PRIVILEGED 0x0010 #define SPAWN 0x0100 +#define RESOURCECTL 0x1000 =20 #include =20 diff --git a/qemu-options.hx b/qemu-options.hx index 611a501684..77b437a052 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -4004,11 +4004,12 @@ Old param mode (ARM only). ETEXI =20 DEF("sandbox", HAS_ARG, QEMU_OPTION_sandbox, \ - "-sandbox on[,obsolete=3Dallow][,elevateprivileges=3Dallow|deny|childr= en][,spawn=3Ddeny]\n" \ + "-sandbox on[,obsolete=3Dallow][,elevateprivileges=3Dallow|deny|childr= en][,spawn=3Ddeny][,resourcecontrol=3Ddeny]\n" \ " Enable seccomp mode 2 system call filt= er (default 'off').\n" \ " obsolete: Allow obsolete system calls\= n" \ " elevateprivileges: allows or denies Qe= mu process to elevate its privileges by blacklisting all set*uid|gid system= calls. 'children' will deny set*uid|gid system calls for main Qemu process= but will allow forks and execves to run unprivileged", " spawn: avoids Qemu to spawn new thread= s or processes by blacklisting *fork and execve\n" + " resourcecontrol: disable process affin= ity and schedular priority\n", QEMU_ARCH_ALL) STEXI @item -sandbox @var{arg}[,obsolete=3D@var{string}] @@ -4022,6 +4023,8 @@ Enable Obsolete system calls Disable set*uid|gid systema calls @item spawn=3D@var{string} Disable *fork and execve +@item resourcecontrol=3D@var{string} +Disable process affinity and schedular priority @end table ETEXI =20 diff --git a/qemu-seccomp.c b/qemu-seccomp.c index 075d87e27f..a9a35456e9 100644 --- a/qemu-seccomp.c +++ b/qemu-seccomp.c @@ -31,6 +31,19 @@ struct QemuSeccompSyscall { uint8_t priority; }; =20 +static const struct QemuSeccompSyscall resourcecontrol_syscalls[] =3D { + { SCMP_SYS(getpriority), 255 }, + { SCMP_SYS(setpriority), 255 }, + { SCMP_SYS(sched_setparam), 255 }, + { SCMP_SYS(sched_getparam), 255 }, + { SCMP_SYS(sched_setscheduler), 255 }, + { SCMP_SYS(sched_getscheduler), 255 }, + { SCMP_SYS(sched_setaffinity), 255 }, + { SCMP_SYS(sched_getaffinity), 255 }, + { SCMP_SYS(sched_get_priority_max), 255 }, + { SCMP_SYS(sched_get_priority_min), 255 }, +}; + static const struct QemuSeccompSyscall spawn_syscalls[] =3D { { SCMP_SYS(fork), 255 }, { SCMP_SYS(vfork), 255 }, @@ -158,6 +171,20 @@ int seccomp_start(uint8_t seccomp_opts) } } =20 + if (seccomp_opts & RESOURCECTL) { + for (i =3D 0; i < ARRAY_SIZE(resourcecontrol_syscalls); i++) { + rc =3D seccomp_rule_add(ctx, SCMP_ACT_KILL, resourcecontrol_sy= scalls[i].num, 0); + if (rc < 0) { + goto seccomp_return; + } + rc =3D seccomp_syscall_priority(ctx, resourcecontrol_syscalls[= i].num, + resourcecontrol_syscalls[i].priority); + if (rc < 0) { + goto seccomp_return; + } + } + } + rc =3D seccomp_load(ctx); =20 seccomp_return: diff --git a/vl.c b/vl.c index 456a518431..8e92052603 100644 --- a/vl.c +++ b/vl.c @@ -283,6 +283,10 @@ static QemuOptsList qemu_sandbox_opts =3D { .name =3D "spawn", .type =3D QEMU_OPT_STRING, }, + { + .name =3D "resourcecontrol", + .type =3D QEMU_OPT_STRING, + }, { /* end of list */ } }, }; @@ -1075,6 +1079,13 @@ static int parse_sandbox(void *opaque, QemuOpts *opt= s, Error **errp) } } =20 + value =3D qemu_opt_get(opts,"resourcecontrol"); + if (value) { + if (strcmp(value, "deny") =3D=3D 0) { + seccomp_opts |=3D RESOURCECTL; + } + } + if (seccomp_start(seccomp_opts) < 0) { error_report("failed to install seccomp syscall filter " "in the kernel"); --=20 2.13.0