From nobody Tue Feb 10 01:33:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1500013215624938.9272586666842; Thu, 13 Jul 2017 23:20:15 -0700 (PDT) Received: from localhost ([::1]:35703 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVtxV-00056B-Ct for importer@patchew.org; Fri, 14 Jul 2017 02:20:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVtt1-000151-Jy for qemu-devel@nongnu.org; Fri, 14 Jul 2017 02:15:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVtt0-00026y-AA for qemu-devel@nongnu.org; Fri, 14 Jul 2017 02:15:35 -0400 Received: from ozlabs.org ([103.22.144.67]:40123) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dVtsz-00026O-VM; Fri, 14 Jul 2017 02:15:34 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 3x82VQ6gLbz9t2m; Fri, 14 Jul 2017 16:15:25 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1500012926; bh=AEKh38IZGE4O5DN8j/mj6m6Px9Qd25zBPVW3c1SJUwg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aVHzrJTxGJI+SH970wf9gFgM8A7SeuYJNE8ywVdkwIoEtlP1WPvZeHefLMAbgIJK5 dzwJ6w3KOTvBqbtqf9aSE8lZI4rwwxMXkd9LnLQOVllzsWNSKxnoQNp26AIddL5OlM 4tRTWX40oQudJ4bQ9UcV0c7XQ/p8Nw3n3pRTucsk= From: David Gibson To: peter.maydell@linaro.org Date: Fri, 14 Jul 2017 16:15:09 +1000 Message-Id: <20170714061521.28300-7-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170714061521.28300-1-david@gibson.dropbear.id.au> References: <20170714061521.28300-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 103.22.144.67 Subject: [Qemu-devel] [PULL 06/18] spapr: Abort on delete failure in spapr_drc_release() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, sbobroff@au1.ibm.com, mdroth@linux.vnet.ibm.com, groug@kaod.org, qemu-ppc@nongnu.org, sjitindarsingh@gmail.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We currently ignore errors from the object_property_del() in spapr_drc_release(). But the only way that could fail is if the property doesn't exist, in which case it's a bug that we're in spapr_drc_release() at all. So change from ignoring to abort()ing on errors. Signed-off-by: David Gibson --- hw/ppc/spapr_drc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index 89ba3d6b79..35b779451d 100644 --- a/hw/ppc/spapr_drc.c +++ b/hw/ppc/spapr_drc.c @@ -367,7 +367,7 @@ static void spapr_drc_release(sPAPRDRConnector *drc) g_free(drc->fdt); drc->fdt =3D NULL; drc->fdt_start_offset =3D 0; - object_property_del(OBJECT(drc), "device", NULL); + object_property_del(OBJECT(drc), "device", &error_abort); drc->dev =3D NULL; } =20 --=20 2.13.0