From nobody Wed Nov 5 10:30:41 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149939514867728.935079249105684; Thu, 6 Jul 2017 19:39:08 -0700 (PDT) Received: from localhost ([::1]:54175 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTJAh-00078S-10 for importer@patchew.org; Thu, 06 Jul 2017 22:39:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTIww-0003T2-IO for qemu-devel@nongnu.org; Thu, 06 Jul 2017 22:24:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTIwv-0001BH-Pn for qemu-devel@nongnu.org; Thu, 06 Jul 2017 22:24:54 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:34476) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dTIwv-0001B6-LW for qemu-devel@nongnu.org; Thu, 06 Jul 2017 22:24:53 -0400 Received: by mail-qk0-x241.google.com with SMTP id 91so2764838qkq.1 for ; Thu, 06 Jul 2017 19:24:53 -0700 (PDT) Received: from bigtime.twiddle.net.com (rrcs-66-91-136-156.west.biz.rr.com. [66.91.136.156]) by smtp.gmail.com with ESMTPSA id i85sm1407176qke.66.2017.07.06.19.24.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jul 2017 19:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=HGTCvmI5mKh7q7SAmMAOdcW42Zto47Mti1NgZc/4HUA=; b=h4pP4rZ8JUU8ibqPhBMu7WpD0o+43BjuBHf4KIS/VDeSQGsihf+5WT11aXQCsyl5Ld GkSoUxs8XuNmSyK79a0Y0TWRxS/PEXHbrOQZNppsCN4KW/z0Ipmtz6G7sHKRnVNKNiZZ gVeSjyI9RUxI/MNOCfhhs3GHQHe+84VHID/T7JkWJSZYnjyr+CM5L2Sgpj99uIAoapeU gbKCi0UTrSC1tvjTdbl8UbwhcTK5FXgSAFZy17SaNdyAjoNIsn2n9rFpXJ9k5mwOljyr YBp/NGBlIa8PLed0+UaYfvuGoSGSGfmE453MXrVqUa4kLXBUTBST2/vVnkQVKL8BqONq ncCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=HGTCvmI5mKh7q7SAmMAOdcW42Zto47Mti1NgZc/4HUA=; b=jU4drEKCoA+dwzJAz3mhVRm9BKgcVa8B0yiO0hgV2UBPYAcqdbshPTorTwAYLXMZxz wVKE9ii2oX8sVOxIrurnVMAhGW3eMerRJXj+5mCICQrr+ey7xsk0xOnWwsG2vyl226uB INCwxjGfJN3IlKSB1X3X1WlgGfoTQZnJ46hB/IGZNDbYQ9MKpWYEiGOzi2G5Lxtx0Gej /ByniBeekVt7FS31EDOO/RwHcqOzV01w97zGGKzXD1duXY9qGiJ+KznHnxbqN0jOiRc3 OZvAKmV5t86CIOVRC/bsOFxrS1sLt5nIDQbHH6j3nv7TPlyMf57q5nywGDst5cP0Y6Vp pyow== X-Gm-Message-State: AKS2vOxlrqBfq8BbTMYa88Xs0ltTUk5sEWwp9Vc+OfWUbzDwxvqZ2Ye/ 0VEKBwjCF4yi9MeEXig= X-Received: by 10.55.55.6 with SMTP id e6mr60647637qka.72.1499394293028; Thu, 06 Jul 2017 19:24:53 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 6 Jul 2017 16:21:05 -1000 Message-Id: <20170707022111.21836-22-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170707022111.21836-1-rth@twiddle.net> References: <20170707022111.21836-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::241 Subject: [Qemu-devel] [PATCH v2 21/27] target/sh4: Tidy misc illegal insn checks X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bruno@clisp.org, laurent@vivier.eu, aurelien@aurel32.net, glaubitz@debian.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Now that we have a do_illegal label, use goto in order to self-document the forcing of the exception. Signed-off-by: Richard Henderson Reviewed-by: Aurelien Jarno Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/sh4/translate.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index a4370c6..06cf649 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -1079,8 +1079,9 @@ static void _decode_opc(DisasContext * ctx) if (ctx->tbflags & FPSCR_PR) { TCGv_i64 fp0, fp1; =20 - if (ctx->opcode & 0x0110) - break; /* illegal instruction */ + if (ctx->opcode & 0x0110) { + goto do_illegal; + } fp0 =3D tcg_temp_new_i64(); fp1 =3D tcg_temp_new_i64(); gen_load_fpr64(ctx, fp0, B11_8); @@ -1142,7 +1143,7 @@ static void _decode_opc(DisasContext * ctx) { CHECK_FPU_ENABLED if (ctx->tbflags & FPSCR_PR) { - break; /* illegal instruction */ + goto do_illegal; } else { gen_helper_fmac_FT(FREG(B11_8), cpu_env, FREG(0), FREG(B7_4), FREG(B11_8)); @@ -1693,8 +1694,9 @@ static void _decode_opc(DisasContext * ctx) CHECK_FPU_ENABLED if (ctx->tbflags & FPSCR_PR) { TCGv_i64 fp; - if (ctx->opcode & 0x0100) - break; /* illegal instruction */ + if (ctx->opcode & 0x0100) { + goto do_illegal; + } fp =3D tcg_temp_new_i64(); gen_helper_float_DT(fp, cpu_env, cpu_fpul); gen_store_fpr64(ctx, fp, B11_8); @@ -1708,8 +1710,9 @@ static void _decode_opc(DisasContext * ctx) CHECK_FPU_ENABLED if (ctx->tbflags & FPSCR_PR) { TCGv_i64 fp; - if (ctx->opcode & 0x0100) - break; /* illegal instruction */ + if (ctx->opcode & 0x0100) { + goto do_illegal; + } fp =3D tcg_temp_new_i64(); gen_load_fpr64(ctx, fp, B11_8); gen_helper_ftrc_DT(cpu_fpul, cpu_env, fp); @@ -1730,8 +1733,9 @@ static void _decode_opc(DisasContext * ctx) case 0xf06d: /* fsqrt FRn */ CHECK_FPU_ENABLED if (ctx->tbflags & FPSCR_PR) { - if (ctx->opcode & 0x0100) - break; /* illegal instruction */ + if (ctx->opcode & 0x0100) { + goto do_illegal; + } TCGv_i64 fp =3D tcg_temp_new_i64(); gen_load_fpr64(ctx, fp, B11_8); gen_helper_fsqrt_DT(fp, cpu_env, fp); --=20 2.9.4