From nobody Wed Nov 5 10:07:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499394731008874.7465674633823; Thu, 6 Jul 2017 19:32:11 -0700 (PDT) Received: from localhost ([::1]:54147 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTJ3x-0001En-Lx for importer@patchew.org; Thu, 06 Jul 2017 22:32:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTIwu-0003R8-Ii for qemu-devel@nongnu.org; Thu, 06 Jul 2017 22:24:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTIwr-00018V-FO for qemu-devel@nongnu.org; Thu, 06 Jul 2017 22:24:52 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:34473) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dTIwr-00018H-Al for qemu-devel@nongnu.org; Thu, 06 Jul 2017 22:24:49 -0400 Received: by mail-qk0-x242.google.com with SMTP id 91so2764714qkq.1 for ; Thu, 06 Jul 2017 19:24:49 -0700 (PDT) Received: from bigtime.twiddle.net.com (rrcs-66-91-136-156.west.biz.rr.com. [66.91.136.156]) by smtp.gmail.com with ESMTPSA id i85sm1407176qke.66.2017.07.06.19.24.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jul 2017 19:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=TJiYS0ZMP5YwsXdp4u0pkCtIgzCP2oD9Ug7lfYOzNag=; b=mH5SOCNqeq3VJ8nMHNJrOimPKjvtq9Qg7BIvnuWdI23gzSPkVgyxnegn2SREwclnYm Wq/qgXCCtPfdWmQB1hRp31xubMoFYD+eq8JhU6kjldyFNrBo2GNz/xzaToo7BK2F8INR lVxtN+MdnMujLq/9O9iKqbkmDb1pbW6a8YW2Td6jU7Vkmy/uMZ4C+PGxRPch/X09JgDO qwnDbulaYFxJPfJft4WxEnPak6SXjXn+7xFjk1UekXF28EeSzgJYNZ2FBYOp9PnpWw1P tJW5HFd7ycn1DYE4SxP+6NAPvQd85gVqoKOmjcfNBMSl3ret3c8G86H0RZjp65ZkOkDD Y4/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=TJiYS0ZMP5YwsXdp4u0pkCtIgzCP2oD9Ug7lfYOzNag=; b=WEMZXTbPV2YjpR3XPN/jg0qWmN1p7Xc3/VUDdflTGGwiM2y3IlA7jlE76lCFQ+VYyH zKO+OZgZ3qBAt9DJzBrUqJHC2TouWEd9IYx1uMpBMr0zzPzYkTmmfzVjq2MyIibZZmna 8FXQoZXxypyRTXiixUURT3mfyILgcgZiifzWz53aRSSvjljw5Tsio0yfjDRUR0qPQArc BjYS4t0wNLEPvSq6777xUgAyN0mYVrzXKnt0PNvONipLY536PoBmCchGv4OPkQIu/rU/ V7N1r6+8/hMRgsWB7QlBnnAg6HViyxdLgDPNZRkaBh1pRKOvpIj0/AFf6OGsFMDN0udU 70GQ== X-Gm-Message-State: AKS2vOy7zZP+zOSxYUhSDRt9ebe8qoFE8xnrP7Ws9doPlT+FYnkykG3h 0DjNSfUEYnDz7yR04Nk= X-Received: by 10.55.214.78 with SMTP id t75mr58388090qki.239.1499394288594; Thu, 06 Jul 2017 19:24:48 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 6 Jul 2017 16:21:04 -1000 Message-Id: <20170707022111.21836-21-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170707022111.21836-1-rth@twiddle.net> References: <20170707022111.21836-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::242 Subject: [Qemu-devel] [PATCH v2 20/27] target/sh4: Unify code for CHECK_FPU_ENABLED X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bruno@clisp.org, laurent@vivier.eu, aurelien@aurel32.net, glaubitz@debian.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We do not need to emit N copies of raising an exception. Signed-off-by: Richard Henderson Reviewed-by: Aurelien Jarno Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/sh4/translate.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index dd14b43..a4370c6 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -386,16 +386,9 @@ static inline void gen_store_fpr64(DisasContext *ctx, = TCGv_i64 t, int reg) goto do_illegal; \ } =20 -#define CHECK_FPU_ENABLED \ - if (ctx->tbflags & (1u << SR_FD)) { \ - gen_save_cpu_state(ctx, true); \ - if (ctx->envflags & DELAY_SLOT_MASK) { \ - gen_helper_raise_slot_fpu_disable(cpu_env); \ - } else { \ - gen_helper_raise_fpu_disable(cpu_env); \ - } \ - ctx->bstate =3D BS_EXCP; \ - return; \ +#define CHECK_FPU_ENABLED \ + if (ctx->tbflags & (1u << SR_FD)) { \ + goto do_fpu_disabled; \ } =20 static void _decode_opc(DisasContext * ctx) @@ -1820,6 +1813,17 @@ static void _decode_opc(DisasContext * ctx) gen_helper_raise_illegal_instruction(cpu_env); } ctx->bstate =3D BS_EXCP; + return; + + do_fpu_disabled: + gen_save_cpu_state(ctx, true); + if (ctx->envflags & DELAY_SLOT_MASK) { + gen_helper_raise_slot_fpu_disable(cpu_env); + } else { + gen_helper_raise_fpu_disable(cpu_env); + } + ctx->bstate =3D BS_EXCP; + return; } =20 static void decode_opc(DisasContext * ctx) --=20 2.9.4