From nobody Wed Nov 5 10:05:23 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1499395022147275.5640760845363; Thu, 6 Jul 2017 19:37:02 -0700 (PDT) Received: from localhost ([::1]:54169 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTJ8e-0005My-OG for importer@patchew.org; Thu, 06 Jul 2017 22:37:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTIwo-0003NW-B4 for qemu-devel@nongnu.org; Thu, 06 Jul 2017 22:24:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTIwn-00016S-Ht for qemu-devel@nongnu.org; Thu, 06 Jul 2017 22:24:46 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:35629) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dTIwn-00016G-Cz for qemu-devel@nongnu.org; Thu, 06 Jul 2017 22:24:45 -0400 Received: by mail-qk0-x244.google.com with SMTP id 16so2746613qkg.2 for ; Thu, 06 Jul 2017 19:24:45 -0700 (PDT) Received: from bigtime.twiddle.net.com (rrcs-66-91-136-156.west.biz.rr.com. [66.91.136.156]) by smtp.gmail.com with ESMTPSA id i85sm1407176qke.66.2017.07.06.19.24.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jul 2017 19:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=KTBCGkD7lObR4sJz3hFV/VfsJKkUPnC0pCyHjqX/ocY=; b=ul8ukEOzfFacbr/n3Qssr1GQjzQJEV4amT5soS6tdU1QmhtbZe34aTj+CboYdCM+f9 GbcxbS7Ci9lpfub/fbAWquSait8RCRJsH2wwkzPAu8vLcPODCHrfnqqmcX1IzENdbiB+ Tbe3FCLIvicvQpMtT9IEHKNHa+xBfxi4SeRfkjMO0BQEBRq4wLumZ5zI3T89/3s3z/pH xoJ0yKmdid4G0v/TkhW9KCyzpwEkZeNpIQ0bfE5xdXwqLuPlQmzHYMejM6oPO1B7eGqI ksQi85lrNnuJWoew8LF9l38TB5Ts7eLTKY1oAE6Zta5XtlFkzuOQdYYvuaDqEUiFx8NF gAhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=KTBCGkD7lObR4sJz3hFV/VfsJKkUPnC0pCyHjqX/ocY=; b=MU9wcH4PJ4J1z+n4E6tdmDcNPurL39+fooyT/mItfZoORikZzHTCCXSuGAPMLZAVOi xjKmaiS59svmMqIWiUvIwrCZBm+hKDdUjNdN9W5XjXisVoGjLllYX/jPRov4I1FUuCti 6Ci+NUQbJVOrv6oKI5FHhH/d/7Uf5fxDbFs7go1xAaVaYy9V10iRjaD4c/Qf4HE9aUVt fJHM3VgJ5uiWrnC86XoplwIpHtZvIcs+/I5OWQFHi2iVekw0sfI7p/jmStlsdEDns360 03d6uAwa1B7lQ1Oad5DF6Pf3yxYABM/PgoEbpG3oSqlxvqzNMoDa/45u1VYDFDpyVVur cRxw== X-Gm-Message-State: AIVw113w+vKKPnLepXP0xv2l5me+sdM1hPmo0nVFa4g086gNkUdaXCUk MEODjUi6ZTj14Th9MkI= X-Received: by 10.55.178.135 with SMTP id b129mr18346982qkf.189.1499394284787; Thu, 06 Jul 2017 19:24:44 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 6 Jul 2017 16:21:03 -1000 Message-Id: <20170707022111.21836-20-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170707022111.21836-1-rth@twiddle.net> References: <20170707022111.21836-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH v2 19/27] target/sh4: Unify code for CHECK_PRIVILEGED X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bruno@clisp.org, laurent@vivier.eu, aurelien@aurel32.net, glaubitz@debian.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We do not need to emit N copies of raising an exception. Signed-off-by: Richard Henderson Reviewed-by: Aurelien Jarno Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/sh4/translate.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 41157a0..dd14b43 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -381,16 +381,9 @@ static inline void gen_store_fpr64(DisasContext *ctx, = TCGv_i64 t, int reg) goto do_illegal_slot; \ } =20 -#define CHECK_PRIVILEGED \ - if (IS_USER(ctx)) { \ - gen_save_cpu_state(ctx, true); \ - if (ctx->envflags & DELAY_SLOT_MASK) { \ - gen_helper_raise_slot_illegal_instruction(cpu_env); \ - } else { \ - gen_helper_raise_illegal_instruction(cpu_env); \ - } \ - ctx->bstate =3D BS_EXCP; \ - return; \ +#define CHECK_PRIVILEGED \ + if (IS_USER(ctx)) { \ + goto do_illegal; \ } =20 #define CHECK_FPU_ENABLED \ @@ -1817,6 +1810,7 @@ static void _decode_opc(DisasContext * ctx) ctx->opcode, ctx->pc); fflush(stderr); #endif + do_illegal: if (ctx->envflags & DELAY_SLOT_MASK) { do_illegal_slot: gen_save_cpu_state(ctx, true); --=20 2.9.4