From nobody Sun May 5 21:08:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1498239373033626.9992882170852; Fri, 23 Jun 2017 10:36:13 -0700 (PDT) Received: from localhost ([::1]:36673 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dOSV9-0004pV-Jx for importer@patchew.org; Fri, 23 Jun 2017 13:36:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dORin-0007aN-T9 for qemu-devel@nongnu.org; Fri, 23 Jun 2017 12:46:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dORin-0002CX-4u for qemu-devel@nongnu.org; Fri, 23 Jun 2017 12:46:13 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:33643) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dORin-0002CH-0K; Fri, 23 Jun 2017 12:46:13 -0400 Received: by mail-qk0-x244.google.com with SMTP id p21so6905659qke.0; Fri, 23 Jun 2017 09:46:12 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id x7sm3690803qkx.45.2017.06.23.09.46.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Jun 2017 09:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HlSkjknXLawAhgZUMH7yuaCbXX26J/nW89nIz7w34kY=; b=RfwYiulF/Quw4umrpNs3LnGt6s3qwIurhsCZ3yZT6vLaB/jUvBdPnD0ghTX3jLUfxF Oj5iG+v7LfmZQLzK74M4uGlJfc9ArFnadlbKvKQtaJ4E0tQrAixOtFvIcCWTgJ8smUzr snlQyp1CTZZuJi7z3MQuwFb5BtmsvI6kYgWKOHhz+IVPpco/zb0Cgc8R1nCyEMvbas8h tkfPXSkFpjysrC5Gvr/CoPaT7EOx748lqTHsn6Jp+3dsb8B5efuqkwAhJjW9nQ9tJHXl kQ4RP8ZZkSA5OlU7U+4zwSOmNePfGvHKfPKCRL3pxC49YixpU9S7He4jb4G1GBhRmXuE NvXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=HlSkjknXLawAhgZUMH7yuaCbXX26J/nW89nIz7w34kY=; b=XECT7vPwk6P+RkmbmiEOvZS/rgw28FVQEAzm4gGdctQOY+8lWo+bLpRGMoOaGt2ETu MQG28u495BeciHNTuuzWKQfOV/HxPKTghaamGxFoXn4E0LdUX53zTwZ/GmtRwK8fjpSX NfyBop8voa/GHzRExcMta8nTj/9XBpoi1Bx3FhZ8gFuhPCbChwXnGrClAnuZJQVBiUSh /UKitqoJIB8VG8WyZvk9ztMWxh8777J56kZInIrfcYNKRZ/ElRumnFfzpRDEhtv442HH 8K69kKmaiHt7FUq/mv0/nN23K8CqJQIFCdA4kz9DuZjG/Jvo64dH1l4DaXjL/GypBt7r wsgg== X-Gm-Message-State: AKS2vOwnywS5UowVrJWki9BS+IN1o7W52KVKuLLyVKTgGZ7lVGpJ8D39 fDaHOng6ccJ+Zzj2rf7umA== X-Received: by 10.55.125.65 with SMTP id y62mr9411533qkc.143.1498236372125; Fri, 23 Jun 2017 09:46:12 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell , qemu-trivial@nongnu.org, Eric Blake , Peter Crosthwaite , Markus Armbruster , Laszlo Ersek , "Michael S . Tsirkin" , Gerd Hoffmann , Alexander Graf , David Gibson , Eduardo Habkost , Alistair Francis Date: Fri, 23 Jun 2017 13:45:55 -0300 Message-Id: <20170623164557.11636-2-f4bug@amsat.org> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20170623164557.11636-1-f4bug@amsat.org> References: <20170623164557.11636-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH 1/3] elf-loader: warn about invalid endianess X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 fprintf(stderr) is how errors are reported in this file. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laszlo Ersek --- hw/core/loader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/core/loader.c b/hw/core/loader.c index f72930ca4a..094f24627f 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -478,6 +478,7 @@ int load_elf_ram(const char *filename, } =20 if (target_data_order !=3D e_ident[EI_DATA]) { + fprintf(stderr, "%s: wrong endianess\n", filename); ret =3D ELF_LOAD_WRONG_ENDIAN; goto fail; } --=20 2.13.1 From nobody Sun May 5 21:08:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1498238971091877.0972066104899; Fri, 23 Jun 2017 10:29:31 -0700 (PDT) Received: from localhost ([::1]:36619 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dOSOf-000721-FV for importer@patchew.org; Fri, 23 Jun 2017 13:29:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dORjG-000803-2n for qemu-devel@nongnu.org; Fri, 23 Jun 2017 12:46:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dORjD-0002TU-0G for qemu-devel@nongnu.org; Fri, 23 Jun 2017 12:46:42 -0400 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:34663) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dORjC-0002TG-SI; Fri, 23 Jun 2017 12:46:38 -0400 Received: by mail-qt0-x242.google.com with SMTP id w6so5940564qtg.1; Fri, 23 Jun 2017 09:46:38 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id x7sm3690803qkx.45.2017.06.23.09.46.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Jun 2017 09:46:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jAVRxV2g6Z+TdnzrBVyyvRfbsU44tbvLdl7adBc7pa0=; b=eiDjJtgrlomisLXRDHWgqLwy6AQRV/yzmiXIGpkrzqynHjfcIe8mBPxgDwLbTGCgZ/ 0F7C++x7/ChaxjdgKlWU5ONQD4JN6qhfElgMLlsstRWUta0Wb04tNf86p6yjt/sOSQuy orqi55beh1mnvRt5f5xBW9Zz2ijBCMBjejmA98bqUc6sehKSt0W8qAWUsi0g3L5TXgJi eKi9YHDuH2XCb/VCD/4SU1H/2z71vJpdK3yndoycq5McqzDOEmagvVbk7EtTRKpXbkh+ n5YdzaiHr2Nr+t4JIHAg8gHten5uvrKFF6rARfYDpbMAYPoImWDO6NQBFyMKqqngh+kt jnAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=jAVRxV2g6Z+TdnzrBVyyvRfbsU44tbvLdl7adBc7pa0=; b=ivwC0to7j7B6+99dyKjPyVRHz2fYjoFP/8CPRIq4e0ZKTThJTxL4IYmG02pz/PHesV 06ORIRjjXewbLUaGcFU+ea6DjxeFtFAwznyf4UcNNtBiX29SokyMWNTAz7UP39re25it cD5lGJ2a0We+WDWeEb4qmff0ZdTmjDVCrlX/jyKcptOQYwN6uiI00P6IJ2pqD+jpggh1 OVUCcew2s1MdMrmkSVNsGiiD+k+L/if1hbQDgjviVlTMaSIR5TwMMDbLcW14SIaJtn3P jgi77M0VztFzD8YA4WDw/ef3hOs7agZrbDyovBD3bzgSn4WUcRCIn2Jxy9fdzFM6Prrw yIoA== X-Gm-Message-State: AKS2vOyfCvlsJqsQhvC2lBj4nObOfE+3au4Ad2K4c63gxcUZVeuZY3HM Jn15G3HEHTflO6j+woIYeA== X-Received: by 10.237.60.218 with SMTP id e26mr11591418qtf.106.1498236398140; Fri, 23 Jun 2017 09:46:38 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell , qemu-trivial@nongnu.org, Eric Blake , Peter Crosthwaite , Markus Armbruster , Laszlo Ersek , "Michael S . Tsirkin" , Gerd Hoffmann , Alexander Graf , David Gibson , Eduardo Habkost , Alistair Francis Date: Fri, 23 Jun 2017 13:45:56 -0300 Message-Id: <20170623164557.11636-3-f4bug@amsat.org> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20170623164557.11636-1-f4bug@amsat.org> References: <20170623164557.11636-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PATCH 2/3] hw/core: fix missing return value in load_image_targphys_as() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Reviewed-by: Laszlo Ersek --- hw/core/loader.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 094f24627f..e137e772ae 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -150,7 +150,9 @@ int load_image_targphys_as(const char *filename, return -1; } if (size > 0) { - rom_add_file_fixed_as(filename, addr, -1, as); + if (rom_add_file_fixed_as(filename, addr, -1, as) < 0) { + return -1; + } } return size; } --=20 2.13.1 From nobody Sun May 5 21:08:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1498239771202180.50928262747323; Fri, 23 Jun 2017 10:42:51 -0700 (PDT) Received: from localhost ([::1]:36723 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dOSbY-0001TG-Vn for importer@patchew.org; Fri, 23 Jun 2017 13:42:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dORjH-00081P-Fh for qemu-devel@nongnu.org; Fri, 23 Jun 2017 12:46:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dORjG-0002Uq-OG for qemu-devel@nongnu.org; Fri, 23 Jun 2017 12:46:43 -0400 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:36283) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dORjG-0002Uk-K3 for qemu-devel@nongnu.org; Fri, 23 Jun 2017 12:46:42 -0400 Received: by mail-qt0-x242.google.com with SMTP id v31so2026302qtb.3 for ; Fri, 23 Jun 2017 09:46:42 -0700 (PDT) Received: from yoga.offpageads.com ([138.117.48.226]) by smtp.gmail.com with ESMTPSA id x7sm3690803qkx.45.2017.06.23.09.46.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Jun 2017 09:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QDrd9WkeZruOUaX/2nTP/dS1GuFHJ3z2iub0Nj3Z/HU=; b=TgLCo6/3URF9TAGlUysAQIghUrTOyuofkxAi1/4fotftVHgmp5asW70efmUUMR5+48 dDFGig+2WUJE4VB7EWjOAhjVka0iSwgq8QAJ1+yKm2oaCYLwuOCWs8eniRqP8lskh3Db DuYCxNw+8M17/A/hWlV/k0etPDfMtjkl5D1VrUZXyj5kr8Ktyf2r+A4cm3+m29ffK2ja Agcu/SvbBoTXVItUlyGN8oFmwy61PZu0sTDV3QD27zO8uBshCH0AOR06UEHhxuqwMi2S 0IB5r5pvGq+mgV9x8gb7bZLbS9xB0+0hFETRShORyxlyUhaI2iobFJiJEDZgsFec2M96 c2AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=QDrd9WkeZruOUaX/2nTP/dS1GuFHJ3z2iub0Nj3Z/HU=; b=e8CWCsrDJPICII8aGHkB/P6e4BnyhuMN13+I/5v1TkdUhfMCBFAG2j6Qk1DpbddmkK Qr1JiNwiM4qQ7UULPJ+l6gNRJufFe7uhCqXYEXqU5zB9AUtZ5/zDPYMm1MoSuF8sQiJn uDpg8bwq+wr1XHrl2g13YOLw6CLcktzpTF7ggZhGYjP9Ot6+8sPwQQLx42rJDva3KU0X UEe/VnHTHe+HXNIc+9M0BYexAzYM6Vu+eIfgwnfZdJHX4t7lZr3CBBvxIvszinNpwsoh dcJqCJUoq3ParigDTw1iLXv6B3iLnN/b7KHeht+p/csn0YuK/IR9gEnhsFeJtS4DZz2z PZmQ== X-Gm-Message-State: AKS2vOxRNwsdr9dbvX8CNhcMLYrYp1+3CbkUq8ejr87OABplsrarH7Hi msZoVKHLyogFMVOaAFJZ7w== X-Received: by 10.200.41.138 with SMTP id 10mr10036567qts.85.1498236401987; Fri, 23 Jun 2017 09:46:41 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Peter Maydell , Eric Blake , Peter Crosthwaite , Markus Armbruster , Laszlo Ersek , "Michael S . Tsirkin" , Gerd Hoffmann , Alexander Graf , David Gibson , Eduardo Habkost Date: Fri, 23 Jun 2017 13:45:57 -0300 Message-Id: <20170623164557.11636-4-f4bug@amsat.org> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20170623164557.11636-1-f4bug@amsat.org> References: <20170623164557.11636-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PATCH 3/3] hw/core: report an error if invalid gpio is used X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 then abort calling error_setg() Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Reviewed-by: Laszlo Ersek --- hw/core/qdev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 849952a8d4..05aaa67cb8 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -448,7 +448,11 @@ qemu_irq qdev_get_gpio_in_named(DeviceState *dev, cons= t char *name, int n) { NamedGPIOList *gpio_list =3D qdev_get_named_gpio_list(dev, name); =20 - assert(n >=3D 0 && n < gpio_list->num_in); + assert(n >=3D 0); + if (n >=3D gpio_list->num_in) { + error_setg(&error_abort, "Invalid gpio #%d (of %d) for %s", + n, gpio_list->num_in, name ? name : "device"); + } return gpio_list->in[n]; } =20 --=20 2.13.1