From nobody Mon Feb 9 15:30:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1498013877876972.0015518733412; Tue, 20 Jun 2017 19:57:57 -0700 (PDT) Received: from localhost ([::1]:51569 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dNVq8-0005wj-Kt for importer@patchew.org; Tue, 20 Jun 2017 22:57:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dNVhG-0006S1-7P for qemu-devel@nongnu.org; Tue, 20 Jun 2017 22:48:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dNVhF-0002N2-Bh for qemu-devel@nongnu.org; Tue, 20 Jun 2017 22:48:46 -0400 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:35641) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dNVhF-0002My-8P for qemu-devel@nongnu.org; Tue, 20 Jun 2017 22:48:45 -0400 Received: by mail-qk0-x243.google.com with SMTP id 16so8295647qkg.2 for ; Tue, 20 Jun 2017 19:48:45 -0700 (PDT) Received: from bigtime.twiddle.net.com (97-113-165-157.tukw.qwest.net. [97.113.165.157]) by smtp.gmail.com with ESMTPSA id l53sm2478939qta.56.2017.06.20.19.48.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jun 2017 19:48:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=hBE1q9W0lWKlhI719ICRtBjn4AfETsgJM+T+gZhdnbk=; b=NpAknUBIfK535r+2Y3ppckYJSEMV8enONwvgA4ArAXp1A1pzec2eZ2QRDeFudH9R1U kyiXUdbf0WK8ZnrV73e7HsD60fmSpy8yj5V0g0m0YSuSY6PI09fHqJlMj86T3W9Dt/l4 A7yfcVzUb5DlZnyBQtgNPTvTU20OiXBPaBESxEnbj8BbrDJYbJP8l5LEHLN9/IuAWDKf A896CmhJZ1FTsxaQsl4axhqoUZKhuoaGFOnxjK4SEW80P2xwIXpjSNyJa+rFrh6LFb+u 5CRAJj0he9xEFe3tO/l43mkZhM3aLXYLDHzDO9BjZaVjlQy9Eo02K/M3jHDrkX8R6+vh FPQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=hBE1q9W0lWKlhI719ICRtBjn4AfETsgJM+T+gZhdnbk=; b=OurbgJLTDaiIgboCrfIinyHAvUCHz/7vf4xbW17a1bdWkCCwMpmFGkHgbHSkvCN+Z1 v36aDxzYjuN6bpe5nFe8V3Z/i2gcR0779try5B6CK3pJe+8YjLr7NhC8MtfqpZSaQB5Z ThV7OFTKWEwa+jwHgJeZV/KJe+S63OtDPblhxiV9/NCBP1hCmf2RTwOksmXKL70cLWmo rOcrbCq/bcxdi4SebziVkUJIAZUQHQDeYWSEqSyJb+M9uBIjCNr45PQwaVyJbYdi2PDW I13/CDdfRYkJBFtsMWoApC7IALEDt8Jwq/+gu3UZ4LxAOb7CWIZDh07OJWEQMoguQfTg /q6w== X-Gm-Message-State: AKS2vOzA4UuTIRWjKh4/jfSqRItftHqJWCwBHllLNn0/CZ+C/oNK8bN1 Cl10TXVqpq1dmySv/yQ= X-Received: by 10.55.44.129 with SMTP id s123mr35575638qkh.137.1498013324532; Tue, 20 Jun 2017 19:48:44 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 20 Jun 2017 19:48:21 -0700 Message-Id: <20170621024831.26019-7-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170621024831.26019-1-rth@twiddle.net> References: <20170621024831.26019-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::243 Subject: [Qemu-devel] [PATCH 06/16] tcg: Add temp_global bit to TCGTemp X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This avoids needing to test the index of a temp against nb_globals. Signed-off-by: Richard Henderson --- tcg/optimize.c | 15 ++++++++------- tcg/tcg.c | 11 ++++++++--- tcg/tcg.h | 12 ++++++++---- 3 files changed, 24 insertions(+), 14 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index d8c3a7e..55f9e83 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -116,25 +116,26 @@ static TCGOpcode op_to_movi(TCGOpcode op) } } =20 -static TCGArg find_better_copy(TCGContext *s, TCGArg temp) +static TCGArg find_better_copy(TCGContext *s, TCGArg arg) { + TCGTemp *ts =3D arg_temp(arg); TCGArg i; =20 /* If this is already a global, we can't do better. */ - if (temp < s->nb_globals) { - return temp; + if (ts->temp_global) { + return arg; } =20 /* Search for a global first. */ - for (i =3D temps[temp].next_copy ; i !=3D temp ; i =3D temps[i].next_c= opy) { + for (i =3D temps[arg].next_copy ; i !=3D arg; i =3D temps[i].next_copy= ) { if (i < s->nb_globals) { return i; } } =20 /* If it is a temp, search for a temp local. */ - if (!arg_temp(temp)->temp_local) { - for (i =3D temps[temp].next_copy ; i !=3D temp ; i =3D temps[i].ne= xt_copy) { + if (!ts->temp_local) { + for (i =3D temps[arg].next_copy ; i !=3D arg; i =3D temps[i].next_= copy) { if (s->temps[i].temp_local) { return i; } @@ -142,7 +143,7 @@ static TCGArg find_better_copy(TCGContext *s, TCGArg te= mp) } =20 /* Failure to find a better representation, return the same temp. */ - return temp; + return arg; } =20 static bool temps_are_copies(TCGArg arg1, TCGArg arg2) diff --git a/tcg/tcg.c b/tcg/tcg.c index 068ac51..0bb88b1 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -489,9 +489,14 @@ static inline TCGTemp *tcg_temp_alloc(TCGContext *s) =20 static inline TCGTemp *tcg_global_alloc(TCGContext *s) { + TCGTemp *ts; + tcg_debug_assert(s->nb_globals =3D=3D s->nb_temps); s->nb_globals++; - return tcg_temp_alloc(s); + ts =3D tcg_temp_alloc(s); + ts->temp_global =3D 1; + + return ts; } =20 static int tcg_global_reg_new_internal(TCGContext *s, TCGType type, @@ -967,7 +972,7 @@ static char *tcg_get_arg_str_ptr(TCGContext *s, char *b= uf, int buf_size, { int idx =3D temp_idx(s, ts); =20 - if (idx < s->nb_globals) { + if (ts->temp_global) { pstrcpy(buf, buf_size, ts->name); } else if (ts->temp_local) { snprintf(buf, buf_size, "loc%d", idx - s->nb_globals); @@ -1905,7 +1910,7 @@ static void temp_free_or_dead(TCGContext *s, TCGTemp = *ts, int free_or_dead) } ts->val_type =3D (free_or_dead < 0 || ts->temp_local - || temp_idx(s, ts) < s->nb_globals + || ts->temp_global ? TEMP_VAL_MEM : TEMP_VAL_DEAD); } =20 diff --git a/tcg/tcg.h b/tcg/tcg.h index 70d9fda..3b35344 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -586,10 +586,14 @@ typedef struct TCGTemp { unsigned int indirect_base:1; unsigned int mem_coherent:1; unsigned int mem_allocated:1; - unsigned int temp_local:1; /* If true, the temp is saved across - basic blocks. Otherwise, it is not - preserved across basic blocks. */ - unsigned int temp_allocated:1; /* never used for code gen */ + /* If true, the temp is saved across both basic blocks and + translation blocks. */ + unsigned int temp_global:1; + /* If true, the temp is saved across basic blocks but dead + at the end of translation blocks. If false, the temp is + dead at the end of basic blocks. */ + unsigned int temp_local:1; + unsigned int temp_allocated:1; =20 tcg_target_long val; struct TCGTemp *mem_base; --=20 2.9.4