From nobody Wed Nov 5 15:40:35 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149741790130462.7783597384182; Tue, 13 Jun 2017 22:25:01 -0700 (PDT) Received: from localhost ([::1]:46451 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dL0nc-0003MQ-0K for importer@patchew.org; Wed, 14 Jun 2017 01:25:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dL0m1-0001nO-VP for qemu-devel@nongnu.org; Wed, 14 Jun 2017 01:23:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dL0m1-0007Kn-1S for qemu-devel@nongnu.org; Wed, 14 Jun 2017 01:23:22 -0400 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:34130) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dL0m0-0007Kc-Tb for qemu-devel@nongnu.org; Wed, 14 Jun 2017 01:23:20 -0400 Received: by mail-qt0-x242.google.com with SMTP id o21so39043165qtb.1 for ; Tue, 13 Jun 2017 22:23:20 -0700 (PDT) Received: from bigtime.twiddle.net.com (97-113-165-157.tukw.qwest.net. [97.113.165.157]) by smtp.gmail.com with ESMTPSA id 34sm10959480qtp.17.2017.06.13.22.23.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Jun 2017 22:23:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=YWyN5gHo62UjLPOyvnzvpfJTn25ykV5dt8aXb/VMaAY=; b=nETnhCFKSEMa3yt8phDBlWQlTshz1ANVD/rkOFYOgzHaj+BBxhsAn85iC+SBRSd91L yD/Jg2xplTw0cg11Exw7pKFHTbDEPKiXcuIvDmPAeWyT8g7+eJNuUIWvAoc+Cj9z9RKS YY78paIRab7+Z55ZNCTu1y5g0TWYWnGKsZEDMWFythNrgO3EttZFxfHLMlKGFBW+5w0F KJNEa3JAXTcusIxngmwwh75rp92lpjn58lEhn9eBCuIR57JOsrGeesx7cLxnEj/pAqxs nnEKI232u6HIJvo6+4r8WooCfy3JzyjrQ5uf6K7vkW/zQGxD2VVbUo8wnLwxgTZtFf2Z S4Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=YWyN5gHo62UjLPOyvnzvpfJTn25ykV5dt8aXb/VMaAY=; b=SKAqgpUeQ9O7ahyK5zPIGVxaT+sl/QyQQb5LUnEIuxivBf/kPq9Hzc39x043C8zyVm KXLSkDRwpQN6ke+h67J+2w3fYlcdTJLKG8VkmibM2CGZXqXiBYHmWaNs7zrdMMgxTG17 /vYk66KY14xeqR0J6Zl016t3L7ejat+tlxeb2IWlXtlEu0EsUZg+bs7/vxN7xbFdg6pF o3JH2Hj6BMJdRyhN0f92By24XM18fWZB5q/9vB/l2Y3X3TqPk4GjUUNieZURIj5ZibKC DZTkeiQc3pAfU0uqKsIj3LzSYq3HihmulX6axu6RjfoFYqLKqS47URFps4FjIjhHLJlB PRCw== X-Gm-Message-State: AKS2vOzScv2Y6NeKnRZ5Pk97FzRyIvkmDFW+JyumGfvTEhxKyYSUOLte 3qEd08oxUCVwTYyVVzo= X-Received: by 10.237.34.88 with SMTP id o24mr4695406qtc.217.1497417800268; Tue, 13 Jun 2017 22:23:20 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 13 Jun 2017 22:23:04 -0700 Message-Id: <20170614052311.13785-4-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170614052311.13785-1-rth@twiddle.net> References: <20170614052311.13785-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PULL 03/10] translate-all: consolidate tb init in tb_gen_code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, "Emilio G. Cota" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Emilio G. Cota" We are partially initializing tb in tb_alloc. Instead, fully initialize it in tb_gen_code, which is tb_alloc's only caller. This saves an unnecessary write to tb->cflags. Signed-off-by: Emilio G. Cota Message-Id: <1497038122-26364-1-git-send-email-cota@braap.org> Signed-off-by: Richard Henderson --- translate-all.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/translate-all.c b/translate-all.c index bb094ad..46c5592 100644 --- a/translate-all.c +++ b/translate-all.c @@ -843,9 +843,6 @@ static TranslationBlock *tb_alloc(target_ulong pc) ctx->tbs =3D g_renew(TranslationBlock *, ctx->tbs, ctx->tbs_size); } ctx->tbs[ctx->nb_tbs++] =3D tb; - tb->pc =3D pc; - tb->cflags =3D 0; - tb->invalid =3D false; return tb; } =20 @@ -1289,9 +1286,11 @@ TranslationBlock *tb_gen_code(CPUState *cpu, =20 gen_code_buf =3D tcg_ctx.code_gen_ptr; tb->tc_ptr =3D gen_code_buf; + tb->pc =3D pc; tb->cs_base =3D cs_base; tb->flags =3D flags; tb->cflags =3D cflags; + tb->invalid =3D false; =20 #ifdef CONFIG_PROFILER tcg_ctx.tb_count1++; /* includes aborted translations because of --=20 2.9.4