From nobody Mon Feb 9 10:36:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1496986135180586.2067037391138; Thu, 8 Jun 2017 22:28:55 -0700 (PDT) Received: from localhost ([::1]:52667 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJCTc-0005jj-NV for importer@patchew.org; Fri, 09 Jun 2017 01:28:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJCRt-0003uN-7e for qemu-devel@nongnu.org; Fri, 09 Jun 2017 01:27:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJCRs-0006bi-IG for qemu-devel@nongnu.org; Fri, 09 Jun 2017 01:27:05 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:49873) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dJCRr-0006aG-Kf; Fri, 09 Jun 2017 01:27:04 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 3wkW4b5BBwz9s8N; Fri, 9 Jun 2017 15:26:55 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1496986015; bh=F0UBCQmILpad6vT0+MKF6J0XbyvTHcNqTduzuvz9Y+M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P1AuOGqeLSxig3kmdhTTbuUjB92Xqu924TCtDBKwlVFjWvFIN5i3no5JLfyKnbK+I yud31sdaJ2RsnXQwbAYVXSX0xc67+rau8YTwNbgQZj7Q1IHw9BAX/+rHlCV9DudOU/ Ph2+KAAhhPxb5q3o1DVBJkM9kLpg/VRrkn47FHf8= From: David Gibson To: peter.maydell@linaro.org Date: Fri, 9 Jun 2017 15:26:35 +1000 Message-Id: <20170609052652.23200-4-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170609052652.23200-1-david@gibson.dropbear.id.au> References: <20170609052652.23200-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 03/20] spapr: fix memory leak in spapr_memory_pre_plug() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: agraf@suse.de, qemu-devel@nongnu.org, sursingh@redhat.com, mdroth@linux.vnet.ibm.com, Greg Kurz , qemu-ppc@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Greg Kurz The string returned by object_property_get_str() is dynamically allocated. (Spotted by Coverity, CID 1375942) Signed-off-by: Greg Kurz Signed-off-by: David Gibson --- hw/ppc/spapr.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 91b4057..9b7ae28 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -2615,8 +2615,11 @@ static void spapr_memory_pre_plug(HotplugHandler *ho= tplug_dev, DeviceState *dev, if (mem_dev && !kvmppc_is_mem_backend_page_size_ok(mem_dev)) { error_setg(errp, "Memory backend has bad page size. " "Use 'memory-backend-file' with correct mem-path."); - return; + goto out; } + +out: + g_free(mem_dev); } =20 struct sPAPRDIMMState { --=20 2.9.4