From nobody Mon Feb 9 05:56:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1496821732321334.4782736088433; Wed, 7 Jun 2017 00:48:52 -0700 (PDT) Received: from localhost ([::1]:41706 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIVhy-0006JL-US for importer@patchew.org; Wed, 07 Jun 2017 03:48:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIVfy-0003zr-Tu for qemu-devel@nongnu.org; Wed, 07 Jun 2017 03:46:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIVfy-0006J0-1h for qemu-devel@nongnu.org; Wed, 07 Jun 2017 03:46:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55958) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dIVfx-0006I0-Rz for qemu-devel@nongnu.org; Wed, 07 Jun 2017 03:46:45 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D34C44E4D0; Wed, 7 Jun 2017 07:46:44 +0000 (UTC) Received: from localhost (ovpn-112-40.ams2.redhat.com [10.36.112.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1627017997; Wed, 7 Jun 2017 07:46:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D34C44E4D0 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=marcandre.lureau@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D34C44E4D0 From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Wed, 7 Jun 2017 11:46:28 +0400 Message-Id: <20170607074632.13162-2-marcandre.lureau@redhat.com> In-Reply-To: <20170607074632.13162-1-marcandre.lureau@redhat.com> References: <20170607074632.13162-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 07 Jun 2017 07:46:45 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 1/5] coccinelle: replace code with ROUND_UP macro X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , peter.maydell@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" I used a the following coccinelle script: @@ expression e1; @@ - ((e1) + (3)) / (4) * (4) + ROUND_UP(e1,4) @@ expression e1; expression e2; @@ -(ROUND_UP(e1,e2)) +ROUND_UP(e1,e2) I tried with various other values (4, 8, 16, 32), but got only the matches in this patch. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Juan Quintela --- target/i386/arch_dump.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target/i386/arch_dump.c b/target/i386/arch_dump.c index fe0aa36932..e6788250b8 100644 --- a/target/i386/arch_dump.c +++ b/target/i386/arch_dump.c @@ -84,9 +84,9 @@ static int x86_64_write_elf64_note(WriteCoreDumpFunction = f, note->n_descsz =3D cpu_to_le32(descsz); note->n_type =3D cpu_to_le32(NT_PRSTATUS); buf =3D (char *)note; - buf +=3D ((sizeof(Elf64_Nhdr) + 3) / 4) * 4; + buf +=3D ROUND_UP(sizeof(Elf64_Nhdr), 4); memcpy(buf, name, name_size); - buf +=3D ((name_size + 3) / 4) * 4; + buf +=3D ROUND_UP(name_size, 4); memcpy(buf + 32, &id, 4); /* pr_pid */ buf +=3D descsz - sizeof(x86_64_user_regs_struct)-sizeof(target_ulong); memcpy(buf, ®s, sizeof(x86_64_user_regs_struct)); @@ -163,9 +163,9 @@ static int x86_write_elf64_note(WriteCoreDumpFunction f= , CPUX86State *env, note->n_descsz =3D cpu_to_le32(descsz); note->n_type =3D cpu_to_le32(NT_PRSTATUS); buf =3D (char *)note; - buf +=3D ((sizeof(Elf64_Nhdr) + 3) / 4) * 4; + buf +=3D ROUND_UP(sizeof(Elf64_Nhdr), 4); memcpy(buf, name, name_size); - buf +=3D ((name_size + 3) / 4) * 4; + buf +=3D ROUND_UP(name_size, 4); memcpy(buf, &prstatus, sizeof(prstatus)); =20 ret =3D f(note, note_size, opaque); @@ -218,9 +218,9 @@ int x86_cpu_write_elf32_note(WriteCoreDumpFunction f, C= PUState *cs, note->n_descsz =3D cpu_to_le32(descsz); note->n_type =3D cpu_to_le32(NT_PRSTATUS); buf =3D (char *)note; - buf +=3D ((sizeof(Elf32_Nhdr) + 3) / 4) * 4; + buf +=3D ROUND_UP(sizeof(Elf32_Nhdr), 4); memcpy(buf, name, name_size); - buf +=3D ((name_size + 3) / 4) * 4; + buf +=3D ROUND_UP(name_size, 4); memcpy(buf, &prstatus, sizeof(prstatus)); =20 ret =3D f(note, note_size, opaque); --=20 2.13.0.91.g00982b8dd