From nobody Wed Nov 5 17:22:31 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1496797728445365.0058606248589; Tue, 6 Jun 2017 18:08:48 -0700 (PDT) Received: from localhost ([::1]:40721 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIPSo-0004Rz-Rd for importer@patchew.org; Tue, 06 Jun 2017 21:08:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIOu7-0003yq-KN for qemu-devel@nongnu.org; Tue, 06 Jun 2017 20:32:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIOu6-0002Wm-Ub for qemu-devel@nongnu.org; Tue, 06 Jun 2017 20:32:55 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:35155) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dIOu6-0002WC-QC for qemu-devel@nongnu.org; Tue, 06 Jun 2017 20:32:54 -0400 Received: by mail-qt0-x244.google.com with SMTP id x58so19244365qtc.2 for ; Tue, 06 Jun 2017 17:32:54 -0700 (PDT) Received: from bigtime.twiddle.net.com (71-217-91-69.tukw.qwest.net. [71.217.91.69]) by smtp.gmail.com with ESMTPSA id m47sm29286qtc.36.2017.06.06.17.32.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Jun 2017 17:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=ANsQcmfPUH5F9tw1lI5XqSp+fKkEEquAyoG3FkEwKVA=; b=WmFrIB2OLaepeFkUlVvUPOuqkFN8+jqwb4X286y5JUTIYW+Aci97oq/3PdxmxJ9ieu t/3ui/eYjgsjTdvqLsw9twz1SNfIniUOZNiFpRtyHoGK6RetCW4vrodDeJoukDv7Fqzj WYHvEcQ26Ig96x4T3qAXSA4j5obvOxAPyEtb85AbL+5TA0jjiVb6TYfuw4+Y66RaXoiv YPoYwUMgFitZCLWq99RPSh0/+fP3i8MspWagpMFliPbsOuekWzaemdRh6AOj25si7eDq T7d3/qLrtT8KXI3tY0kcrZP9iXWofBByt1+KHV4AZhrAzeufocfMVER5rAGtwCRiPrz7 M7nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=ANsQcmfPUH5F9tw1lI5XqSp+fKkEEquAyoG3FkEwKVA=; b=NkpJ96zThBmQpG5ni/476rjGLOZlTDLZtmkHp6ee8y9GelGKApXxy2ya5lW5MdWIPs 7mGAhn4S/iomLoZyyood9yfIsRIIh2DnlvaU8k0vxEaVIdCnPQGj9+oqiR9G58N+4UF2 sBCyqm/IskqmAQlLtFJn/JgBFxJoukwy77/qojnz90Pc7np6aaObfRRdAWwGc0Z5Tskr uSpNPW71Cw/8cxwbPS3m2x+lgVamRp7kiHT8sbK0V7IsJehSBYMY9AxtdGmVdj6faGTC vApEhhmUF5aIHFA226AMXCQWppdXJKa9WMyR9Favf1S/zVbZIOt7YjRC7hdxKeQIUt2s rccA== X-Gm-Message-State: AODbwcBHyooroFiO7olxRRNjk10m5yUCSR1ex5rQkdlaFADe64uzZlNP DQ529wjbrjqLQE/1eLY= X-Received: by 10.237.61.110 with SMTP id h43mr31363220qtf.1.1496795574071; Tue, 06 Jun 2017 17:32:54 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 6 Jun 2017 17:31:17 -0700 Message-Id: <20170607003119.14778-69-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170607003119.14778-1-rth@twiddle.net> References: <20170607003119.14778-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PULL v2 68/70] target/s390x: check alignment in CDSG in the !CONFIG_ATOMIC128 case X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Aurelien Jarno The CDSG instruction requires a 16-byte alignement, as expressed in the MO_ALIGN_16 passed to helper_atomic_cmpxchgo_be_mmu. In the non parallel case, use check_alignment to enforce this. Signed-off-by: Aurelien Jarno Message-Id: <20170604202034.16615-4-aurelien@aurel32.net> Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index a8988e0..80caab9 100644 --- a/target/s390x/mem_helper.c +++ b/target/s390x/mem_helper.c @@ -1262,6 +1262,8 @@ void HELPER(cdsg)(CPUS390XState *env, uint64_t addr, } else { uint64_t oldh, oldl; =20 + check_alignment(env, addr, 16, ra); + oldh =3D cpu_ldq_data_ra(env, addr + 0, ra); oldl =3D cpu_ldq_data_ra(env, addr + 8, ra); =20 --=20 2.9.4