From nobody Wed Nov 5 17:25:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1496796543266493.1475475729046; Tue, 6 Jun 2017 17:49:03 -0700 (PDT) Received: from localhost ([::1]:40629 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIP9h-0001qe-T7 for importer@patchew.org; Tue, 06 Jun 2017 20:49:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIOtD-0002im-Rt for qemu-devel@nongnu.org; Tue, 06 Jun 2017 20:32:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIOtD-00020i-0B for qemu-devel@nongnu.org; Tue, 06 Jun 2017 20:31:59 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:33805) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dIOtC-00020X-T6 for qemu-devel@nongnu.org; Tue, 06 Jun 2017 20:31:58 -0400 Received: by mail-qk0-x244.google.com with SMTP id d14so12247973qkb.1 for ; Tue, 06 Jun 2017 17:31:58 -0700 (PDT) Received: from bigtime.twiddle.net.com (71-217-91-69.tukw.qwest.net. [71.217.91.69]) by smtp.gmail.com with ESMTPSA id m47sm29286qtc.36.2017.06.06.17.31.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Jun 2017 17:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=aNvRSdqH5I9uzHn+zWds7ZYzS3cTybnr3t6gdwpzJNM=; b=SyUvQGvH+pKWyKnPfg3VbhFH8n++DRnt/G5/AU88qv6zpkvyM0pffpgdpM2QXR0KJq /Uw2R1s/v8RsbAKmcE+LLn7Y8Y60qI0qiYAjwBmXrZZrZKZs1hzGmy3iw9fwKonmKL// wQ+UmxqYPKH3pIx1Ab8/pNV9CicXE+ZfK3yY7lFnF7DU9X8HdRqLVsBgeBK0K2pJxBlh xqQNwyq49WUj8EPHb7T72kqGPKV0Nx4avsjl+L0t2H30GAyq+VA7uwVN6k6rt4024uLX I6EN5/BZHIylT61VCoJtC4Gb069iuKaf7Nkmr0atNoybU+w3AxPHbLj4UMsJSRDIbhO2 naDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=aNvRSdqH5I9uzHn+zWds7ZYzS3cTybnr3t6gdwpzJNM=; b=N/iIaOpOMPsI5hwF/RbJp4XsTSSCrdQl133qZXcD1+FhewazVKWTipo4axnrfH4vQZ iJTDmEXnhFtTJC8iybXjmZg0qsgth+HXaO2cjFW1TStnivfB0MZ82El81aWIUMi2IDlV aeHyjyUlrvLTuNHfuOUfGF7HsAd68guguXBodwPShSyZ29UH9QEDgBbhqj0CXs84uvdG calqU1ujqr/nEsj8i6lGibgnTYqMfY3CYaA1N8QXPWIMeMYY3kjguC4bwd2SRoMeX363 I9E8WBEgXeUv3iy/loe7zqFjtr39kiGpY2qI3MggDqLQSQv349RJbdd5obfYU7tHk/l5 OiXg== X-Gm-Message-State: AKS2vOwO45c+SKZHcMwGYeb4HZqXTjmnsvmHEz+IzEpwtWnaLsUvJKGq Kghx73QOfFdPn3ewUjc= X-Received: by 10.55.162.196 with SMTP id l187mr37216367qke.182.1496795518238; Tue, 06 Jun 2017 17:31:58 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 6 Jun 2017 17:30:35 -0700 Message-Id: <20170607003119.14778-27-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170607003119.14778-1-rth@twiddle.net> References: <20170607003119.14778-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PULL v2 26/70] target/s390x: Use unwind data for helper_stctl X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 10 ++++++---- target/s390x/translate.c | 2 -- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 614cdb2..b64c04e 100644 --- a/target/s390x/mem_helper.c +++ b/target/s390x/mem_helper.c @@ -907,11 +907,12 @@ void HELPER(lctl)(CPUS390XState *env, uint32_t r1, ui= nt64_t a2, uint32_t r3) =20 void HELPER(stctg)(CPUS390XState *env, uint32_t r1, uint64_t a2, uint32_t = r3) { - int i; + uintptr_t ra =3D GETPC(); uint64_t dest =3D a2; + uint32_t i; =20 for (i =3D r1;; i =3D (i + 1) % 16) { - cpu_stq_data(env, dest, env->cregs[i]); + cpu_stq_data_ra(env, dest, env->cregs[i], ra); dest +=3D sizeof(uint64_t); =20 if (i =3D=3D r3) { @@ -922,11 +923,12 @@ void HELPER(stctg)(CPUS390XState *env, uint32_t r1, u= int64_t a2, uint32_t r3) =20 void HELPER(stctl)(CPUS390XState *env, uint32_t r1, uint64_t a2, uint32_t = r3) { - int i; + uintptr_t ra =3D GETPC(); uint64_t dest =3D a2; + uint32_t i; =20 for (i =3D r1;; i =3D (i + 1) % 16) { - cpu_stl_data(env, dest, env->cregs[i]); + cpu_stl_data_ra(env, dest, env->cregs[i], ra); dest +=3D sizeof(uint32_t); =20 if (i =3D=3D r3) { diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 3a98c57..2f15329 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -3617,7 +3617,6 @@ static ExitStatus op_stctg(DisasContext *s, DisasOps = *o) TCGv_i32 r1 =3D tcg_const_i32(get_field(s->fields, r1)); TCGv_i32 r3 =3D tcg_const_i32(get_field(s->fields, r3)); check_privileged(s); - potential_page_fault(s); gen_helper_stctg(cpu_env, r1, o->in2, r3); tcg_temp_free_i32(r1); tcg_temp_free_i32(r3); @@ -3629,7 +3628,6 @@ static ExitStatus op_stctl(DisasContext *s, DisasOps = *o) TCGv_i32 r1 =3D tcg_const_i32(get_field(s->fields, r1)); TCGv_i32 r3 =3D tcg_const_i32(get_field(s->fields, r3)); check_privileged(s); - potential_page_fault(s); gen_helper_stctl(cpu_env, r1, o->in2, r3); tcg_temp_free_i32(r1); tcg_temp_free_i32(r3); --=20 2.9.4