From nobody Wed Nov 5 17:30:40 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1496796084221885.0986285704663; Tue, 6 Jun 2017 17:41:24 -0700 (PDT) Received: from localhost ([::1]:40595 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIP2I-0002nL-O0 for importer@patchew.org; Tue, 06 Jun 2017 20:41:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIOsx-0002VL-T5 for qemu-devel@nongnu.org; Tue, 06 Jun 2017 20:31:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIOsx-0001uU-21 for qemu-devel@nongnu.org; Tue, 06 Jun 2017 20:31:43 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:35615) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dIOsw-0001uI-UG for qemu-devel@nongnu.org; Tue, 06 Jun 2017 20:31:42 -0400 Received: by mail-qk0-x244.google.com with SMTP id u129so438541qka.2 for ; Tue, 06 Jun 2017 17:31:42 -0700 (PDT) Received: from bigtime.twiddle.net.com (71-217-91-69.tukw.qwest.net. [71.217.91.69]) by smtp.gmail.com with ESMTPSA id m47sm29286qtc.36.2017.06.06.17.31.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Jun 2017 17:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=tUBzeTZqy/Lh4/nvvrFH/u/KhnwPtgqFkxEpZuPxlJM=; b=FWbB/o0RfRhoeM2jEy7UNxRFCvFDIPwEs4lhJ0kNyzA5ucPI5DkEIHE1KGvCnwBK6A FsageIHdRjFpdACKy3P+INojMC6eP1tc0YPZNqd0NxQ2rh5ENpBfht4UXWsEJUnrXBrQ 3YrZX4WiKKMYxxH08UAGILMkHLR1oLmbFi/NgRv2s5jZwadDjg/pMzkLbRzvGyCjread 3ajP7R/ze1M1Eooa+RxLPT7ujIh/mHsbr3yNH332nTD9izttY93tR0++Qzrl2AkHbN0g aAYkkGj0DhQRIXmVYe8Wqy1ro3xcqHWuPBKUhkxMMajf41XB2d44x7IGIJowwZHXQoE+ Vefw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=tUBzeTZqy/Lh4/nvvrFH/u/KhnwPtgqFkxEpZuPxlJM=; b=LT5d/6fle+dEBKz8qZh1Fno83pVgsCEkFxhn5EIZDDpR/XdQlXLFzX4HIsg7UYF2JN FwTYVtfZzFxdIHeSp7Hh6xVw41IVdtMiPT9TPm91GrqFNUmXWEZTbR6mSNf2SKU5Ow+M c0baB6yrUHnw8tqkZLDxYWdoSvKdXq0s/cO0lUKDII9rFopSGn2tb6h9Wf/uYiLrovsh EcerDPDUc58F5oeMBdxZTA1wTAz1fzz9k12YaBQpG3k8wowIGBLNbhXPgKWs14Ox72lD j3xL8SshX26j+j7PjZGO6znwN2FHaSFtIa8gDIRXc76xOHoWutys+VtD6X+P66Ke43R0 +Jiw== X-Gm-Message-State: AKS2vOxKYCYUY271CkaGzKCEQBoGa434LLgQGU7P2e6bc9LVW+T8NjLM m66HyJGKiJa9xaupq6Q= X-Received: by 10.55.170.15 with SMTP id t15mr8272935qke.186.1496795502249; Tue, 06 Jun 2017 17:31:42 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 6 Jun 2017 17:30:22 -0700 Message-Id: <20170607003119.14778-14-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170607003119.14778-1-rth@twiddle.net> References: <20170607003119.14778-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PULL v2 13/70] target/s390x: Use unwind data for helper_mvst X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 5 +++-- target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 1c36a47..e4bfc6e 100644 --- a/target/s390x/mem_helper.c +++ b/target/s390x/mem_helper.c @@ -409,6 +409,7 @@ uint32_t HELPER(mvpg)(CPUS390XState *env, uint64_t r0, = uint64_t r1, uint64_t r2) /* string copy (c is string terminator) */ uint64_t HELPER(mvst)(CPUS390XState *env, uint64_t c, uint64_t d, uint64_t= s) { + uintptr_t ra =3D GETPC(); uint32_t len; =20 c =3D c & 0xff; @@ -418,8 +419,8 @@ uint64_t HELPER(mvst)(CPUS390XState *env, uint64_t c, u= int64_t d, uint64_t s) /* Lest we fail to service interrupts in a timely manner, limit the amount of work we're willing to do. For now, let's cap at 8k. */ for (len =3D 0; len < 0x2000; ++len) { - uint8_t v =3D cpu_ldub_data(env, s + len); - cpu_stb_data(env, d + len, v); + uint8_t v =3D cpu_ldub_data_ra(env, s + len, ra); + cpu_stb_data_ra(env, d + len, v, ra); if (v =3D=3D c) { /* Complete. Set CC=3D1 and advance R1. */ env->cc_op =3D 1; diff --git a/target/s390x/translate.c b/target/s390x/translate.c index ae29889..d41a0fd 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -2928,7 +2928,6 @@ static ExitStatus op_mvpg(DisasContext *s, DisasOps *= o) =20 static ExitStatus op_mvst(DisasContext *s, DisasOps *o) { - potential_page_fault(s); gen_helper_mvst(o->in1, cpu_env, regs[0], o->in1, o->in2); set_cc_static(s); return_low128(o->in2); --=20 2.9.4