From nobody Sun Feb 8 20:27:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1496600337310138.46541569223655; Sun, 4 Jun 2017 11:18:57 -0700 (PDT) Received: from localhost ([::1]:58023 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHa75-000632-Lj for importer@patchew.org; Sun, 04 Jun 2017 14:18:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHZSL-0008Tr-1e for qemu-devel@nongnu.org; Sun, 04 Jun 2017 13:36:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHZSK-0004Ip-7T for qemu-devel@nongnu.org; Sun, 04 Jun 2017 13:36:49 -0400 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:34819) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHZSK-0004IB-1L for qemu-devel@nongnu.org; Sun, 04 Jun 2017 13:36:48 -0400 Received: by mail-pg0-x244.google.com with SMTP id f127so7257622pgc.2 for ; Sun, 04 Jun 2017 10:36:47 -0700 (PDT) Received: from bigtime.ASUS (cpe-98-155-27-246.hawaii.res.rr.com. [98.155.27.246]) by smtp.gmail.com with ESMTPSA id j191sm52854419pgc.53.2017.06.04.10.36.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Jun 2017 10:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=VPagw5AzNBorqqgRbANXqMGVyFdurLi02dU5Uela6nE=; b=uh86M7jXGLJLTpGDIZQ51ImRO+ggfB+n0vU7pqF7JoKu0tZZg2Dnr96xiU1GPaSW+c bpTqgqQtXV6YSM8JgXENc4JgiUXjp2EDQVEZw82ziRY2O30Xnz2TLFM5tBJaOd1scxm1 Trg5Xsy/O7de10c/UGr5SUY2WvP04a1jkILbtdrBUFYkSzBpYv06Qm6UpM9CNUBbEPje KoYhJkPKG5Z+gjKBvAMIM9KvPVYLgUZRzvYBh192nKUbsXyzy/CnIwBdpnDdULENdHAe +JR+dDUbiXvWninjynHgY9iIjiq5sgs8L4l6CpuCtUZwDn9T5WqUacj8CwP/i9deQUng Ei4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=VPagw5AzNBorqqgRbANXqMGVyFdurLi02dU5Uela6nE=; b=FljZwNRSYG5WbVuFDGU8LAJEEfefGVJj7C1FcqGEEzlm//ymr/jXLAboeckKBdKbtS KyHRv72tDOdBIDndb9FVC7m+KHKy463GbN2pugakXEqfzSdTkiQsOlOT2ESP48QlOfT5 UGsQMssYC1aj03zsbOVdpKz6CduF4BsWP12pfWbPWvgYCXzN4Wa8nq3fzOu9Xi8BdSlo xU0szeP83qjYApUtrXcaok9Awc6wtOu0E7udIsliyiQKh5GZCjObake4F/Glhi5TnCmg fd84XceH3MumhExbK4bgLb+nXj6dpd+PsN4CiZL1cW/Auw1HjwE0ki6QlqIohg9rwMir m7Wg== X-Gm-Message-State: AODbwcDYt9QFz/DevNp3QqV9SP+I0G5IR977351QiF/oIzfWU4+SX9QF H2lviR7aWi9XqNoqQAk= X-Received: by 10.98.198.72 with SMTP id m69mr16752853pfg.169.1496597806958; Sun, 04 Jun 2017 10:36:46 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sun, 4 Jun 2017 10:35:09 -0700 Message-Id: <20170604173509.29684-70-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170604173509.29684-1-rth@twiddle.net> References: <20170604173509.29684-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::244 Subject: [Qemu-devel] [PULL 69/69] target/s390x: addressing exceptions are suppressing X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, aurelien@aurel32.net, David Hildenbrand Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: David Hildenbrand We have to make the address in the old PSW point at the next instruction, as addressing exceptions are suppressing and not nullifying. I assume that there are a lot of other broken cases (as most instructions we care about are suppressing) - all trigger_pgm_exception() specifying and explicit number or ILEN_LATER look suspicious, however this is another story that might require bigger changes (and I have to understand when the address might already have been incremented first). This is needed to make an upcoming kvm-unit-test work. Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand Message-Id: <20170529121228.2789-1-david@redhat.com> Signed-off-by: Richard Henderson --- target/s390x/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/helper.c b/target/s390x/helper.c index 291db72..a8d20c5 100644 --- a/target/s390x/helper.c +++ b/target/s390x/helper.c @@ -204,7 +204,7 @@ int s390_cpu_handle_mmu_fault(CPUState *cs, vaddr orig_= vaddr, if (raddr > ram_size) { DPRINTF("%s: raddr %" PRIx64 " > ram_size %" PRIx64 "\n", __func__, (uint64_t)raddr, (uint64_t)ram_size); - trigger_pgm_exception(env, PGM_ADDRESSING, ILEN_LATER); + trigger_pgm_exception(env, PGM_ADDRESSING, ILEN_LATER_INC); return 1; } =20 --=20 2.9.4