From nobody Mon Feb 9 03:54:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149659861704724.93869513990171; Sun, 4 Jun 2017 10:50:17 -0700 (PDT) Received: from localhost ([::1]:57889 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHZfL-0004N5-Lo for importer@patchew.org; Sun, 04 Jun 2017 13:50:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHZRN-0007bi-VE for qemu-devel@nongnu.org; Sun, 04 Jun 2017 13:35:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHZRN-0003EZ-4P for qemu-devel@nongnu.org; Sun, 04 Jun 2017 13:35:49 -0400 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:33376) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHZRM-0003EA-VI for qemu-devel@nongnu.org; Sun, 04 Jun 2017 13:35:49 -0400 Received: by mail-pf0-x243.google.com with SMTP id f27so18146148pfe.0 for ; Sun, 04 Jun 2017 10:35:48 -0700 (PDT) Received: from bigtime.ASUS (cpe-98-155-27-246.hawaii.res.rr.com. [98.155.27.246]) by smtp.gmail.com with ESMTPSA id j191sm52854419pgc.53.2017.06.04.10.35.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Jun 2017 10:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=JzHCsnJm/8NSSewI4HZTcmyMKbX5MlkRymiAbDWZr5w=; b=lYCFQEfYSs9i1+s5kDI+YNuK1nM8Tz5AwWVkcPG64M4JAoJIwQhsTCNH1U5HAeOsXQ TwjQvax/uApT1m5lrMkfmtjTr/3DEP260Tf3PDquAZuCgbFBbwNfR3ggPkY2EwHFPevx ZV/3MFIAzRSvqhomRpo3oDpowJm6Lv5gTfSKywc1wMaF9vGhorPTxs3CO2urFgZH2NRC Gw6eVWkGAgNrBDpFN0+BcRgWZWSu0vDQijPvbzGeTZ2oBifP6AlSQlyS/Ij+HZ+VZn1R u+R7WPb8WkfCccQUD5W3LZynWU0UUenWPCpHN6M9NEKxs3DzOOhJBP6Mid1cd+sYL3gH i+Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=JzHCsnJm/8NSSewI4HZTcmyMKbX5MlkRymiAbDWZr5w=; b=YW5+V6zfXdhgBgZxNrU0QoUnAn1PjJCo+r3feOyAdD8KoItA2aKlxJmdbA13figr6C qQTIAt9QHuGL0254DTKPAnDDqA+3zRwkUzvfDajhIg7ZcRYzeYcB3EUbFg0Ui3eecCby BEkwbRrkO5y+UIoWqPRS+EQJ/nRErscEzqN1YD90rqaUbvuyZgkYRbee+pmDAYEdOtUe dCZBF7UhqYgiESeI1p+Cd/qHNL83zC1BzW0eoosiKx/pbTqt6B7cFZvw7d08TUvIhWY7 MMgzE12baIoPLSTLJuyuagLIQnMgkHJjt7sWDkUyCBCJZ/aLmfz86iZ7GK1NaVQFxhLl sEAg== X-Gm-Message-State: AODbwcA6ZSRKW8DdyEsftcKAq6E7z6k99MK8WIbj8uu4fhnDW6tJEWr5 oVt8JybixJkQzI1MdWs= X-Received: by 10.84.130.3 with SMTP id 3mr10619999plc.222.1496597747969; Sun, 04 Jun 2017 10:35:47 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sun, 4 Jun 2017 10:34:26 -0700 Message-Id: <20170604173509.29684-27-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170604173509.29684-1-rth@twiddle.net> References: <20170604173509.29684-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::243 Subject: [Qemu-devel] [PULL 26/69] target/s390x: Use unwind data for helper_stctl X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 10 ++++++---- target/s390x/translate.c | 2 -- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 614cdb2..b64c04e 100644 --- a/target/s390x/mem_helper.c +++ b/target/s390x/mem_helper.c @@ -907,11 +907,12 @@ void HELPER(lctl)(CPUS390XState *env, uint32_t r1, ui= nt64_t a2, uint32_t r3) =20 void HELPER(stctg)(CPUS390XState *env, uint32_t r1, uint64_t a2, uint32_t = r3) { - int i; + uintptr_t ra =3D GETPC(); uint64_t dest =3D a2; + uint32_t i; =20 for (i =3D r1;; i =3D (i + 1) % 16) { - cpu_stq_data(env, dest, env->cregs[i]); + cpu_stq_data_ra(env, dest, env->cregs[i], ra); dest +=3D sizeof(uint64_t); =20 if (i =3D=3D r3) { @@ -922,11 +923,12 @@ void HELPER(stctg)(CPUS390XState *env, uint32_t r1, u= int64_t a2, uint32_t r3) =20 void HELPER(stctl)(CPUS390XState *env, uint32_t r1, uint64_t a2, uint32_t = r3) { - int i; + uintptr_t ra =3D GETPC(); uint64_t dest =3D a2; + uint32_t i; =20 for (i =3D r1;; i =3D (i + 1) % 16) { - cpu_stl_data(env, dest, env->cregs[i]); + cpu_stl_data_ra(env, dest, env->cregs[i], ra); dest +=3D sizeof(uint32_t); =20 if (i =3D=3D r3) { diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 26f6b37..669da89 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -3612,7 +3612,6 @@ static ExitStatus op_stctg(DisasContext *s, DisasOps = *o) TCGv_i32 r1 =3D tcg_const_i32(get_field(s->fields, r1)); TCGv_i32 r3 =3D tcg_const_i32(get_field(s->fields, r3)); check_privileged(s); - potential_page_fault(s); gen_helper_stctg(cpu_env, r1, o->in2, r3); tcg_temp_free_i32(r1); tcg_temp_free_i32(r3); @@ -3624,7 +3623,6 @@ static ExitStatus op_stctl(DisasContext *s, DisasOps = *o) TCGv_i32 r1 =3D tcg_const_i32(get_field(s->fields, r1)); TCGv_i32 r3 =3D tcg_const_i32(get_field(s->fields, r3)); check_privileged(s); - potential_page_fault(s); gen_helper_stctl(cpu_env, r1, o->in2, r3); tcg_temp_free_i32(r1); tcg_temp_free_i32(r3); --=20 2.9.4