From nobody Mon Feb 9 06:06:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1496598003935774.4660070535033; Sun, 4 Jun 2017 10:40:03 -0700 (PDT) Received: from localhost ([::1]:57843 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHZVS-00030S-N8 for importer@patchew.org; Sun, 04 Jun 2017 13:40:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHZRB-0007Q4-Dx for qemu-devel@nongnu.org; Sun, 04 Jun 2017 13:35:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHZR9-0002wr-L1 for qemu-devel@nongnu.org; Sun, 04 Jun 2017 13:35:37 -0400 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:36339) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHZR9-0002vS-EX for qemu-devel@nongnu.org; Sun, 04 Jun 2017 13:35:35 -0400 Received: by mail-pf0-x244.google.com with SMTP id n23so18100683pfb.3 for ; Sun, 04 Jun 2017 10:35:35 -0700 (PDT) Received: from bigtime.ASUS (cpe-98-155-27-246.hawaii.res.rr.com. [98.155.27.246]) by smtp.gmail.com with ESMTPSA id j191sm52854419pgc.53.2017.06.04.10.35.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Jun 2017 10:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=4SGCzzu1Df3GyIWSY/yg6cnmzF1QwVGw36kkzCAFHH4=; b=KlaukucfPhWVODJH08Pr/5BMObWXXxlFE3Yr3mc6AZnaC6suqY7gqu0rh2rrF9Ajh9 Gj5tdeDpWOasCcw1rL/tvEwoL1vni9198k9UgmlbReUr27K2GMmuEQZWQewR6Jz7agLR 92bH6guvPKNEWM7TBmeQouPdEoB3qO4EApBdRPRQzRHL2uYkDmaE/ODsVcdZs46am6MZ 23JcoH18c807Cn5/RCQwT4qtGDwvKT1JQd/Rp4NOF8A3JILQTBpif+KB+18xOUzdnKBK zfv9tl2NMWEepTb7Udc9kxp5w2g+vdWaO43rEYaUHZQ0ezNztesyYkRw9W9KCk1oHTBp c5Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=4SGCzzu1Df3GyIWSY/yg6cnmzF1QwVGw36kkzCAFHH4=; b=PZvspbdEry+3CTU5yFwsSHQ4CuXBnC34BZBFleMPHB7AW3hLaC27kzNRJvEzjIaS8D 2/VC06ihOlc2xAtDy21vHRL9eCv/7Va7/mF9SW1URP8L63ZnzYPK6gKhk5qw20dDlHh8 MP3EIKD9obsmBOHJOa/YCcKjhH2EajpwDxUBTM1TCoelagqNy+6iCixMFDADqQsTMhEW VZ0ZSmkzOmuPH3rryyKckc22U4Zy1LLq6gCH9YZrKvt0WVYlyJGYHhXMZXKsRn7fq0L2 x3jDuT+rNEg969dcVlAYjp5PlA5e5N3ofdrWEh33L4WdAbozVzPL+s2GWrqOcBalPMg8 q49A== X-Gm-Message-State: AODbwcCt/yZ2cTerdtFW6yGr7p4pD2JnEdT0w4jzwYuWx9d/ziwXyub7 akHUgOtHEA1kx1xRxMc= X-Received: by 10.99.64.3 with SMTP id n3mr16415403pga.71.1496597734325; Sun, 04 Jun 2017 10:35:34 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sun, 4 Jun 2017 10:34:16 -0700 Message-Id: <20170604173509.29684-17-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170604173509.29684-1-rth@twiddle.net> References: <20170604173509.29684-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::244 Subject: [Qemu-devel] [PULL 16/69] target/s390x: Use unwind data for helper_mvcl X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 7 ++++--- target/s390x/translate.c | 1 - 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 2acc984..49cfc9b 100644 --- a/target/s390x/mem_helper.c +++ b/target/s390x/mem_helper.c @@ -501,6 +501,7 @@ void HELPER(stam)(CPUS390XState *env, uint32_t r1, uint= 64_t a2, uint32_t r3) /* move long */ uint32_t HELPER(mvcl)(CPUS390XState *env, uint32_t r1, uint32_t r2) { + uintptr_t ra =3D GETPC(); uint64_t destlen =3D env->regs[r1 + 1] & 0xffffff; uint64_t dest =3D get_address_31fix(env, r1); uint64_t srclen =3D env->regs[r2 + 1] & 0xffffff; @@ -522,12 +523,12 @@ uint32_t HELPER(mvcl)(CPUS390XState *env, uint32_t r1= , uint32_t r2) } =20 for (; destlen && srclen; src++, dest++, destlen--, srclen--) { - v =3D cpu_ldub_data(env, src); - cpu_stb_data(env, dest, v); + v =3D cpu_ldub_data_ra(env, src, ra); + cpu_stb_data_ra(env, dest, v, ra); } =20 for (; destlen; dest++, destlen--) { - cpu_stb_data(env, dest, pad); + cpu_stb_data_ra(env, dest, pad, ra); } =20 env->regs[r1 + 1] =3D destlen; diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 7af2a0b..fb2d6ff 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -2871,7 +2871,6 @@ static ExitStatus op_mvcl(DisasContext *s, DisasOps *= o) { TCGv_i32 r1 =3D tcg_const_i32(get_field(s->fields, r1)); TCGv_i32 r2 =3D tcg_const_i32(get_field(s->fields, r2)); - potential_page_fault(s); gen_helper_mvcl(cc_op, cpu_env, r1, r2); tcg_temp_free_i32(r1); tcg_temp_free_i32(r2); --=20 2.9.4