From nobody Wed Nov 5 18:23:08 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1496598897110799.7764542144349; Sun, 4 Jun 2017 10:54:57 -0700 (PDT) Received: from localhost ([::1]:57909 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHZjr-0000j8-J0 for importer@patchew.org; Sun, 04 Jun 2017 13:54:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHZR6-0007Ld-1j for qemu-devel@nongnu.org; Sun, 04 Jun 2017 13:35:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHZR5-0002rI-7e for qemu-devel@nongnu.org; Sun, 04 Jun 2017 13:35:32 -0400 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:36339) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHZR5-0002qJ-2o for qemu-devel@nongnu.org; Sun, 04 Jun 2017 13:35:31 -0400 Received: by mail-pf0-x241.google.com with SMTP id n23so18100591pfb.3 for ; Sun, 04 Jun 2017 10:35:30 -0700 (PDT) Received: from bigtime.ASUS (cpe-98-155-27-246.hawaii.res.rr.com. [98.155.27.246]) by smtp.gmail.com with ESMTPSA id j191sm52854419pgc.53.2017.06.04.10.35.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Jun 2017 10:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=WeybIss4tWOM2Qvr4CQTW7YhsQAO7qo3TjCjwtIirE8=; b=KE1XYIEVA0i/TEGcSxpsNqTYQyQlA6oxB7HsLHw5ag5SaDyzntv4l0lMqguzMy7lmJ oWT1oUyAuQPcTWwKzBsbskkgcXmnUIl40cqdr3TDcMzo90BxllquGdthhzYPotD+0ggL QlICos6NShrou+ghIJcqmZkd5gxbemHAq6TSSJ4nnqTNjpIX4bQ7M3aGUODyeDmQ+awW i9zq49xgFXEltPUY+MtZ2xPQl/GVxIdfFjTsyUrBiVwpx1Fyc7fgfzWslK19XINW8PgK 1sTXuXCYgXWaVrw0a22W9yzaqxDp1W/IDOPfSmqQfi6KxhEvhD71I9lto7nGOZ7XzEGt dzqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=WeybIss4tWOM2Qvr4CQTW7YhsQAO7qo3TjCjwtIirE8=; b=RSjqeHe2Kse9Ja/AZaI51vyjYM4MDYNgcVHqnPWB46qNxhdiPkhptgjfaDjVvC/Reu c1A85/thuiOR95hmLAcaUmK2jpI0H8UqNVdoSRtgplB1kRPWhmI4QFWr7QIqJ7MbSt3+ G5v4glQ5fNyB4dvJBFAmNWaPGaMfs47XP+LPMVO8+uBkbfR2R3xC+E8eE3Uc1CpTaDdC kAUIk3kWrfNEKRIABwjRjfEa2IEUPzl5jr3aj0BMXkalnaaUWrDOyjvwzC/lPIczcmlR GHlGeORVz30LdCftJIWMIjQF8zM/h9c+JKFCfguGl6NFHCCgd/IjprjY8v2pEJKRzd+8 45ag== X-Gm-Message-State: AODbwcASMrlSJWze3IUMNDbbW9ONWYZgz1tuJoRTsXTV5UC14N1Dyge5 onxFueTUhlLdCt6TQL4= X-Received: by 10.84.215.207 with SMTP id g15mr10533370plj.161.1496597730050; Sun, 04 Jun 2017 10:35:30 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sun, 4 Jun 2017 10:34:13 -0700 Message-Id: <20170604173509.29684-14-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170604173509.29684-1-rth@twiddle.net> References: <20170604173509.29684-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::241 Subject: [Qemu-devel] [PULL 13/69] target/s390x: Use unwind data for helper_mvst X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 5 +++-- target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 1c36a47..e4bfc6e 100644 --- a/target/s390x/mem_helper.c +++ b/target/s390x/mem_helper.c @@ -409,6 +409,7 @@ uint32_t HELPER(mvpg)(CPUS390XState *env, uint64_t r0, = uint64_t r1, uint64_t r2) /* string copy (c is string terminator) */ uint64_t HELPER(mvst)(CPUS390XState *env, uint64_t c, uint64_t d, uint64_t= s) { + uintptr_t ra =3D GETPC(); uint32_t len; =20 c =3D c & 0xff; @@ -418,8 +419,8 @@ uint64_t HELPER(mvst)(CPUS390XState *env, uint64_t c, u= int64_t d, uint64_t s) /* Lest we fail to service interrupts in a timely manner, limit the amount of work we're willing to do. For now, let's cap at 8k. */ for (len =3D 0; len < 0x2000; ++len) { - uint8_t v =3D cpu_ldub_data(env, s + len); - cpu_stb_data(env, d + len, v); + uint8_t v =3D cpu_ldub_data_ra(env, s + len, ra); + cpu_stb_data_ra(env, d + len, v, ra); if (v =3D=3D c) { /* Complete. Set CC=3D1 and advance R1. */ env->cc_op =3D 1; diff --git a/target/s390x/translate.c b/target/s390x/translate.c index f55f10a..86e5567 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -2923,7 +2923,6 @@ static ExitStatus op_mvpg(DisasContext *s, DisasOps *= o) =20 static ExitStatus op_mvst(DisasContext *s, DisasOps *o) { - potential_page_fault(s); gen_helper_mvst(o->in1, cpu_env, regs[0], o->in1, o->in2); set_cc_static(s); return_low128(o->in2); --=20 2.9.4