The following changes since commit 43771d5d92312504305c19abe29ec5bfabd55f01:

  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-05-31' into staging (2017-06-01 16:39:16 +0100)

are available in the git repository at:

  github/chrfe chrfe-pull-request

for you to fetch changes up to 6b10e573d15ef82dbc5c5b3726028e6642e134f6:

  char: move char devices to chardev/ (2017-06-02 11:33:53 +0400)

----------------------------------------------------------------

----------------------------------------------------------------

Marc-André Lureau (14):
  char-win: simplify win_chr_read()
  char-win: remove WinChardev.len
  char-win: rename win_chr_init/poll win_chr_serial_init/poll
  char-win: rename hcom->file
  char-win: close file handle except with console
  Remove/replace sysemu/char.h inclusion
  chardev: move headers to include/chardev
  chardev: serial & parallel declaration to own headers
  be-hci: use backend functions
  char: generalize qemu_chr_write_all()
  char: move CharBackend handling in char-fe unit
  char: rename functions that are not part of fe
  char: make chr_fe_deinit() optionaly delete backend
  char: move char devices to chardev/

Philippe Mathieu-Daudé (1):
  char: cast ARRAY_SIZE() as signed to silent warning on empty array

 {chardev => include/chardev}/char-fd.h        |   2 +-
 include/chardev/char-fe.h                     | 251 +++++++++++++
 {chardev => include/chardev}/char-io.h        |   2 +-
 {chardev => include/chardev}/char-mux.h       |   3 +-
 {chardev => include/chardev}/char-parallel.h  |  20 +-
 {chardev => include/chardev}/char-serial.h    |  22 ++
 {chardev => include/chardev}/char-win-stdio.h |   0
 {chardev => include/chardev}/char-win.h       |  14 +-
 include/chardev/char.h                        | 229 ++++++++++++
 include/hw/char/bcm2835_aux.h                 |   2 +-
 include/hw/char/cadence_uart.h                |   2 +-
 include/hw/char/digic-uart.h                  |   2 +-
 include/hw/char/imx_serial.h                  |   2 +-
 include/hw/char/serial.h                      |   4 +-
 include/hw/char/stm32f2xx_usart.h             |   2 +-
 include/sysemu/char.h                         | 499 --------------------------
 backends/rng-egd.c                            |   4 +-
 {backends => chardev}/baum.c                  |   2 +-
 chardev/char-console.c                        |   4 +-
 chardev/char-fd.c                             |   6 +-
 chardev/char-fe.c                             | 361 +++++++++++++++++++
 chardev/char-file.c                           |   8 +-
 chardev/char-io.c                             |   2 +-
 chardev/char-mux.c                            |   6 +-
 chardev/char-null.c                           |   2 +-
 chardev/char-parallel.c                       |   6 +-
 chardev/char-pipe.c                           |  16 +-
 chardev/char-pty.c                            |   4 +-
 chardev/char-ringbuf.c                        |   2 +-
 chardev/char-serial.c                         |   8 +-
 chardev/char-socket.c                         |   4 +-
 chardev/char-stdio.c                          |   8 +-
 chardev/char-udp.c                            |   4 +-
 chardev/char-win-stdio.c                      |   4 +-
 chardev/char-win.c                            |  95 ++---
 chardev/char.c                                | 390 +-------------------
 {backends => chardev}/msmouse.c               |   2 +-
 spice-qemu-char.c => chardev/spice.c          |   4 +-
 {backends => chardev}/testdev.c               |   2 +-
 {backends => chardev}/wctablet.c              |   2 +-
 gdbstub.c                                     |  18 +-
 hmp.c                                         |   2 +-
 hw/arm/bcm2835_peripherals.c                  |   1 -
 hw/arm/fsl-imx25.c                            |   2 +-
 hw/arm/fsl-imx31.c                            |   2 +-
 hw/arm/fsl-imx6.c                             |   2 +-
 hw/arm/omap2.c                                |   2 +-
 hw/arm/pxa2xx.c                               |   2 +-
 hw/arm/strongarm.c                            |   3 +-
 hw/bt/hci-csr.c                               |  11 +-
 hw/char/cadence_uart.c                        |   3 +-
 hw/char/debugcon.c                            |   2 +-
 hw/char/digic-uart.c                          |   2 +-
 hw/char/escc.c                                |   3 +-
 hw/char/etraxfs_ser.c                         |   2 +-
 hw/char/exynos4210_uart.c                     |   3 +-
 hw/char/grlib_apbuart.c                       |   2 +-
 hw/char/imx_serial.c                          |   1 -
 hw/char/ipoctal232.c                          |   2 +-
 hw/char/lm32_juart.c                          |   2 +-
 hw/char/lm32_uart.c                           |   2 +-
 hw/char/mcf_uart.c                            |   2 +-
 hw/char/milkymist-uart.c                      |   2 +-
 hw/char/omap_uart.c                           |   2 +-
 hw/char/parallel.c                            |   3 +-
 hw/char/pl011.c                               |   2 +-
 hw/char/sclpconsole-lm.c                      |   2 +-
 hw/char/sclpconsole.c                         |   2 +-
 hw/char/serial.c                              |   4 +-
 hw/char/sh_serial.c                           |   2 +-
 hw/char/spapr_vty.c                           |   2 +-
 hw/char/terminal3270.c                        |   2 +-
 hw/char/virtio-console.c                      |   2 +-
 hw/char/xen_console.c                         |   4 +-
 hw/char/xilinx_uartlite.c                     |   2 +-
 hw/core/qdev-properties-system.c              |   4 +-
 hw/core/qdev-properties.c                     |   2 +-
 hw/display/xenfb.c                            |   1 -
 hw/i386/xen/xen-hvm.c                         |   1 -
 hw/ipmi/ipmi_bmc_extern.c                     |   2 +-
 hw/isa/pc87312.c                              |   2 +-
 hw/mips/boston.c                              |   2 +-
 hw/mips/mips_fulong2e.c                       |   1 -
 hw/mips/mips_malta.c                          |   1 -
 hw/misc/ivshmem.c                             |   2 +-
 hw/net/xgmac.c                                |   1 -
 hw/ppc/spapr_events.c                         |   1 -
 hw/ppc/spapr_rtas.c                           |   1 -
 hw/sparc/leon3.c                              |   1 -
 hw/usb/ccid-card-emulated.c                   |   2 +-
 hw/usb/ccid-card-passthru.c                   |   7 +-
 hw/usb/dev-serial.c                           |   3 +-
 hw/usb/redirect.c                             |   6 +-
 hw/virtio/vhost-user.c                        |   2 +-
 hw/xen/xen-common.c                           |   2 +-
 hw/xen/xen_backend.c                          |   1 -
 hw/xtensa/xtfpga.c                            |   2 +-
 monitor.c                                     |   4 +-
 net/colo-compare.c                            |  10 +-
 net/filter-mirror.c                           |   8 +-
 net/slirp.c                                   |   2 +-
 net/vhost-user.c                              |   7 +-
 qmp.c                                         |   2 +-
 qtest.c                                       |   2 +-
 replay/replay-char.c                          |   2 +-
 slirp/slirp.c                                 |   2 +-
 tests/postcopy-test.c                         |   2 +-
 tests/test-char.c                             |  24 +-
 tests/vhost-user-test.c                       |   6 +-
 ui/console.c                                  |   2 +-
 ui/gtk.c                                      |   2 +-
 util/event_notifier-posix.c                   |   1 -
 vl.c                                          |   2 +-
 MAINTAINERS                                   |   5 +-
 Makefile.objs                                 |   4 +-
 backends/Makefile.objs                        |   4 -
 backends/trace-events                         |  10 -
 chardev/Makefile.objs                         |   7 +
 chardev/trace-events                          |  18 +
 trace-events                                  |   7 -
 120 files changed, 1126 insertions(+), 1158 deletions(-)
 rename {chardev => include/chardev}/char-fd.h (98%)
 create mode 100644 include/chardev/char-fe.h
 rename {chardev => include/chardev}/char-io.h (98%)
 rename {chardev => include/chardev}/char-mux.h (97%)
 rename {chardev => include/chardev}/char-parallel.h (70%)
 rename {chardev => include/chardev}/char-serial.h (75%)
 rename {chardev => include/chardev}/char-win-stdio.h (100%)
 rename {chardev => include/chardev}/char-win.h (84%)
 create mode 100644 include/chardev/char.h
 delete mode 100644 include/sysemu/char.h
 rename {backends => chardev}/baum.c (99%)
 create mode 100644 chardev/char-fe.c
 rename {backends => chardev}/msmouse.c (99%)
 rename spice-qemu-char.c => chardev/spice.c (99%)
 rename {backends => chardev}/testdev.c (99%)
 rename {backends => chardev}/wctablet.c (99%)
 create mode 100644 chardev/trace-events

-- 
2.13.0.91.g00982b8dd

On 2 June 2017 at 08:40, Marc-André Lureau <marcandre.lureau@redhat.com> wrote:
> The following changes since commit 43771d5d92312504305c19abe29ec5bfabd55f01:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-05-31' into staging (2017-06-01 16:39:16 +0100)
>
> are available in the git repository at:
>
>   github/chrfe chrfe-pull-request

Hi -- this isn't a valid git URL...

thanks
-- PMM

On 06/02/2017 12:36 PM, Peter Maydell wrote:
> On 2 June 2017 at 08:40, Marc-André Lureau <marcandre.lureau@redhat.com> wrote:
>> The following changes since commit 43771d5d92312504305c19abe29ec5bfabd55f01:
>>
>>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-05-31' into staging (2017-06-01 16:39:16 +0100)
>>
>> are available in the git repository at:
>>
>>   github/chrfe chrfe-pull-request
>
> Hi -- this isn't a valid git URL...
>
 >> for you to fetch changes up to 6b10e573d15ef82dbc5c5b3726028e6642e134f6:

The pull request tag is missing however the branch is still available at:
git@github.com/elmarco/qemu.git chrfe

On Fri, Jun 2, 2017 at 7:37 PM Peter Maydell <peter.maydell@linaro.org>
wrote:

> On 2 June 2017 at 08:40, Marc-André Lureau <marcandre.lureau@redhat.com>
> wrote:
> > The following changes since commit
> 43771d5d92312504305c19abe29ec5bfabd55f01:
> >
> >   Merge remote-tracking branch
> 'remotes/armbru/tags/pull-qapi-2017-05-31' into staging (2017-06-01
> 16:39:16 +0100)
> >
> > are available in the git repository at:
> >
> >   github/chrfe chrfe-pull-request
>
> Hi -- this isn't a valid git URL...
>

Sorry, git-publish printed an error on invalid remote, but keep going. I
should fix it. Here is the new pull request:

The following changes since commit 43771d5d92312504305c19abe29ec5bfabd55f01:

  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-05-31'
into staging (2017-06-01 16:39:16 +0100)

are available in the git repository at:

  https://github.com/elmarco/qemu.git tags/chrfe-pull-request

for you to fetch changes up to 6b10e573d15ef82dbc5c5b3726028e6642e134f6:

  char: move char devices to chardev/ (2017-06-02 11:33:53 +0400)

----------------------------------------------------------------

----------------------------------------------------------------

Marc-André Lureau (14):
  char-win: simplify win_chr_read()
  char-win: remove WinChardev.len
  char-win: rename win_chr_init/poll win_chr_serial_init/poll
  char-win: rename hcom->file
  char-win: close file handle except with console
  Remove/replace sysemu/char.h inclusion
  chardev: move headers to include/chardev
  chardev: serial & parallel declaration to own headers
  be-hci: use backend functions
  char: generalize qemu_chr_write_all()
  char: move CharBackend handling in char-fe unit
  char: rename functions that are not part of fe
  char: make chr_fe_deinit() optionaly delete backend
  char: move char devices to chardev/

Philippe Mathieu-Daudé (1):
  char: cast ARRAY_SIZE() as signed to silent warning on empty array

 {chardev => include/chardev}/char-fd.h        |   2 +-
 include/chardev/char-fe.h                     | 251 +++++++++++++
 {chardev => include/chardev}/char-io.h        |   2 +-
 {chardev => include/chardev}/char-mux.h       |   3 +-
 {chardev => include/chardev}/char-parallel.h  |  20 +-
 {chardev => include/chardev}/char-serial.h    |  22 ++
 {chardev => include/chardev}/char-win-stdio.h |   0
 {chardev => include/chardev}/char-win.h       |  14 +-
 include/chardev/char.h                        | 229 ++++++++++++
 include/hw/char/bcm2835_aux.h                 |   2 +-
 include/hw/char/cadence_uart.h                |   2 +-
 include/hw/char/digic-uart.h                  |   2 +-
 include/hw/char/imx_serial.h                  |   2 +-
 include/hw/char/serial.h                      |   4 +-
 include/hw/char/stm32f2xx_usart.h             |   2 +-
 include/sysemu/char.h                         | 499
--------------------------
 backends/rng-egd.c                            |   4 +-
 {backends => chardev}/baum.c                  |   2 +-
 chardev/char-console.c                        |   4 +-
 chardev/char-fd.c                             |   6 +-
 chardev/char-fe.c                             | 361 +++++++++++++++++++
 chardev/char-file.c                           |   8 +-
 chardev/char-io.c                             |   2 +-
 chardev/char-mux.c                            |   6 +-
 chardev/char-null.c                           |   2 +-
 chardev/char-parallel.c                       |   6 +-
 chardev/char-pipe.c                           |  16 +-
 chardev/char-pty.c                            |   4 +-
 chardev/char-ringbuf.c                        |   2 +-
 chardev/char-serial.c                         |   8 +-
 chardev/char-socket.c                         |   4 +-
 chardev/char-stdio.c                          |   8 +-
 chardev/char-udp.c                            |   4 +-
 chardev/char-win-stdio.c                      |   4 +-
 chardev/char-win.c                            |  95 ++---
 chardev/char.c                                | 390 +-------------------
 {backends => chardev}/msmouse.c               |   2 +-
 spice-qemu-char.c => chardev/spice.c          |   4 +-
 {backends => chardev}/testdev.c               |   2 +-
 {backends => chardev}/wctablet.c              |   2 +-
 gdbstub.c                                     |  18 +-
 hmp.c                                         |   2 +-
 hw/arm/bcm2835_peripherals.c                  |   1 -
 hw/arm/fsl-imx25.c                            |   2 +-
 hw/arm/fsl-imx31.c                            |   2 +-
 hw/arm/fsl-imx6.c                             |   2 +-
 hw/arm/omap2.c                                |   2 +-
 hw/arm/pxa2xx.c                               |   2 +-
 hw/arm/strongarm.c                            |   3 +-
 hw/bt/hci-csr.c                               |  11 +-
 hw/char/cadence_uart.c                        |   3 +-
 hw/char/debugcon.c                            |   2 +-
 hw/char/digic-uart.c                          |   2 +-
 hw/char/escc.c                                |   3 +-
 hw/char/etraxfs_ser.c                         |   2 +-
 hw/char/exynos4210_uart.c                     |   3 +-
 hw/char/grlib_apbuart.c                       |   2 +-
 hw/char/imx_serial.c                          |   1 -
 hw/char/ipoctal232.c                          |   2 +-
 hw/char/lm32_juart.c                          |   2 +-
 hw/char/lm32_uart.c                           |   2 +-
 hw/char/mcf_uart.c                            |   2 +-
 hw/char/milkymist-uart.c                      |   2 +-
 hw/char/omap_uart.c                           |   2 +-
 hw/char/parallel.c                            |   3 +-
 hw/char/pl011.c                               |   2 +-
 hw/char/sclpconsole-lm.c                      |   2 +-
 hw/char/sclpconsole.c                         |   2 +-
 hw/char/serial.c                              |   4 +-
 hw/char/sh_serial.c                           |   2 +-
 hw/char/spapr_vty.c                           |   2 +-
 hw/char/terminal3270.c                        |   2 +-
 hw/char/virtio-console.c                      |   2 +-
 hw/char/xen_console.c                         |   4 +-
 hw/char/xilinx_uartlite.c                     |   2 +-
 hw/core/qdev-properties-system.c              |   4 +-
 hw/core/qdev-properties.c                     |   2 +-
 hw/display/xenfb.c                            |   1 -
 hw/i386/xen/xen-hvm.c                         |   1 -
 hw/ipmi/ipmi_bmc_extern.c                     |   2 +-
 hw/isa/pc87312.c                              |   2 +-
 hw/mips/boston.c                              |   2 +-
 hw/mips/mips_fulong2e.c                       |   1 -
 hw/mips/mips_malta.c                          |   1 -
 hw/misc/ivshmem.c                             |   2 +-
 hw/net/xgmac.c                                |   1 -
 hw/ppc/spapr_events.c                         |   1 -
 hw/ppc/spapr_rtas.c                           |   1 -
 hw/sparc/leon3.c                              |   1 -
 hw/usb/ccid-card-emulated.c                   |   2 +-
 hw/usb/ccid-card-passthru.c                   |   7 +-
 hw/usb/dev-serial.c                           |   3 +-
 hw/usb/redirect.c                             |   6 +-
 hw/virtio/vhost-user.c                        |   2 +-
 hw/xen/xen-common.c                           |   2 +-
 hw/xen/xen_backend.c                          |   1 -
 hw/xtensa/xtfpga.c                            |   2 +-
 monitor.c                                     |   4 +-
 net/colo-compare.c                            |  10 +-
 net/filter-mirror.c                           |   8 +-
 net/slirp.c                                   |   2 +-
 net/vhost-user.c                              |   7 +-
 qmp.c                                         |   2 +-
 qtest.c                                       |   2 +-
 replay/replay-char.c                          |   2 +-
 slirp/slirp.c                                 |   2 +-
 tests/postcopy-test.c                         |   2 +-
 tests/test-char.c                             |  24 +-
 tests/vhost-user-test.c                       |   6 +-
 ui/console.c                                  |   2 +-
 ui/gtk.c                                      |   2 +-
 util/event_notifier-posix.c                   |   1 -
 vl.c                                          |   2 +-
 MAINTAINERS                                   |   5 +-
 Makefile.objs                                 |   4 +-
 backends/Makefile.objs                        |   4 -
 backends/trace-events                         |  10 -
 chardev/Makefile.objs                         |   7 +
 chardev/trace-events                          |  18 +
 trace-events                                  |   7 -
 120 files changed, 1126 insertions(+), 1158 deletions(-)
 rename {chardev => include/chardev}/char-fd.h (98%)
 create mode 100644 include/chardev/char-fe.h
 rename {chardev => include/chardev}/char-io.h (98%)
 rename {chardev => include/chardev}/char-mux.h (97%)
 rename {chardev => include/chardev}/char-parallel.h (70%)
 rename {chardev => include/chardev}/char-serial.h (75%)
 rename {chardev => include/chardev}/char-win-stdio.h (100%)
 rename {chardev => include/chardev}/char-win.h (84%)
 create mode 100644 include/chardev/char.h
 delete mode 100644 include/sysemu/char.h
 rename {backends => chardev}/baum.c (99%)
 create mode 100644 chardev/char-fe.c
 rename {backends => chardev}/msmouse.c (99%)
 rename spice-qemu-char.c => chardev/spice.c (99%)
 rename {backends => chardev}/testdev.c (99%)
 rename {backends => chardev}/wctablet.c (99%)
 create mode 100644 chardev/trace-events

-- 
2.13.0.91.g00982b8dd


-- 
Marc-André Lureau

On 2 June 2017 at 20:15, Marc-André Lureau <marcandre.lureau@gmail.com> wrote:
> Sorry, git-publish printed an error on invalid remote, but keep going. I
> should fix it. Here is the new pull request:
>
> The following changes since commit 43771d5d92312504305c19abe29ec5bfabd55f01:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-05-31'
> into staging (2017-06-01 16:39:16 +0100)
>
> are available in the git repository at:
>
>   https://github.com/elmarco/qemu.git tags/chrfe-pull-request
>
>
> for you to fetch changes up to 6b10e573d15ef82dbc5c5b3726028e6642e134f6:
>
>   char: move char devices to chardev/ (2017-06-02 11:33:53 +0400)

Thanks, applied to master.

You forgot to add your signed-off-by line as submaintainer to the
commit from Philippe -- since it's a two line patch I didn't think it
was worth pushing back for a respin, but it's worth adding an
automated "check all commits have my signoff" to your "make a pull
request" script I think.

For example, see lines 98--109 in my script:
https://git.linaro.org/people/peter.maydell/misc-scripts.git/tree/make-pullreq

thanks
-- PMM

Hi

On Mon, Jun 5, 2017 at 2:15 PM Peter Maydell <peter.maydell@linaro.org>
wrote:

> On 2 June 2017 at 20:15, Marc-André Lureau <marcandre.lureau@gmail.com>
> wrote:
> > Sorry, git-publish printed an error on invalid remote, but keep going. I
> > should fix it. Here is the new pull request:
> >
> > The following changes since commit
> 43771d5d92312504305c19abe29ec5bfabd55f01:
> >
> >   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-05-31'
> > into staging (2017-06-01 16:39:16 +0100)
> >
> > are available in the git repository at:
> >
> >   https://github.com/elmarco/qemu.git tags/chrfe-pull-request
> >
> >
> > for you to fetch changes up to 6b10e573d15ef82dbc5c5b3726028e6642e134f6:
> >
> >   char: move char devices to chardev/ (2017-06-02 11:33:53 +0400)
>
> Thanks, applied to master.
>
> You forgot to add your signed-off-by line as submaintainer to the
> commit from Philippe -- since it's a two line patch I didn't think it
>

Oh I didn't know I have to add my sign-off too, I thought reviewed-by was
enough. Ok


> was worth pushing back for a respin, but it's worth adding an
> automated "check all commits have my signoff" to your "make a pull
> request" script I think.
>
> For example, see lines 98--109 in my script:
>
> https://git.linaro.org/people/peter.maydell/misc-scripts.git/tree/make-pullreq


Ok, I am using git-publish (btw, Stefan merged a fix to avoid the previous
pullreq issue), and it seems -s will add missing sign-off during
format-patch.

Thanks,


>
>
> thanks
> -- PMM
>
-- 
Marc-André Lureau

On 5 June 2017 at 11:50, Marc-André Lureau <marcandre.lureau@gmail.com> wrote:
> Hi
>
> On Mon, Jun 5, 2017 at 2:15 PM Peter Maydell <peter.maydell@linaro.org>
> wrote:
>>
>> On 2 June 2017 at 20:15, Marc-André Lureau <marcandre.lureau@gmail.com>
>> wrote:
>> > Sorry, git-publish printed an error on invalid remote, but keep going. I
>> > should fix it. Here is the new pull request:
>> >
>> > The following changes since commit
>> > 43771d5d92312504305c19abe29ec5bfabd55f01:
>> >
>> >   Merge remote-tracking branch
>> > 'remotes/armbru/tags/pull-qapi-2017-05-31'
>> > into staging (2017-06-01 16:39:16 +0100)
>> >
>> > are available in the git repository at:
>> >
>> >   https://github.com/elmarco/qemu.git tags/chrfe-pull-request
>> >
>> >
>> > for you to fetch changes up to 6b10e573d15ef82dbc5c5b3726028e6642e134f6:
>> >
>> >   char: move char devices to chardev/ (2017-06-02 11:33:53 +0400)
>>
>> Thanks, applied to master.
>>
>> You forgot to add your signed-off-by line as submaintainer to the
>> commit from Philippe -- since it's a two line patch I didn't think it
>
>
> Oh I didn't know I have to add my sign-off too, I thought reviewed-by was
> enough. Ok

Yeah, the reviewed-by: says "this code looks good", but the signed-off-by:
says "this code passed through me on its way to master". So you can have
any combination:
 * reviewed-by: only -- you just reviewed the code and it went into
   master via somebody else's tree
 * signed-off-by: only -- you took the code through your tree (so you're
   happy that it's ok license-wise and so on), but you're relying on
   somebody else to have reviewed it
 * both -- you took the code through your tree, and you've done the
   code review

thanks
-- PMM