[Qemu-devel] [PATCH v2 00/45] qobject/qapi: add uint type

Marc-André Lureau posted 45 patches 6 years, 10 months ago
Failed in applying to current master (apply log)
Test checkpatch failed
Test docker passed
Test s390x passed
There is a newer version of this series
include/qapi/visitor.h                             |   8 +-
include/qapi/visitor-impl.h                        |   2 +-
scripts/qapi.py                                    |  47 +++--
scripts/qapi-visit.py                              |  12 +-
include/hw/isa/isa.h                               |   2 +-
include/hw/qdev-core.h                             |   7 +-
include/hw/qdev-properties.h                       |  72 ++++----
include/qapi/qmp/qdict.h                           |  10 +-
include/qapi/qmp/qfloat.h                          |  29 ----
include/qapi/qmp/qint.h                            |  28 ---
include/qapi/qmp/qlist.h                           |   5 +-
include/qapi/qmp/qnum.h                            |  48 ++++++
include/qapi/qmp/qobject.h                         |   7 +
include/qapi/qmp/types.h                           |   3 +-
include/qapi/qobject-input-visitor.h               |   6 +-
include/qapi/qobject-output-visitor.h              |   8 +-
include/qom/object.h                               |  23 +++
qapi/qapi-visit-core.c                             |   6 +-
backends/cryptodev.c                               |   2 +-
block/blkdebug.c                                   |   1 -
block/nbd.c                                        |   1 -
block/nfs.c                                        |   1 -
block/qapi.c                                       |  93 +---------
block/quorum.c                                     |   1 -
block/sheepdog.c                                   |   1 -
block/ssh.c                                        |   1 -
block/vvfat.c                                      |   1 -
blockdev.c                                         |   8 +-
hw/acpi/memory_hotplug.c                           |  12 +-
hw/acpi/nvdimm.c                                   |  18 +-
hw/acpi/pcihp.c                                    |   7 +-
hw/arm/aspeed.c                                    |   8 +-
hw/arm/bcm2835_peripherals.c                       |   9 +-
hw/arm/raspi.c                                     |   4 +-
hw/block/fdc.c                                     |  54 +++---
hw/core/platform-bus.c                             |   2 +-
hw/core/qdev-properties.c                          |  40 ++++-
hw/core/qdev.c                                     |  13 +-
hw/i386/acpi-build.c                               |  95 ++++++----
hw/i386/pc.c                                       |   6 +-
hw/i386/xen/xen-hvm.c                              |   6 +-
hw/intc/apic_common.c                              |  10 +-
hw/intc/arm_gicv3_common.c                         |   2 +-
hw/mem/pc-dimm.c                                   |  23 +--
hw/misc/auxbus.c                                   |   2 +-
hw/misc/pvpanic.c                                  |   2 +-
hw/net/e1000e.c                                    |  14 +-
hw/pci-host/gpex.c                                 |   2 +-
hw/pci-host/piix.c                                 |   8 +-
hw/pci-host/q35.c                                  |  15 +-
hw/pci-host/xilinx-pcie.c                          |   2 +-
hw/ppc/pnv.c                                       |   2 +-
hw/ppc/pnv_core.c                                  |   2 +-
hw/ppc/spapr.c                                     |   7 +-
hw/usb/xen-usb.c                                   |   1 -
monitor.c                                          |   2 +-
net/dump.c                                         |   2 +-
net/filter-buffer.c                                |   2 +-
numa.c                                             |   6 +-
qapi/qapi-clone-visitor.c                          |   2 +-
qapi/qapi-dealloc-visitor.c                        |   2 +-
qapi/qobject-input-visitor.c                       |  57 +++---
qapi/qobject-output-visitor.c                      |   7 +-
qga/commands.c                                     |   2 +-
qga/main.c                                         |   1 -
qobject/json-lexer.c                               |   4 +
qobject/json-parser.c                              |  53 ++++--
qobject/qdict.c                                    | 112 +++++++++---
qobject/qfloat.c                                   |  62 -------
qobject/qint.c                                     |  61 -------
qobject/qjson.c                                    |  37 +---
qobject/qlist.c                                    |  23 +++
qobject/qnum.c                                     | 192 +++++++++++++++++++++
qobject/qobject.c                                  |  22 ++-
qom/object.c                                       |  51 ++++--
target/i386/cpu.c                                  |  10 +-
tests/check-qdict.c                                |  76 ++++++--
tests/check-qfloat.c                               |  53 ------
tests/check-qint.c                                 |  87 ----------
tests/check-qjson.c                                | 147 +++++++++++-----
tests/check-qlist.c                                |  18 +-
tests/check-qnum.c                                 | 166 ++++++++++++++++++
tests/test-clone-visitor.c                         |  23 ++-
tests/test-keyval.c                                |  20 ++-
tests/test-qmp-commands.c                          |   8 +-
tests/test-qmp-event.c                             |   9 +-
tests/test-qobject-input-visitor.c                 | 164 ++++++++++--------
tests/test-qobject-output-visitor.c                |  96 +++++++----
tests/test-x86-cpuid-compat.c                      |  20 ++-
ui/console.c                                       |   4 +-
ui/spice-core.c                                    |   1 -
ui/vnc-enc-tight.c                                 |   1 -
util/keyval.c                                      |  10 +-
util/qemu-option.c                                 |  20 +--
MAINTAINERS                                        |   3 +-
qapi/trace-events                                  |   2 +-
qobject/Makefile.objs                              |   2 +-
scripts/coccinelle/qobject.cocci                   |   4 +-
tests/.gitignore                                   |   3 +-
tests/Makefile.include                             |  15 +-
tests/qapi-schema/alternate-clash.json             |   2 +-
tests/qapi-schema/alternate-conflict-dict.json     |   2 +-
tests/qapi-schema/alternate-conflict-enum-bool.err |   1 +
.../qapi-schema/alternate-conflict-enum-bool.exit  |   1 +
.../qapi-schema/alternate-conflict-enum-bool.json  |   6 +
tests/qapi-schema/alternate-conflict-enum-bool.out |   0
tests/qapi-schema/alternate-conflict-enum-int.err  |   1 +
tests/qapi-schema/alternate-conflict-enum-int.exit |   1 +
tests/qapi-schema/alternate-conflict-enum-int.json |   6 +
tests/qapi-schema/alternate-conflict-enum-int.out  |   0
tests/qapi-schema/alternate-conflict-string.err    |   2 +-
tests/qapi-schema/alternate-conflict-string.json   |   6 +-
tests/qapi-schema/alternate-nested.json            |   2 +-
tests/qapi-schema/args-alternate.json              |   2 +-
tests/qapi-schema/comments.out                     |   2 +-
tests/qapi-schema/doc-bad-alternate-member.json    |   2 +-
tests/qapi-schema/doc-good.out                     |   2 +-
tests/qapi-schema/empty.out                        |   2 +-
tests/qapi-schema/event-case.out                   |   2 +-
tests/qapi-schema/ident-with-escape.out            |   2 +-
tests/qapi-schema/include-relpath.out              |   2 +-
tests/qapi-schema/include-repetition.out           |   2 +-
tests/qapi-schema/include-simple.out               |   2 +-
tests/qapi-schema/indented-expr.out                |   2 +-
tests/qapi-schema/qapi-schema-test.json            |  15 +-
tests/qapi-schema/qapi-schema-test.out             |  32 ++--
tests/qapi-schema/returns-alternate.json           |   2 +-
127 files changed, 1475 insertions(+), 1087 deletions(-)
delete mode 100644 include/qapi/qmp/qfloat.h
delete mode 100644 include/qapi/qmp/qint.h
create mode 100644 include/qapi/qmp/qnum.h
delete mode 100644 qobject/qfloat.c
delete mode 100644 qobject/qint.c
create mode 100644 qobject/qnum.c
delete mode 100644 tests/check-qfloat.c
delete mode 100644 tests/check-qint.c
create mode 100644 tests/check-qnum.c
create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.err
create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.exit
create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.json
create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.out
create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.err
create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.exit
create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.json
create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.out
[Qemu-devel] [PATCH v2 00/45] qobject/qapi: add uint type
Posted by Marc-André Lureau 6 years, 10 months ago
Hi,

In previously sent series "[PATCH 00/21] WIP: dump: add kaslr support
(for after 2.9)", I proposed changes to accept uint64 values from
json, by adding a QUint type. During review, it was suggested to
introduce a QNum type to hold various number representations.

This series introduces the QNum type, adds uint representation to it,
and make uint64 values over json possible (while keeping json negative
int for values >INT64_MAX to unsigned cast compatibility). It also
improves some int vs uint usage for object properties and other
QObject related clean-ups.

The series includes previously sent "qapi: Handle some keyval fallout"
series to help with automated testing.

v2:
- add set_default_value() callback in PropertyInfo
- use Markus version of "remove alt num-int cases"
- add more int/number ranges visitor checks
- replace Error usage for success bool return value in get_int/uint()
- various updated comments, patch and code reorganization
- avoid temporary regression from patch "json: learn to parse uint64
  numbers", drop related patch
- split get_mmcfg_size() fix in a seperate patch
- added "apic-common: make "id" property a uint32" patch
- split the qdev uint proprety patch
- split "Use uint property getter/setter where appropriate" in various
  patches
- add some qdict tests
- dropped s3/s4 bool patch
- add some r-b tags

Marc-André Lureau (40):
  qdev: remove PropertyInfo.qtype field
  object: fix potential leak in getters
  tests: add more int/number ranges checks
  qapi: merge QInt and QFloat in QNum
  qapi: Remove visit_start_alternate() parameter promote_int
  tests: remove /qnum/destroy test
  qnum: add uint type
  json: learn to parse uint64 numbers
  qapi: update the qobject visitor to use QNUM_U64
  object: add uint property setter/getter
  q35: fix get_mmcfg_size to use uint64 visitor
  object: use more specific property type names
  qdev: make default property int
  qdev: add unsigned properties
  apic-common: make "id" property a uint32
  qdev: use appropriate getter/setters type
  isa: use get_uint() for "io-base"
  pc-dimm: use get_uint() for dimm properties
  pc-dimm: make "size" property uint64
  pcihp: use get_uint() for "bsel" property
  aspeed: use {set,get}_uint() for "ram-size" property
  bcm2835_fb: use {get,set}_uint() for "vcram-size" and "vcram-base"
  platform-bus: use get_uint() for "addr" property
  acpi: use get_uint() for "acpi-pcihp-io*" properties
  acpi: use get_uint() for various acpi properties
  acpi: use get_uint() for "pci-hole*" properties
  pc: use get_uint() for "iobase" property
  pc: use get_uint() for "apic-id" property
  pc: use get_uint() for "hpet-intcap" property
  xen: use get_uint() for "max-ram-below-4g" property
  arm: use get_uint() for "mp-affinity" property
  auxbus: use get_uint() for "addr" property
  pvpanic: use get_uint() for "ioport" property
  pnv-core: use get_uint() for "core-pir" property
  numa: use get_uint() for "size" property
  i386/cpu: use get_uint() for "min-level"/"min-xlevel" properties
  console: use get_uint() for "head" property
  tests/qdict: check more get_try_int() cases
  RFC: qdict: add uint
  qobject: move dump_qobject() from block/ to qobject/

Markus Armbruster (5):
  qobject-input-visitor: Reject non-finite numbers with keyval
  qapi: Document visit_type_any() issues with keyval input
  tests/qapi-schema: Avoid 'str' in alternate test cases
  qapi: Reject alternates that can't work with keyval_parse()
  tests: remove alt num-int cases

 include/qapi/visitor.h                             |   8 +-
 include/qapi/visitor-impl.h                        |   2 +-
 scripts/qapi.py                                    |  47 +++--
 scripts/qapi-visit.py                              |  12 +-
 include/hw/isa/isa.h                               |   2 +-
 include/hw/qdev-core.h                             |   7 +-
 include/hw/qdev-properties.h                       |  72 ++++----
 include/qapi/qmp/qdict.h                           |  10 +-
 include/qapi/qmp/qfloat.h                          |  29 ----
 include/qapi/qmp/qint.h                            |  28 ---
 include/qapi/qmp/qlist.h                           |   5 +-
 include/qapi/qmp/qnum.h                            |  48 ++++++
 include/qapi/qmp/qobject.h                         |   7 +
 include/qapi/qmp/types.h                           |   3 +-
 include/qapi/qobject-input-visitor.h               |   6 +-
 include/qapi/qobject-output-visitor.h              |   8 +-
 include/qom/object.h                               |  23 +++
 qapi/qapi-visit-core.c                             |   6 +-
 backends/cryptodev.c                               |   2 +-
 block/blkdebug.c                                   |   1 -
 block/nbd.c                                        |   1 -
 block/nfs.c                                        |   1 -
 block/qapi.c                                       |  93 +---------
 block/quorum.c                                     |   1 -
 block/sheepdog.c                                   |   1 -
 block/ssh.c                                        |   1 -
 block/vvfat.c                                      |   1 -
 blockdev.c                                         |   8 +-
 hw/acpi/memory_hotplug.c                           |  12 +-
 hw/acpi/nvdimm.c                                   |  18 +-
 hw/acpi/pcihp.c                                    |   7 +-
 hw/arm/aspeed.c                                    |   8 +-
 hw/arm/bcm2835_peripherals.c                       |   9 +-
 hw/arm/raspi.c                                     |   4 +-
 hw/block/fdc.c                                     |  54 +++---
 hw/core/platform-bus.c                             |   2 +-
 hw/core/qdev-properties.c                          |  40 ++++-
 hw/core/qdev.c                                     |  13 +-
 hw/i386/acpi-build.c                               |  95 ++++++----
 hw/i386/pc.c                                       |   6 +-
 hw/i386/xen/xen-hvm.c                              |   6 +-
 hw/intc/apic_common.c                              |  10 +-
 hw/intc/arm_gicv3_common.c                         |   2 +-
 hw/mem/pc-dimm.c                                   |  23 +--
 hw/misc/auxbus.c                                   |   2 +-
 hw/misc/pvpanic.c                                  |   2 +-
 hw/net/e1000e.c                                    |  14 +-
 hw/pci-host/gpex.c                                 |   2 +-
 hw/pci-host/piix.c                                 |   8 +-
 hw/pci-host/q35.c                                  |  15 +-
 hw/pci-host/xilinx-pcie.c                          |   2 +-
 hw/ppc/pnv.c                                       |   2 +-
 hw/ppc/pnv_core.c                                  |   2 +-
 hw/ppc/spapr.c                                     |   7 +-
 hw/usb/xen-usb.c                                   |   1 -
 monitor.c                                          |   2 +-
 net/dump.c                                         |   2 +-
 net/filter-buffer.c                                |   2 +-
 numa.c                                             |   6 +-
 qapi/qapi-clone-visitor.c                          |   2 +-
 qapi/qapi-dealloc-visitor.c                        |   2 +-
 qapi/qobject-input-visitor.c                       |  57 +++---
 qapi/qobject-output-visitor.c                      |   7 +-
 qga/commands.c                                     |   2 +-
 qga/main.c                                         |   1 -
 qobject/json-lexer.c                               |   4 +
 qobject/json-parser.c                              |  53 ++++--
 qobject/qdict.c                                    | 112 +++++++++---
 qobject/qfloat.c                                   |  62 -------
 qobject/qint.c                                     |  61 -------
 qobject/qjson.c                                    |  37 +---
 qobject/qlist.c                                    |  23 +++
 qobject/qnum.c                                     | 192 +++++++++++++++++++++
 qobject/qobject.c                                  |  22 ++-
 qom/object.c                                       |  51 ++++--
 target/i386/cpu.c                                  |  10 +-
 tests/check-qdict.c                                |  76 ++++++--
 tests/check-qfloat.c                               |  53 ------
 tests/check-qint.c                                 |  87 ----------
 tests/check-qjson.c                                | 147 +++++++++++-----
 tests/check-qlist.c                                |  18 +-
 tests/check-qnum.c                                 | 166 ++++++++++++++++++
 tests/test-clone-visitor.c                         |  23 ++-
 tests/test-keyval.c                                |  20 ++-
 tests/test-qmp-commands.c                          |   8 +-
 tests/test-qmp-event.c                             |   9 +-
 tests/test-qobject-input-visitor.c                 | 164 ++++++++++--------
 tests/test-qobject-output-visitor.c                |  96 +++++++----
 tests/test-x86-cpuid-compat.c                      |  20 ++-
 ui/console.c                                       |   4 +-
 ui/spice-core.c                                    |   1 -
 ui/vnc-enc-tight.c                                 |   1 -
 util/keyval.c                                      |  10 +-
 util/qemu-option.c                                 |  20 +--
 MAINTAINERS                                        |   3 +-
 qapi/trace-events                                  |   2 +-
 qobject/Makefile.objs                              |   2 +-
 scripts/coccinelle/qobject.cocci                   |   4 +-
 tests/.gitignore                                   |   3 +-
 tests/Makefile.include                             |  15 +-
 tests/qapi-schema/alternate-clash.json             |   2 +-
 tests/qapi-schema/alternate-conflict-dict.json     |   2 +-
 tests/qapi-schema/alternate-conflict-enum-bool.err |   1 +
 .../qapi-schema/alternate-conflict-enum-bool.exit  |   1 +
 .../qapi-schema/alternate-conflict-enum-bool.json  |   6 +
 tests/qapi-schema/alternate-conflict-enum-bool.out |   0
 tests/qapi-schema/alternate-conflict-enum-int.err  |   1 +
 tests/qapi-schema/alternate-conflict-enum-int.exit |   1 +
 tests/qapi-schema/alternate-conflict-enum-int.json |   6 +
 tests/qapi-schema/alternate-conflict-enum-int.out  |   0
 tests/qapi-schema/alternate-conflict-string.err    |   2 +-
 tests/qapi-schema/alternate-conflict-string.json   |   6 +-
 tests/qapi-schema/alternate-nested.json            |   2 +-
 tests/qapi-schema/args-alternate.json              |   2 +-
 tests/qapi-schema/comments.out                     |   2 +-
 tests/qapi-schema/doc-bad-alternate-member.json    |   2 +-
 tests/qapi-schema/doc-good.out                     |   2 +-
 tests/qapi-schema/empty.out                        |   2 +-
 tests/qapi-schema/event-case.out                   |   2 +-
 tests/qapi-schema/ident-with-escape.out            |   2 +-
 tests/qapi-schema/include-relpath.out              |   2 +-
 tests/qapi-schema/include-repetition.out           |   2 +-
 tests/qapi-schema/include-simple.out               |   2 +-
 tests/qapi-schema/indented-expr.out                |   2 +-
 tests/qapi-schema/qapi-schema-test.json            |  15 +-
 tests/qapi-schema/qapi-schema-test.out             |  32 ++--
 tests/qapi-schema/returns-alternate.json           |   2 +-
 127 files changed, 1475 insertions(+), 1087 deletions(-)
 delete mode 100644 include/qapi/qmp/qfloat.h
 delete mode 100644 include/qapi/qmp/qint.h
 create mode 100644 include/qapi/qmp/qnum.h
 delete mode 100644 qobject/qfloat.c
 delete mode 100644 qobject/qint.c
 create mode 100644 qobject/qnum.c
 delete mode 100644 tests/check-qfloat.c
 delete mode 100644 tests/check-qint.c
 create mode 100644 tests/check-qnum.c
 create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.err
 create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.exit
 create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.json
 create mode 100644 tests/qapi-schema/alternate-conflict-enum-bool.out
 create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.err
 create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.exit
 create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.json
 create mode 100644 tests/qapi-schema/alternate-conflict-enum-int.out

-- 
2.13.0.91.g00982b8dd


Re: [Qemu-devel] [PATCH v2 00/45] qobject/qapi: add uint type
Posted by no-reply@patchew.org 6 years, 10 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20170531135709.345-1-marcandre.lureau@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH v2 00/45] qobject/qapi: add uint type

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/1496152683-102751-1-git-send-email-anton.nefedov@virtuozzo.com -> patchew/1496152683-102751-1-git-send-email-anton.nefedov@virtuozzo.com
 * [new tag]         patchew/20170531192836.7187-1-jsnow@redhat.com -> patchew/20170531192836.7187-1-jsnow@redhat.com
 * [new tag]         patchew/20170531193434.6918-1-david@redhat.com -> patchew/20170531193434.6918-1-david@redhat.com
Switched to a new branch 'test'
44ac08a qobject: move dump_qobject() from block/ to qobject/
4f36884 RFC: qdict: add uint
ef45589 tests/qdict: check more get_try_int() cases
a9c6698 console: use get_uint() for "head" property
d4c67e9 i386/cpu: use get_uint() for "min-level"/"min-xlevel" properties
10de204 numa: use get_uint() for "size" property
7f367eb pnv-core: use get_uint() for "core-pir" property
6279c33 pvpanic: use get_uint() for "ioport" property
6f0b197 auxbus: use get_uint() for "addr" property
3268fdb arm: use get_uint() for "mp-affinity" property
508afeb xen: use get_uint() for "max-ram-below-4g" property
b3a2677 pc: use get_uint() for "hpet-intcap" property
53fff2c pc: use get_uint() for "apic-id" property
86f858d pc: use get_uint() for "iobase" property
7281251 acpi: use get_uint() for "pci-hole*" properties
cdae6bd acpi: use get_uint() for various acpi properties
2c1168c acpi: use get_uint() for "acpi-pcihp-io*" properties
db85018 platform-bus: use get_uint() for "addr" property
83701a9 bcm2835_fb: use {get, set}_uint() for "vcram-size" and "vcram-base"
3636325 aspeed: use {set, get}_uint() for "ram-size" property
d45270e pcihp: use get_uint() for "bsel" property
a9e4942 pc-dimm: make "size" property uint64
72501db pc-dimm: use get_uint() for dimm properties
7bcc518 isa: use get_uint() for "io-base"
617b690 qdev: use appropriate getter/setters type
67ef86a apic-common: make "id" property a uint32
46b7af7 qdev: add unsigned properties
f5b425c qdev: make default property int
6ef348c object: use more specific property type names
f505764 q35: fix get_mmcfg_size to use uint64 visitor
cae2768 object: add uint property setter/getter
6981ce5 qapi: update the qobject visitor to use QNUM_U64
ee2fc88 json: learn to parse uint64 numbers
08280db qnum: add uint type
9d558cd tests: remove /qnum/destroy test
cbdb7b5 qapi: Remove visit_start_alternate() parameter promote_int
eaa6ee5 qapi: merge QInt and QFloat in QNum
8f5c108 tests: add more int/number ranges checks
29d8de7 tests: remove alt num-int cases
b2ad700 object: fix potential leak in getters
94718f3 qdev: remove PropertyInfo.qtype field
edf34ae qapi: Reject alternates that can't work with keyval_parse()
bc54967 tests/qapi-schema: Avoid 'str' in alternate test cases
1ac82cc qapi: Document visit_type_any() issues with keyval input
b117faf qobject-input-visitor: Reject non-finite numbers with keyval

=== OUTPUT BEGIN ===
Checking PATCH 1/45: qobject-input-visitor: Reject non-finite numbers with keyval...
Checking PATCH 2/45: qapi: Document visit_type_any() issues with keyval input...
Checking PATCH 3/45: tests/qapi-schema: Avoid 'str' in alternate test cases...
Checking PATCH 4/45: qapi: Reject alternates that can't work with keyval_parse()...
Checking PATCH 5/45: qdev: remove PropertyInfo.qtype field...
Checking PATCH 6/45: object: fix potential leak in getters...
Checking PATCH 7/45: tests: remove alt num-int cases...
Checking PATCH 8/45: tests: add more int/number ranges checks...
Checking PATCH 9/45: qapi: merge QInt and QFloat in QNum...
ERROR: do not use C99 // comments
#2002: FILE: tests/check-qnum.c:35:
+    // destroy doesn't exit yet

ERROR: do not use C99 // comments
#2017: FILE: tests/check-qnum.c:50:
+    // destroy doesn't exit yet

total: 2 errors, 0 warnings, 1918 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/45: qapi: Remove visit_start_alternate() parameter promote_int...
Checking PATCH 11/45: tests: remove /qnum/destroy test...
Checking PATCH 12/45: qnum: add uint type...
Checking PATCH 13/45: json: learn to parse uint64 numbers...
Checking PATCH 14/45: qapi: update the qobject visitor to use QNUM_U64...
Checking PATCH 15/45: object: add uint property setter/getter...
Checking PATCH 16/45: q35: fix get_mmcfg_size to use uint64 visitor...
Checking PATCH 17/45: object: use more specific property type names...
Checking PATCH 18/45: qdev: make default property int...
Checking PATCH 19/45: qdev: add unsigned properties...
Checking PATCH 20/45: apic-common: make "id" property a uint32...
Checking PATCH 21/45: qdev: use appropriate getter/setters type...
Checking PATCH 22/45: isa: use get_uint() for "io-base"...
Checking PATCH 23/45: pc-dimm: use get_uint() for dimm properties...
Checking PATCH 24/45: pc-dimm: make "size" property uint64...
Checking PATCH 25/45: pcihp: use get_uint() for "bsel" property...
Checking PATCH 26/45: aspeed: use {set, get}_uint() for "ram-size" property...
Checking PATCH 27/45: bcm2835_fb: use {get, set}_uint() for "vcram-size" and "vcram-base"...
Checking PATCH 28/45: platform-bus: use get_uint() for "addr" property...
Checking PATCH 29/45: acpi: use get_uint() for "acpi-pcihp-io*" properties...
Checking PATCH 30/45: acpi: use get_uint() for various acpi properties...
Checking PATCH 31/45: acpi: use get_uint() for "pci-hole*" properties...
Checking PATCH 32/45: pc: use get_uint() for "iobase" property...
Checking PATCH 33/45: pc: use get_uint() for "apic-id" property...
Checking PATCH 34/45: pc: use get_uint() for "hpet-intcap" property...
Checking PATCH 35/45: xen: use get_uint() for "max-ram-below-4g" property...
Checking PATCH 36/45: arm: use get_uint() for "mp-affinity" property...
Checking PATCH 37/45: auxbus: use get_uint() for "addr" property...
Checking PATCH 38/45: pvpanic: use get_uint() for "ioport" property...
Checking PATCH 39/45: pnv-core: use get_uint() for "core-pir" property...
Checking PATCH 40/45: numa: use get_uint() for "size" property...
Checking PATCH 41/45: i386/cpu: use get_uint() for "min-level"/"min-xlevel" properties...
Checking PATCH 42/45: console: use get_uint() for "head" property...
Checking PATCH 43/45: tests/qdict: check more get_try_int() cases...
Checking PATCH 44/45: RFC: qdict: add uint...
Checking PATCH 45/45: qobject: move dump_qobject() from block/ to qobject/...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PATCH v2 00/45] qobject/qapi: add uint type
Posted by Markus Armbruster 6 years, 9 months ago
Marc-André Lureau <marcandre.lureau@redhat.com> writes:

> Hi,
>
> In previously sent series "[PATCH 00/21] WIP: dump: add kaslr support
> (for after 2.9)", I proposed changes to accept uint64 values from
> json, by adding a QUint type. During review, it was suggested to
> introduce a QNum type to hold various number representations.
>
> This series introduces the QNum type, adds uint representation to it,
> and make uint64 values over json possible (while keeping json negative
> int for values >INT64_MAX to unsigned cast compatibility). It also
> improves some int vs uint usage for object properties and other
> QObject related clean-ups.
>
> The series includes previously sent "qapi: Handle some keyval fallout"
> series to help with automated testing.

PATCH 09 hasn't quite converged, but the rest looks pretty close now.
I hope we can wrap this up without trouble :)