From nobody Mon Feb 9 20:35:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1495730702212670.3273034505861; Thu, 25 May 2017 09:45:02 -0700 (PDT) Received: from localhost ([::1]:60966 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDvsf-0000Uh-Sd for importer@patchew.org; Thu, 25 May 2017 12:44:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDvh7-00052i-2C for qemu-devel@nongnu.org; Thu, 25 May 2017 12:33:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDvh6-0004DK-1a for qemu-devel@nongnu.org; Thu, 25 May 2017 12:33:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39672) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dDvh3-00048A-IA; Thu, 25 May 2017 12:32:57 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8124F8E3C6; Thu, 25 May 2017 16:32:56 +0000 (UTC) Received: from donizetti.redhat.com (ovpn-117-34.ams2.redhat.com [10.36.117.34]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v4PGWQ5O001654; Thu, 25 May 2017 12:32:55 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8124F8E3C6 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=pbonzini@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8124F8E3C6 From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 25 May 2017 18:32:25 +0200 Message-Id: <20170525163225.29954-19-pbonzini@redhat.com> In-Reply-To: <20170525163225.29954-1-pbonzini@redhat.com> References: <20170525163225.29954-1-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 25 May 2017 16:32:56 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 18/18] block: make accounting thread-safe X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: famz@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" I'm not trying too hard yet. Later, with multiqueue support, this may cause mutex contention or cacheline bouncing. Reviewed-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- block/accounting.c | 16 ++++++++++++++++ include/block/accounting.h | 8 ++++++-- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/block/accounting.c b/block/accounting.c index a279e0b..72bcb0d 100644 --- a/block/accounting.c +++ b/block/accounting.c @@ -35,6 +35,7 @@ static const int qtest_latency_ns =3D NANOSECONDS_PER_SEC= OND / 1000; void block_acct_init(BlockAcctStats *stats, bool account_invalid, bool account_failed) { + qemu_mutex_init(&stats->lock); stats->account_invalid =3D account_invalid; stats->account_failed =3D account_failed; =20 @@ -49,6 +50,7 @@ void block_acct_cleanup(BlockAcctStats *stats) QSLIST_FOREACH_SAFE(s, &stats->intervals, entries, next) { g_free(s); } + qemu_mutex_destroy(&stats->lock); } =20 void block_acct_add_interval(BlockAcctStats *stats, unsigned interval_leng= th) @@ -58,12 +60,15 @@ void block_acct_add_interval(BlockAcctStats *stats, uns= igned interval_length) =20 s =3D g_new0(BlockAcctTimedStats, 1); s->interval_length =3D interval_length; + s->stats =3D stats; + qemu_mutex_lock(&stats->lock); QSLIST_INSERT_HEAD(&stats->intervals, s, entries); =20 for (i =3D 0; i < BLOCK_MAX_IOTYPE; i++) { timed_average_init(&s->latency[i], clock_type, (uint64_t) interval_length * NANOSECONDS_PER_SE= COND); } + qemu_mutex_unlock(&stats->lock); } =20 BlockAcctTimedStats *block_acct_interval_next(BlockAcctStats *stats, @@ -99,6 +104,8 @@ static void block_account_one_io(BlockAcctStats *stats, = BlockAcctCookie *cookie, =20 assert(cookie->type < BLOCK_MAX_IOTYPE); =20 + qemu_mutex_lock(&stats->lock); + if (failed) { stats->failed_ops[cookie->type]++; } else { @@ -114,6 +121,8 @@ static void block_account_one_io(BlockAcctStats *stats,= BlockAcctCookie *cookie, timed_average_account(&s->latency[cookie->type], latency_ns); } } + + qemu_mutex_unlock(&stats->lock); } =20 void block_acct_done(BlockAcctStats *stats, BlockAcctCookie *cookie) @@ -134,18 +143,23 @@ void block_acct_invalid(BlockAcctStats *stats, enum B= lockAcctType type) * not. The reason is that invalid requests are accounted during their * submission, therefore there's no actual I/O involved. */ + qemu_mutex_lock(&stats->lock); stats->invalid_ops[type]++; =20 if (stats->account_invalid) { stats->last_access_time_ns =3D qemu_clock_get_ns(clock_type); } + qemu_mutex_unlock(&stats->lock); } =20 void block_acct_merge_done(BlockAcctStats *stats, enum BlockAcctType type, int num_requests) { assert(type < BLOCK_MAX_IOTYPE); + + qemu_mutex_lock(&stats->lock); stats->merged[type] +=3D num_requests; + qemu_mutex_unlock(&stats->lock); } =20 int64_t block_acct_idle_time_ns(BlockAcctStats *stats) @@ -160,7 +174,9 @@ double block_acct_queue_depth(BlockAcctTimedStats *stat= s, =20 assert(type < BLOCK_MAX_IOTYPE); =20 + qemu_mutex_lock(&stats->stats->lock); sum =3D timed_average_sum(&stats->latency[type], &elapsed); + qemu_mutex_unlock(&stats->stats->lock); =20 return (double) sum / elapsed; } diff --git a/include/block/accounting.h b/include/block/accounting.h index 2089163..eb69091 100644 --- a/include/block/accounting.h +++ b/include/block/accounting.h @@ -26,8 +26,10 @@ #define BLOCK_ACCOUNTING_H =20 #include "qemu/timed-average.h" +#include "qemu/thread.h" =20 typedef struct BlockAcctTimedStats BlockAcctTimedStats; +typedef struct BlockAcctStats BlockAcctStats; =20 enum BlockAcctType { BLOCK_ACCT_READ, @@ -37,12 +39,14 @@ enum BlockAcctType { }; =20 struct BlockAcctTimedStats { + BlockAcctStats *stats; TimedAverage latency[BLOCK_MAX_IOTYPE]; unsigned interval_length; /* in seconds */ QSLIST_ENTRY(BlockAcctTimedStats) entries; }; =20 -typedef struct BlockAcctStats { +struct BlockAcctStats { + QemuMutex lock; uint64_t nr_bytes[BLOCK_MAX_IOTYPE]; uint64_t nr_ops[BLOCK_MAX_IOTYPE]; uint64_t invalid_ops[BLOCK_MAX_IOTYPE]; @@ -53,7 +57,7 @@ typedef struct BlockAcctStats { QSLIST_HEAD(, BlockAcctTimedStats) intervals; bool account_invalid; bool account_failed; -} BlockAcctStats; +}; =20 typedef struct BlockAcctCookie { int64_t bytes; --=20 1.8.3.1