From nobody Mon Feb 9 03:12:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1495654331217142.92173753070824; Wed, 24 May 2017 12:32:11 -0700 (PDT) Received: from localhost ([::1]:56488 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDc0v-0001a3-OS for importer@patchew.org; Wed, 24 May 2017 15:32:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDbs6-0001fx-4b for qemu-devel@nongnu.org; Wed, 24 May 2017 15:23:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDbs4-0000uh-S9 for qemu-devel@nongnu.org; Wed, 24 May 2017 15:23:02 -0400 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:33817) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dDbs4-0000ud-Nd for qemu-devel@nongnu.org; Wed, 24 May 2017 15:23:00 -0400 Received: by mail-qk0-x243.google.com with SMTP id u75so27644832qka.1 for ; Wed, 24 May 2017 12:23:00 -0700 (PDT) Received: from bigtime.twiddle.net.com ([2602:47:d954:1500:5e51:4fff:fe40:9c64]) by smtp.gmail.com with ESMTPSA id b23sm3296240qkb.31.2017.05.24.12.22.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 May 2017 12:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=ahfHbShvbRxkLrUNimGW877OGdC8iID2PC42gDnoROk=; b=ekYBmYT7R9gjzQ9CoMpUn4R+vwbck1PejU/BFwQhqt9swOYM+lwEI3iOgB6LFhCD1N iBhZsgurE1IyvHIeYqUsdYP1HQtjRSWHYa5ytSZunXI5/kGao1VkMaPmBsm2YO3ddITX YgSo1JAexedxgQoSM97VEzn93eD7CCdFUAdTm+5z6NKig2CfcaVaHRwXtNbY/Zr77ZG2 17dIAIoSIG52nhEBpSjD5+rib7vhczBWndc2s7Se/TuHI7FYItlTOBaHuCNFEOIBshVN ZZoUyw3XLu8GluI8+qTk1DrxFjsyV8N2doNVwRHBapHEpcJlukRW9falmH1K5uWJ/IgV D42g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=ahfHbShvbRxkLrUNimGW877OGdC8iID2PC42gDnoROk=; b=n/njXgqMWGOLpm5Lp+/4SHHJHyS48Usn9JLDjOTHaEH1fXGjCzb0yxlj5ZtR7fc422 DFbj4tpfln+GWmMRw1X7aN+boWZ7nMqlauAHRYitkiUZUW1mK6fnUeOO1B7YTCn61mY3 c0Doh0MHNKakxPfb42r9QGwEbGBK4B618B8QjP4+AiRYKuUKBMXcOTbFlGkcUJ5m8B0j cyEiPyJUgzC7j345ovONYwLTVPVnAW6sl/iFp7uAWzGkbZAUuViKyO+kxdLoU/mr+sYP ebC/HO2J90b1ZX5KY/YqfXFphDDmh8XLcY5BHEx8PhnRpFM2Y20ZtloEw9zZaarVrHSk 948Q== X-Gm-Message-State: AODbwcBKAeovRDSsOLZ/vje1zg6AxLwhnKgsaUZmJVyoKPlBj6cSEdU+ C5FeD7cQ/DJV6w== X-Received: by 10.55.18.141 with SMTP id 13mr36557967qks.135.1495653780233; Wed, 24 May 2017 12:23:00 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 24 May 2017 12:22:19 -0700 Message-Id: <20170524192246.15905-7-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170524192246.15905-1-rth@twiddle.net> References: <20170524192246.15905-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::243 Subject: [Qemu-devel] [PATCH v2 06/33] target/s390x: Use unwind data for helper_mvc X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Aurelien Jarno --- target/s390x/mem_helper.c | 30 ++++++++++++++++++------------ target/s390x/translate.c | 1 - 2 files changed, 18 insertions(+), 13 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index b71437a..78a9ac1 100644 --- a/target/s390x/mem_helper.c +++ b/target/s390x/mem_helper.c @@ -91,7 +91,7 @@ static void fast_memset(CPUS390XState *env, uint64_t dest= , uint8_t byte, } =20 static void fast_memmove(CPUS390XState *env, uint64_t dest, uint64_t src, - uint32_t l) + uint32_t l, uintptr_t ra) { int mmu_idx =3D cpu_mmu_index(env, false); =20 @@ -110,7 +110,7 @@ static void fast_memmove(CPUS390XState *env, uint64_t d= est, uint64_t src, /* We failed to get access to one or both whole pages. The next read or write access will likely fill the QEMU TLB for the next iteration. */ - cpu_stb_data(env, dest, cpu_ldub_data(env, src)); + cpu_stb_data_ra(env, dest, cpu_ldub_data_ra(env, src, ra), ra); src++; dest++; l--; @@ -200,32 +200,38 @@ uint32_t HELPER(oc)(CPUS390XState *env, uint32_t l, u= int64_t dest, } =20 /* memmove */ -void HELPER(mvc)(CPUS390XState *env, uint32_t l, uint64_t dest, uint64_t s= rc) +static void do_helper_mvc(CPUS390XState *env, uint32_t l, uint64_t dest, + uint64_t src, uintptr_t ra) { - int i =3D 0; + uint32_t i; =20 HELPER_LOG("%s l %d dest %" PRIx64 " src %" PRIx64 "\n", __func__, l, dest, src); =20 /* mvc with source pointing to the byte after the destination is the same as memset with the first source byte */ - if (dest =3D=3D (src + 1)) { - fast_memset(env, dest, cpu_ldub_data(env, src), l + 1, 0); + if (dest =3D=3D src + 1) { + fast_memset(env, dest, cpu_ldub_data_ra(env, src, ra), l + 1, ra); return; } =20 /* mvc and memmove do not behave the same when areas overlap! */ - if ((dest < src) || (src + l < dest)) { - fast_memmove(env, dest, src, l + 1); + if (dest < src || src + l < dest) { + fast_memmove(env, dest, src, l + 1, ra); return; } =20 /* slow version with byte accesses which always work */ for (i =3D 0; i <=3D l; i++) { - cpu_stb_data(env, dest + i, cpu_ldub_data(env, src + i)); + cpu_stb_data_ra(env, dest + i, cpu_ldub_data_ra(env, src + i, ra),= ra); } } =20 +void HELPER(mvc)(CPUS390XState *env, uint32_t l, uint64_t dest, uint64_t s= rc) +{ + do_helper_mvc(env, l, dest, src, GETPC()); +} + /* compare unsigned byte arrays */ uint32_t HELPER(clc)(CPUS390XState *env, uint32_t l, uint64_t s1, uint64_t= s2) { @@ -388,7 +394,7 @@ void HELPER(mvpg)(CPUS390XState *env, uint64_t r0, uint= 64_t r1, uint64_t r2) { /* XXX missing r0 handling */ env->cc_op =3D 0; - fast_memmove(env, r1, r2, TARGET_PAGE_SIZE); + fast_memmove(env, r1, r2, TARGET_PAGE_SIZE, 0); } =20 /* string copy (c is string terminator) */ @@ -1223,8 +1229,8 @@ uint32_t HELPER(ex)(CPUS390XState *env, uint32_t cc, = uint64_t v1, d2 =3D insn2 & 0xfff; switch (insn & 0xf00) { case 0x200: - helper_mvc(env, l, get_address(env, 0, b1, d1), - get_address(env, 0, b2, d2)); + do_helper_mvc(env, l, get_address(env, 0, b1, d1), + get_address(env, 0, b2, d2), 0); break; case 0x400: cc =3D do_helper_nc(env, l, get_address(env, 0, b1, d1), diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 40a4099..729924a 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -2866,7 +2866,6 @@ static ExitStatus op_movx(DisasContext *s, DisasOps *= o) static ExitStatus op_mvc(DisasContext *s, DisasOps *o) { TCGv_i32 l =3D tcg_const_i32(get_field(s->fields, l1)); - potential_page_fault(s); gen_helper_mvc(cpu_env, l, o->addr1, o->in2); tcg_temp_free_i32(l); return NO_EXIT; --=20 2.9.4