From nobody Mon Feb 9 04:46:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1495654253054710.6066156746642; Wed, 24 May 2017 12:30:53 -0700 (PDT) Received: from localhost ([::1]:56483 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDbzf-0000ZH-It for importer@patchew.org; Wed, 24 May 2017 15:30:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDbsM-0001xM-Ah for qemu-devel@nongnu.org; Wed, 24 May 2017 15:23:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDbsL-0001LS-AA for qemu-devel@nongnu.org; Wed, 24 May 2017 15:23:18 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:33839) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dDbsL-0001Kk-6d for qemu-devel@nongnu.org; Wed, 24 May 2017 15:23:17 -0400 Received: by mail-qk0-x244.google.com with SMTP id u75so27645734qka.1 for ; Wed, 24 May 2017 12:23:17 -0700 (PDT) Received: from bigtime.twiddle.net.com ([2602:47:d954:1500:5e51:4fff:fe40:9c64]) by smtp.gmail.com with ESMTPSA id b23sm3296240qkb.31.2017.05.24.12.23.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 May 2017 12:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=eTzekCYHqAkrjY8gv7bsRN3sPl4ig5ZZ5RSPrbUBMmg=; b=SPTknUB+TEwfXAlgdSKXhXLky3ztoQfOm1bNQwZgn3+rzGrB3u7En5SpqJL7DlWlb6 MjjEUQJgVTMsrybQ0xA3SG9ny1FCjS3maQUdv+vNVl2u7FC+XHX8m8wzLK2eZLWivIF9 ULzbeZq7DtO+6wcWuvvkUxaLXnFl0Rypa4H4g2hDcU/zrYDma9SYPXnqHYBkXvqiAQzz UPVBRPVhdc44MrQfMf7XIuPMyZupiol8NMr4VJCaUvNl1Df4IM7NQ11SBei/uHcS18Kt HdVaUDhJyxliINeMPn3zq7sO4XVxX23GX+rH9etjTRuSLckySkkNTD030bynoMmjiWs9 F6dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=eTzekCYHqAkrjY8gv7bsRN3sPl4ig5ZZ5RSPrbUBMmg=; b=CFh0FOKUwaofsTTb9UKrGK6uPekSZyJlJFUrnQcFjkQxEscCKZx3+veWpnWS2XTePF 67NB6nklGZ0Wl77CmlOoEDi57425UWB9MxcbY3Yuqj2+pklucnKheiUOBuR1hmp/ZhFy mmRClduTkB8UksL5qH2VWN3zrXGhIk21pX0TcyytZ4v/VB1d1IR7Zan3CdjJCP1avbWr mCqPYtWpotmHl/T2UgYibx2AEizB78PjmjTX4gWazVlNf+ReH5za9xCprg9fVd7yGCy4 KdRgto6Jn/W+Tt4CxbHyjI/sbbloctP3oS+xo5Np28HyVrMP3NFvGw8jkaBf9nyy40Xu 0hwA== X-Gm-Message-State: AODbwcAZ7A/IBSPAZ1nsSrOE8z85+FVL0VgBJceSE+SRYeSNOxSrc8Tp h1eCqmnsLbyedA== X-Received: by 10.55.80.70 with SMTP id e67mr27670201qkb.125.1495653796745; Wed, 24 May 2017 12:23:16 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 24 May 2017 12:22:32 -0700 Message-Id: <20170524192246.15905-20-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170524192246.15905-1-rth@twiddle.net> References: <20170524192246.15905-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH v2 19/33] target/s390x: Use unwind data for helper_unpk X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 9 +++++---- target/s390x/translate.c | 1 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index d4ee364..0701e10 100644 --- a/target/s390x/mem_helper.c +++ b/target/s390x/mem_helper.c @@ -679,6 +679,7 @@ uint64_t HELPER(cksm)(CPUS390XState *env, uint64_t r1, void HELPER(unpk)(CPUS390XState *env, uint32_t len, uint64_t dest, uint64_t src) { + uintptr_t ra =3D GETPC(); int len_dest =3D len >> 4; int len_src =3D len & 0xf; uint8_t b; @@ -688,8 +689,8 @@ void HELPER(unpk)(CPUS390XState *env, uint32_t len, uin= t64_t dest, src +=3D len_src; =20 /* last byte is special, it only flips the nibbles */ - b =3D cpu_ldub_data(env, src); - cpu_stb_data(env, dest, (b << 4) | (b >> 4)); + b =3D cpu_ldub_data_ra(env, src, ra); + cpu_stb_data_ra(env, dest, (b << 4) | (b >> 4), ra); src--; len_src--; =20 @@ -699,7 +700,7 @@ void HELPER(unpk)(CPUS390XState *env, uint32_t len, uin= t64_t dest, uint8_t cur_byte =3D 0; =20 if (len_src > 0) { - cur_byte =3D cpu_ldub_data(env, src); + cur_byte =3D cpu_ldub_data_ra(env, src, ra); } =20 len_dest--; @@ -718,7 +719,7 @@ void HELPER(unpk)(CPUS390XState *env, uint32_t len, uin= t64_t dest, /* zone bits */ cur_byte |=3D 0xf0; =20 - cpu_stb_data(env, dest, cur_byte); + cpu_stb_data_ra(env, dest, cur_byte, ra); } } =20 diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 76910bc..4978f19 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -4094,7 +4094,6 @@ static ExitStatus op_trt(DisasContext *s, DisasOps *o) static ExitStatus op_unpk(DisasContext *s, DisasOps *o) { TCGv_i32 l =3D tcg_const_i32(get_field(s->fields, l1)); - potential_page_fault(s); gen_helper_unpk(cpu_env, l, o->addr1, o->in2); tcg_temp_free_i32(l); return NO_EXIT; --=20 2.9.4