From nobody Mon Feb 9 04:45:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1495654667086240.83630778253587; Wed, 24 May 2017 12:37:47 -0700 (PDT) Received: from localhost ([::1]:56514 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDc6K-0006yr-C7 for importer@patchew.org; Wed, 24 May 2017 15:37:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDbsJ-0001vw-Fu for qemu-devel@nongnu.org; Wed, 24 May 2017 15:23:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDbsI-0001GS-Lq for qemu-devel@nongnu.org; Wed, 24 May 2017 15:23:15 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:36217) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dDbsI-0001GN-Hd for qemu-devel@nongnu.org; Wed, 24 May 2017 15:23:14 -0400 Received: by mail-qt0-x243.google.com with SMTP id j13so27554267qta.3 for ; Wed, 24 May 2017 12:23:14 -0700 (PDT) Received: from bigtime.twiddle.net.com ([2602:47:d954:1500:5e51:4fff:fe40:9c64]) by smtp.gmail.com with ESMTPSA id b23sm3296240qkb.31.2017.05.24.12.23.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 May 2017 12:23:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=+rU6X27Q2EHgtfHxY5ShUD6tFrZv9JFBvXuVE+6VAKE=; b=ZB+F+a4PoViScHEJAd2L2Kx/yFCZg9RqbaGBR7phr9n2ZtTCAduuFxzaLyBZ5GXbB0 mzawcu3Z6BG1pg2s8ap20Yy2VMIVRmMQjaA8/9fMTEUXk2X6sbM8pkMYLDx7IML8z5QY h10WJjRMq6K9kdI/SbyjEHTfl1BK4V8jNTqIWhKh3OstaGSr4zjxtcYrBBH7Ldt5B+lW LaSqm005JY/T9cUGyjIOZBjdou78chJRB5HKO8o0TL7joan4VFHRaqWtT+hiGZIqYH/Y wwW6WUS6624N3UMNvHB3seh6UVxUBTjokbenrE8xNtCNLh3xC5cRjnECv2yqvBljJZIK 0HZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=+rU6X27Q2EHgtfHxY5ShUD6tFrZv9JFBvXuVE+6VAKE=; b=Qe44R1yzsIMA6PC2iPYPx5EwXyuhCubgz+QZaSL1YwK8/JCNqdxz4+63g3A1MTqwBn CYC90Zc8ozWP7J0YDIDmSnC2oNyjFt6S9VBXg6zUe2wmvGieG1J86+cuns6D9ABSoZaK jo4PCpck0fHQSklQC3VVC17DtNA2SlH2da98NjE34cMAGLq25GAcdYeCTTPqmyT5AjI/ 6u2W19EQMOMYVBwa/OZLboVLRoo0z2EzlKRxB1qf5cXD9P9SZBFteWByhxw3Ox6M8bfF FibyuhZgxpbWczhQT4IDae3kbNvx60mw6mn+E4ywi008IgdnmxwnmCvlJueM7CTN7olA +uVA== X-Gm-Message-State: AODbwcDwVMlOwoMA4blY23oGfv86gtc3j2oNGUOZzWxSGK6OY1hQ5L3o M2K1bKAQAbi5+Q== X-Received: by 10.200.1.26 with SMTP id e26mr35889325qtg.75.1495653794107; Wed, 24 May 2017 12:23:14 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 24 May 2017 12:22:30 -0700 Message-Id: <20170524192246.15905-18-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170524192246.15905-1-rth@twiddle.net> References: <20170524192246.15905-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH v2 17/33] target/s390x: Use unwind data for helper_clcle X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Reviewed-by: Thomas Huth Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 6 +++--- target/s390x/translate.c | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 8a095ad..f5a3044 100644 --- a/target/s390x/mem_helper.c +++ b/target/s390x/mem_helper.c @@ -595,12 +595,12 @@ uint32_t HELPER(mvcle)(CPUS390XState *env, uint32_t r= 1, uint64_t a2, uint32_t HELPER(clcle)(CPUS390XState *env, uint32_t r1, uint64_t a2, uint32_t r3) { + uintptr_t ra =3D GETPC(); uint64_t destlen =3D env->regs[r1 + 1]; uint64_t dest =3D get_address_31fix(env, r1); uint64_t srclen =3D env->regs[r3 + 1]; uint64_t src =3D get_address_31fix(env, r3); uint8_t pad =3D a2 & 0xff; - uint8_t v1 =3D 0, v2 =3D 0; uint32_t cc =3D 0; =20 if (!(destlen || srclen)) { @@ -612,8 +612,8 @@ uint32_t HELPER(clcle)(CPUS390XState *env, uint32_t r1,= uint64_t a2, } =20 for (; destlen || srclen; src++, dest++, destlen--, srclen--) { - v1 =3D srclen ? cpu_ldub_data(env, src) : pad; - v2 =3D destlen ? cpu_ldub_data(env, dest) : pad; + uint8_t v1 =3D srclen ? cpu_ldub_data_ra(env, src, ra) : pad; + uint8_t v2 =3D destlen ? cpu_ldub_data_ra(env, dest, ra) : pad; if (v1 !=3D v2) { cc =3D (v1 < v2) ? 1 : 2; break; diff --git a/target/s390x/translate.c b/target/s390x/translate.c index b42acae..9270067 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -1915,7 +1915,6 @@ static ExitStatus op_clcle(DisasContext *s, DisasOps = *o) { TCGv_i32 r1 =3D tcg_const_i32(get_field(s->fields, r1)); TCGv_i32 r3 =3D tcg_const_i32(get_field(s->fields, r3)); - potential_page_fault(s); gen_helper_clcle(cc_op, cpu_env, r1, o->in2, r3); tcg_temp_free_i32(r1); tcg_temp_free_i32(r3); --=20 2.9.4