From nobody Sun Apr 28 22:17:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1495217128284410.01408181183456; Fri, 19 May 2017 11:05:28 -0700 (PDT) Received: from localhost ([::1]:59791 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBmHG-0001M9-Rh for importer@patchew.org; Fri, 19 May 2017 14:05:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBmFt-0000Uj-7P for qemu-devel@nongnu.org; Fri, 19 May 2017 14:04:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBmFs-0007Pj-AF for qemu-devel@nongnu.org; Fri, 19 May 2017 14:04:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57650) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dBmFs-0007PL-2M for qemu-devel@nongnu.org; Fri, 19 May 2017 14:04:00 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0EB003D941 for ; Fri, 19 May 2017 18:03:59 +0000 (UTC) Received: from t460.redhat.com (ovpn-116-70.ams2.redhat.com [10.36.116.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id 732C15C546; Fri, 19 May 2017 18:03:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0EB003D941 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=berrange@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0EB003D941 From: "Daniel P. Berrange" To: qemu-devel@nongnu.org Date: Fri, 19 May 2017 19:03:38 +0100 Message-Id: <20170519180342.19618-2-berrange@redhat.com> In-Reply-To: <20170519180342.19618-1-berrange@redhat.com> References: <20170519180342.19618-1-berrange@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 19 May 2017 18:03:59 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 1/5] sockets: ensure we can bind to both ipv4 & ipv6 separately X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When binding to an IPv6 socket we currently force the IPV6_V6ONLY flag to off. This means that the IPv6 socket will accept both IPv4 & IPv6 sockets when QEMU is launched with something like -vnc :::1 While this is good for that case, it is bad for other cases. For example if an empty hostname is given, getaddrinfo resolves it to 2 addresses 0.0.0.0 and ::, in that order. We will thus bind to 0.0.0.0 first, and then fail to bind to :: on the same port. The same problem can happen if any other hostname lookup causes the IPv4 address to be reported before the IPv6 address. When we get an IPv6 bind failure, we should re-try the same port, but with IPV6_V6ONLY turned on again, to avoid clash with any IPv4 listener. This ensures that -vnc :1 will bind successfully to both 0.0.0.0 and ::, and also avoid -vnc :1,to=3D2 from mistakenly using a 2nd port for the :: listener. Signed-off-by: Daniel P. Berrange Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- util/qemu-sockets.c | 31 +++++++++++++++++++++++-------- 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index d8183f7..397212b 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -208,22 +208,37 @@ static int inet_listen_saddr(InetSocketAddress *saddr, } =20 socket_set_fast_reuse(slisten); -#ifdef IPV6_V6ONLY - if (e->ai_family =3D=3D PF_INET6) { - /* listen on both ipv4 and ipv6 */ - const int off =3D 0; - qemu_setsockopt(slisten, IPPROTO_IPV6, IPV6_V6ONLY, &off, - sizeof(off)); - } -#endif =20 port_min =3D inet_getport(e); port_max =3D saddr->has_to ? saddr->to + port_offset : port_min; for (p =3D port_min; p <=3D port_max; p++) { +#ifdef IPV6_V6ONLY + /* listen on both ipv4 and ipv6 */ + int v6only =3D 0; +#endif inet_setport(e, p); +#ifdef IPV6_V6ONLY + rebind: + if (e->ai_family =3D=3D PF_INET6) { + qemu_setsockopt(slisten, IPPROTO_IPV6, IPV6_V6ONLY, &v6onl= y, + sizeof(v6only)); + } +#endif if (bind(slisten, e->ai_addr, e->ai_addrlen) =3D=3D 0) { goto listen; } + +#ifdef IPV6_V6ONLY + /* If we got EADDRINUSE from an IPv6 bind & V6ONLY is unset, + * it could be that the IPv4 port is already claimed, so retry + * with V6ONLY set + */ + if (e->ai_family =3D=3D PF_INET6 && errno =3D=3D EADDRINUSE &&= !v6only) { + v6only =3D 1; + goto rebind; + } +#endif + if (p =3D=3D port_max) { if (!e->ai_next) { error_setg_errno(errp, errno, "Failed to bind socket"); --=20 2.9.3 From nobody Sun Apr 28 22:17:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1495217129287923.8899385953355; Fri, 19 May 2017 11:05:29 -0700 (PDT) Received: from localhost ([::1]:59796 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBmHG-0001N6-Ts for importer@patchew.org; Fri, 19 May 2017 14:05:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41274) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBmFu-0000VL-Vk for qemu-devel@nongnu.org; Fri, 19 May 2017 14:04:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBmFu-0007QI-8G for qemu-devel@nongnu.org; Fri, 19 May 2017 14:04:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43388) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dBmFu-0007Q5-2W for qemu-devel@nongnu.org; Fri, 19 May 2017 14:04:02 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0E90A80F6C for ; Fri, 19 May 2017 18:04:01 +0000 (UTC) Received: from t460.redhat.com (ovpn-116-70.ams2.redhat.com [10.36.116.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id 977F9171AA; Fri, 19 May 2017 18:03:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0E90A80F6C Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=berrange@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0E90A80F6C From: "Daniel P. Berrange" To: qemu-devel@nongnu.org Date: Fri, 19 May 2017 19:03:39 +0100 Message-Id: <20170519180342.19618-3-berrange@redhat.com> In-Reply-To: <20170519180342.19618-1-berrange@redhat.com> References: <20170519180342.19618-1-berrange@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 19 May 2017 18:04:01 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 2/5] sockets: don't block IPv4 clients when listening on "::" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When inet_parse() parses the hostname, it is forcing the has_ipv6 && ipv6 flags if the address contains a ":". This means that if the user had set the ipv4=3Don flag, to try to restrict the listener to just ipv4, an error would not have been raised. eg -incoming tcp:[::]:9000,ipv4 should have raised an error because listening for IPv4 on "::" is a non-sensical combination. With this removed, we now call getaddrinfo() on "::" passing PF_INET and so getaddrinfo reports an error about the hostname being incompatible with the requested protocol. Likewise it is explicitly setting the has_ipv4 & ipv4 flags when the address contains only digits + '.'. This has no ill-effect, but also has no benefit, so is removed. Signed-off-by: Daniel P. Berrange Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- util/qemu-sockets.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 397212b..b82412e 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -618,16 +618,12 @@ int inet_parse(InetSocketAddress *addr, const char *s= tr, Error **errp) error_setg(errp, "error parsing IPv6 address '%s'", str); return -1; } - addr->ipv6 =3D addr->has_ipv6 =3D true; } else { /* hostname or IPv4 addr */ if (sscanf(str, "%64[^:]:%32[^,]%n", host, port, &pos) !=3D 2) { error_setg(errp, "error parsing address '%s'", str); return -1; } - if (host[strspn(host, "0123456789.")] =3D=3D '\0') { - addr->ipv4 =3D addr->has_ipv4 =3D true; - } } =20 addr->host =3D g_strdup(host); --=20 2.9.3 From nobody Sun Apr 28 22:17:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 14952172517982.9374742536939493; Fri, 19 May 2017 11:07:31 -0700 (PDT) Received: from localhost ([::1]:59804 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBmJF-000386-AX for importer@patchew.org; Fri, 19 May 2017 14:07:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBmFx-0000Y1-Rh for qemu-devel@nongnu.org; Fri, 19 May 2017 14:04:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBmFw-0007RH-C6 for qemu-devel@nongnu.org; Fri, 19 May 2017 14:04:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43438) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dBmFw-0007Ql-3Q for qemu-devel@nongnu.org; Fri, 19 May 2017 14:04:04 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0F01B804FF for ; Fri, 19 May 2017 18:04:03 +0000 (UTC) Received: from t460.redhat.com (ovpn-116-70.ams2.redhat.com [10.36.116.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id 62C1A5C546; Fri, 19 May 2017 18:04:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0F01B804FF Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=berrange@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0F01B804FF From: "Daniel P. Berrange" To: qemu-devel@nongnu.org Date: Fri, 19 May 2017 19:03:40 +0100 Message-Id: <20170519180342.19618-4-berrange@redhat.com> In-Reply-To: <20170519180342.19618-1-berrange@redhat.com> References: <20170519180342.19618-1-berrange@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 19 May 2017 18:04:03 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 3/5] sockets: ensure we don't accept IPv4 clients when IPv4 is disabled X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Currently if you disable listening on IPv4 addresses, via the CLI flag ipv4=3Doff, we still mistakenly accept IPv4 clients via the IPv6 listener socket due to IPV6_V6ONLY flag being unset. We must ensure IPV6_V6ONLY is always set if ipv4=3Doff This fixes the following scenarios -incoming tcp::9000,ipv6=3Don -incoming tcp:[::]:9000,ipv6=3Don -chardev socket,id=3Dcdev0,host=3D,port=3D9000,server,nowait,ipv4=3Doff -chardev socket,id=3Dcdev0,host=3D,port=3D9000,server,nowait,ipv6=3Don -chardev socket,id=3Dcdev0,host=3D::,port=3D9000,server,nowait,ipv4=3Doff -chardev socket,id=3Dcdev0,host=3D::,port=3D9000,server,nowait,ipv6=3Don which all mistakenly accepted IPv4 clients Signed-off-by: Daniel P. Berrange Reviewed-by: Eric Blake --- util/qemu-sockets.c | 40 +++++++++++++++++++++++++++++++--------- 1 file changed, 31 insertions(+), 9 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index b82412e..c0f2d92 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -104,17 +104,16 @@ NetworkAddressFamily inet_netfamily(int family) * f t PF_INET6 * t - PF_INET * t f PF_INET - * t t PF_INET6 + * t t PF_INET6/PF_UNSPEC * * NB, this matrix is only about getting the necessary results * from getaddrinfo(). Some of the cases require further work * after reading results from getaddrinfo in order to fully - * apply the logic the end user wants. eg with the last case - * ipv4=3Dt + ipv6=3Dt + PF_INET6, getaddrinfo alone can only - * guarantee the ipv6=3Dt part of the request - we need more - * checks to provide ipv4=3Dt part of the guarantee. This is - * outside scope of this method and not currently handled by - * callers at all. + * apply the logic the end user wants. + * + * In the first and last cases, we must set IPV6_V6ONLY=3D0 + * when binding, to allow a single listener to potentially + * accept both IPv4+6 addresses. */ int inet_ai_family_from_address(InetSocketAddress *addr, Error **errp) @@ -124,6 +123,23 @@ int inet_ai_family_from_address(InetSocketAddress *add= r, error_setg(errp, "Cannot disable IPv4 and IPv6 at same time"); return PF_UNSPEC; } + if ((addr->has_ipv6 && addr->ipv6) && (addr->has_ipv4 && addr->ipv4)) { + /* + * Some backends can only do a single listener. In that case + * we want empty hostname to resolve to "::" and then use the + * flag IPV6_V6ONLY=3D=3D0 to get both protocols on 1 socket. This + * doesn't work for addresses other than "", so they're just + * inevitably broken until multiple listeners can be used, + * and thus we honour getaddrinfo automatic protocol detection + * Once all backends do multi-listener, remove the PF_INET6 + * branch entirely. + */ + if (!addr->host || g_str_equal(addr->host, "")) { + return PF_INET6; + } else { + return PF_UNSPEC; + } + } if ((addr->has_ipv6 && addr->ipv6) || (addr->has_ipv4 && !addr->ipv4))= { return PF_INET6; } @@ -213,8 +229,14 @@ static int inet_listen_saddr(InetSocketAddress *saddr, port_max =3D saddr->has_to ? saddr->to + port_offset : port_min; for (p =3D port_min; p <=3D port_max; p++) { #ifdef IPV6_V6ONLY - /* listen on both ipv4 and ipv6 */ - int v6only =3D 0; + /* + * Deals with first & last cases in matrix in comment + * for inet_ai_family_from_address(). + */ + int v6only =3D + ((!saddr->has_ipv4 && !saddr->has_ipv6) || + (saddr->has_ipv4 && saddr->ipv4 && + saddr->has_ipv6 && saddr->ipv6)) ? 0 : 1; #endif inet_setport(e, p); #ifdef IPV6_V6ONLY --=20 2.9.3 From nobody Sun Apr 28 22:17:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149521724967912.751906751512479; Fri, 19 May 2017 11:07:29 -0700 (PDT) Received: from localhost ([::1]:59803 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBmJE-00035o-C6 for importer@patchew.org; Fri, 19 May 2017 14:07:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBmG1-0000aq-2W for qemu-devel@nongnu.org; Fri, 19 May 2017 14:04:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBmFy-0007Rr-Pu for qemu-devel@nongnu.org; Fri, 19 May 2017 14:04:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39088) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dBmFy-0007Rj-KI for qemu-devel@nongnu.org; Fri, 19 May 2017 14:04:06 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 95070C057FAD for ; Fri, 19 May 2017 18:04:05 +0000 (UTC) Received: from t460.redhat.com (ovpn-116-70.ams2.redhat.com [10.36.116.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6F9CA17241; Fri, 19 May 2017 18:04:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 95070C057FAD Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=berrange@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 95070C057FAD From: "Daniel P. Berrange" To: qemu-devel@nongnu.org Date: Fri, 19 May 2017 19:03:41 +0100 Message-Id: <20170519180342.19618-5-berrange@redhat.com> In-Reply-To: <20170519180342.19618-1-berrange@redhat.com> References: <20170519180342.19618-1-berrange@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 19 May 2017 18:04:05 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 4/5] io: preserve ipv4/ipv6 flags when resolving InetSocketAddress X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The original InetSocketAddress struct may have has_ipv4 and has_ipv6 fields set, which will control both the ai_family used during DNS resolution, and later use of the V6ONLY flag. Currently the standalone DNS resolver code drops the has_ipv4 & has_ipv6 flags after resolving, which means the later bind() code won't correctly set V6ONLY. This fixes the following scenarios -vnc :0,ipv4=3Doff -vnc :0,ipv6=3Don -vnc :::0,ipv4=3Doff -vnc :::0,ipv6=3Don which all mistakenly accepted IPv4 clients Signed-off-by: Daniel P. Berrange Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- io/dns-resolver.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/io/dns-resolver.c b/io/dns-resolver.c index 57a8896..c072d12 100644 --- a/io/dns-resolver.c +++ b/io/dns-resolver.c @@ -116,8 +116,10 @@ static int qio_dns_resolver_lookup_sync_inet(QIODNSRes= olver *resolver, .numeric =3D true, .has_to =3D iaddr->has_to, .to =3D iaddr->to, - .has_ipv4 =3D false, - .has_ipv6 =3D false, + .has_ipv4 =3D iaddr->has_ipv4, + .ipv4 =3D iaddr->ipv4, + .has_ipv6 =3D iaddr->has_ipv6, + .ipv6 =3D iaddr->ipv6, }; =20 (*addrs)[i] =3D newaddr; --=20 2.9.3 From nobody Sun Apr 28 22:17:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1495217365945894.9603922618874; Fri, 19 May 2017 11:09:25 -0700 (PDT) Received: from localhost ([::1]:59814 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBmL3-0004Y4-Me for importer@patchew.org; Fri, 19 May 2017 14:09:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBmG5-0000ef-3u for qemu-devel@nongnu.org; Fri, 19 May 2017 14:04:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBmG1-0007Sm-AJ for qemu-devel@nongnu.org; Fri, 19 May 2017 14:04:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43958) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dBmG0-0007SL-Un for qemu-devel@nongnu.org; Fri, 19 May 2017 14:04:09 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C4DDC5277D for ; Fri, 19 May 2017 18:04:07 +0000 (UTC) Received: from t460.redhat.com (ovpn-116-70.ams2.redhat.com [10.36.116.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id DDE5D171AA; Fri, 19 May 2017 18:04:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C4DDC5277D Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=berrange@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C4DDC5277D From: "Daniel P. Berrange" To: qemu-devel@nongnu.org Date: Fri, 19 May 2017 19:03:42 +0100 Message-Id: <20170519180342.19618-6-berrange@redhat.com> In-Reply-To: <20170519180342.19618-1-berrange@redhat.com> References: <20170519180342.19618-1-berrange@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 19 May 2017 18:04:07 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 5/5] tests: add functional test validating ipv4/ipv6 address flag handling X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The semantics around handling ipv4=3Don|off & ipv6=3Don|off are quite subtle to understand in combination with the various hostname addresses and backend types. Introduce a massive test matrix that launches QEMU and validates the ability to connect a client on each protocol as appropriate. The test requires that the host has ability to bind to both :: and 0.0.0.0, on port 9000. If either protocol is not available, or if something is already listening on that port the test will skip. Although it isn't using the QTest APIs, it expects the QTEST_QEMU_BINARY env variable to be set. Signed-off-by: Daniel P. Berrange Reviewed-by: Eric Blake Tested-by: Eric Blake --- tests/.gitignore | 1 + tests/Makefile.include | 4 + tests/test-sockets-proto.c | 855 +++++++++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 860 insertions(+) create mode 100644 tests/test-sockets-proto.c diff --git a/tests/.gitignore b/tests/.gitignore index 40c2e3e..9fa14e5 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -76,6 +76,7 @@ test-qobject-output-visitor test-rcu-list test-replication test-shift128 +test-sockets-proto test-string-input-visitor test-string-output-visitor test-thread-pool diff --git a/tests/Makefile.include b/tests/Makefile.include index 16ff8f3..c3b487e 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -261,6 +261,7 @@ check-qtest-i386-y +=3D tests/test-filter-redirector$(E= XESUF) check-qtest-i386-y +=3D tests/postcopy-test$(EXESUF) check-qtest-i386-y +=3D tests/test-x86-cpuid-compat$(EXESUF) check-qtest-i386-y +=3D tests/numa-test$(EXESUF) +check-qtest-i386-y +=3D tests/test-sockets-proto$(EXESUF) check-qtest-x86_64-y +=3D $(check-qtest-i386-y) gcov-files-i386-y +=3D i386-softmmu/hw/timer/mc146818rtc.c gcov-files-x86_64-y =3D $(subst i386-softmmu/,x86_64-softmmu/,$(gcov-files= -i386-y)) @@ -287,6 +288,7 @@ check-qtest-ppc64-y +=3D tests/prom-env-test$(EXESUF) check-qtest-ppc64-y +=3D tests/pnv-xscom-test$(EXESUF) check-qtest-ppc64-y +=3D tests/drive_del-test$(EXESUF) check-qtest-ppc64-y +=3D tests/postcopy-test$(EXESUF) +check-qtest-ppc64-y +=3D tests/test-sockets-proto$(EXESUF) check-qtest-ppc64-y +=3D tests/boot-serial-test$(EXESUF) check-qtest-ppc64-y +=3D tests/rtas-test$(EXESUF) check-qtest-ppc64-y +=3D tests/pxe-test$(EXESUF) @@ -741,6 +743,8 @@ tests/usb-hcd-ehci-test$(EXESUF): tests/usb-hcd-ehci-te= st.o $(libqos-usb-obj-y) tests/usb-hcd-xhci-test$(EXESUF): tests/usb-hcd-xhci-test.o $(libqos-usb-o= bj-y) tests/pc-cpu-test$(EXESUF): tests/pc-cpu-test.o tests/postcopy-test$(EXESUF): tests/postcopy-test.o +tests/test-sockets-proto$(EXESUF): tests/test-sockets-proto.o \ + $(test-io-obj-y) tests/vhost-user-test$(EXESUF): tests/vhost-user-test.o $(test-util-obj-y)= \ $(qtest-obj-y) $(test-io-obj-y) $(libqos-virtio-obj-y) $(libqos-pc-obj-y)= \ $(chardev-obj-y) diff --git a/tests/test-sockets-proto.c b/tests/test-sockets-proto.c new file mode 100644 index 0000000..f058a50 --- /dev/null +++ b/tests/test-sockets-proto.c @@ -0,0 +1,855 @@ +/* + * QTest for IPv4/IPv6 protocol setup + * + * Copyright (c) 2017 Red Hat, Inc. and/or its affiliates + * + * This work is licensed under the terms of the GNU GPL, version 2 or late= r. + * See the COPYING file in the top-level directory. + * + */ + +#include "qemu/osdep.h" + +#include "io/channel-socket.h" +#include "qapi/error.h" +#include "qemu/cutils.h" + +typedef struct { + const char *name; + const char *args; + bool ipv4; + bool ipv6; + bool error; +} QSocketsData; + +/* + * This is the giant matrix of combinations we need to consider. + * There are 3 axes we deal with + * + * Axis 1: Protocol flags: + * + * ipv4=3Dunset, ipv6=3Dunset -> v4 & v6 clients ([1] + * ipv4=3Dunset, ipv6=3Doff -> v4 clients only + * ipv4=3Dunset, ipv6=3Don -> v6 clients only + * ipv4=3Doff, ipv6=3Dunset -> v6 clients only + * ipv4=3Doff, ipv6=3Doff -> error - can't disable both [2] + * ipv4=3Doff, ipv6=3Don -> v6 clients only + * ipv4=3Don, ipv6=3Dunset -> v4 clients only + * ipv4=3Don, ipv6=3Doff -> v4 clients only + * ipv4=3Don, ipv6=3Don -> v4 & v6 clients [3] + * + * Depending on the listening address, some of those combinations + * may result in errors. eg ipv4=3Doff,ipv6=3Don combined with 0.0.0.0 + * is nonsensical. + * + * [1] Some backends only support a single socket listener, so + * will actually only allow v4 clients + * [2] QEMU should fail to startup in this case + * [3] If hostname is "" or "::", then we get a single listener + * on IPv6 and thus can also accept v4 clients. For all other + * hostnames, have same problem as [1]. + * + * Axis 2: Listening address: + * + * "" - resolves to 0.0.0.0 and ::, in that order + * "0.0.0.0" - v4 clients only + * "::" - Mostly v6 clients only. Some scenarios should + * permit v4 clients too. + * + * Axis 3: Backend type: + * + * Migration - restricted to a single listener. Also relies + * on buggy inet_parse() which can't accept + * =3Doff/=3Don parameters to ipv4/ipv6 flags + * Chardevs - restricted to a single listener. + * VNC - supports multiple listeners. Also supports + * socket ranges, so has extra set of tests + * in the matrix + * + */ +static QSocketsData test_data[] =3D { + /* Migrate with "" address */ + /* XXX all settings with =3Doff are disabled due to inet_parse() bug */ + /* XXX multilistener bug - should be .ipv6 =3D 1 */ + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/migrate/wildcard/all", + .args =3D "-incoming tcp::9000" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/migrate/wildcard/ipv4", + .args =3D "-incoming tcp::9000,ipv4" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/migrate/wildcard/ipv6", + .args =3D "-incoming tcp::9000,ipv6" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/migrate/wildcard/ipv4on", + .args =3D "-incoming tcp::9000,ipv4=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/migrate/wildcard/ipv6on", + .args =3D "-incoming tcp::9000,ipv6=3Don" }, + /* + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/migrate/wildcard/ipv4off", + .args =3D "-incoming tcp::9000,ipv4=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/migrate/wildcard/ipv6off", + .args =3D "-incoming tcp::9000,ipv6=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/migrate/wildcard/ipv4onipv6off", + .args =3D "-incoming tcp::9000,ipv4=3Don,ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/migrate/wildcard/ipv4offipv6on", + .args =3D "-incoming tcp::9000,ipv4=3Doff,ipv6=3Don" }, + */ + { .ipv4 =3D 1, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/migrate/wildcard/ipv4onipv6on", + .args =3D "-incoming tcp::9000,ipv4=3Don,ipv6=3Don" }, + /* + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/migrate/wildcard/ipv4offipv6off", + .args =3D "-incoming tcp::9000,ipv4=3Doff,ipv6=3Doff" }, + */ + + /* Migrate with 0.0.0.0 address */ + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/migrate/0.0.0.0/all", + .args =3D "-incoming tcp:0.0.0.0:9000" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/migrate/0.0.0.0/ipv4", + .args =3D "-incoming tcp:0.0.0.0:9000,ipv4" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/migrate/0.0.0.0/ipv6", + .args =3D "-incoming tcp:0.0.0.0:9000,ipv6" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/migrate/0.0.0.0/ipv4on", + .args =3D "-incoming tcp:0.0.0.0:9000,ipv4=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/migrate/0.0.0.0/ipv6on", + .args =3D "-incoming tcp:0.0.0.0:9000,ipv6=3Don" }, + /* + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/migrate/0.0.0.0/ipv4off", + .args =3D "-incoming tcp:0.0.0.0:9000,ipv4=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/migrate/0.0.0.0/ipv6off", + .args =3D "-incoming tcp:0.0.0.0:9000,ipv6=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/migrate/0.0.0.0/ipv4onipv6off", + .args =3D "-incoming tcp:0.0.0.0:9000,ipv4=3Don,ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/migrate/0.0.0.0/ipv4offipv6on", + .args =3D "-incoming tcp:0.0.0.0:9000,ipv4=3Doff,ipv6=3Don" }, + */ + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/migrate/0.0.0.0/ipv4onipv6on", + .args =3D "-incoming tcp:0.0.0.0:9000,ipv4=3Don,ipv6=3Don" }, + /* + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/migrate/0.0.0.0/ipv4offipv6off", + .args =3D "-incoming tcp:0.0.0.0:9000,ipv4=3Doff,ipv6=3Doff" }, + */ + + /* Migrate with :: address */ + { .ipv4 =3D 1, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/migrate/::/all", + .args =3D "-incoming tcp:[::]:9000" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/migrate/::/ipv4", + .args =3D "-incoming tcp:[::]:9000,ipv4" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/migrate/::/ipv6", + .args =3D "-incoming tcp:[::]:9000,ipv6" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/migrate/::/ipv4on", + .args =3D "-incoming tcp:[::]:9000,ipv4=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/migrate/::/ipv6on", + .args =3D "-incoming tcp:[::]:9000,ipv6=3Don" }, + /* + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/migrate/::/ipv4off", + .args =3D "-incoming tcp:[::]:9000,ipv4=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/migrate/::/ipv6off", + .args =3D "-incoming tcp:[::]:9000,ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/migrate/::/ipv4onipv6off", + .args =3D "-incoming tcp:[::]:9000,ipv4=3Don,ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/migrate/::/ipv4offipv6on", + .args =3D "-incoming tcp:[::]:9000,ipv4=3Doff,ipv6=3Don" }, + */ + { .ipv4 =3D 1, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/migrate/::/ipv4onipv6on", + .args =3D "-incoming tcp:[::]:9000,ipv4=3Don,ipv6=3Don" }, + /* + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/migrate/::/ipv4offipv6off", + .args =3D "-incoming tcp:[::]:9000,ipv4=3Doff,ipv6=3Doff" }, + */ + + + + /* Chardev with "" address */ + /* XXX multilistener bug - should be .ipv6 =3D 1 */ + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/chardev/wildcard/all", + .args =3D "-chardev socket,id=3Dcdev0,host=3D,port=3D9000,server,now= ait" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/chardev/wildcard/ipv4", + .args =3D "-chardev socket,id=3Dcdev0,host=3D,port=3D9000,server,now= ait," + "ipv4" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/chardev/wildcard/ipv6", + .args =3D "-chardev socket,id=3Dcdev0,host=3D,port=3D9000,server,now= ait," + "ipv6" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/chardev/wildcard/ipv4on", + .args =3D "-chardev socket,id=3Dcdev0,host=3D,port=3D9000,server,now= ait," + "ipv4=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/chardev/wildcard/ipv6on", + .args =3D "-chardev socket,id=3Dcdev0,host=3D,port=3D9000,server,now= ait," + "ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/chardev/wildcard/ipv4off", + .args =3D "-chardev socket,id=3Dcdev0,host=3D,port=3D9000,server,now= ait," + "ipv4=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/chardev/wildcard/ipv6off", + .args =3D "-chardev socket,id=3Dcdev0,host=3D,port=3D9000,server,now= ait," + "ipv6=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/chardev/wildcard/ipv4onipv6off", + .args =3D "-chardev socket,id=3Dcdev0,host=3D,port=3D9000,server,now= ait," + "ipv4=3Don,ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/chardev/wildcard/ipv4offipv6on", + .args =3D "-chardev socket,id=3Dcdev0,host=3D,port=3D9000,server,now= ait," + "ipv4=3Doff,ipv6=3Don" }, + { .ipv4 =3D 1, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/chardev/wildcard/ipv4onipv6on", + .args =3D "-chardev socket,id=3Dcdev0,host=3D,port=3D9000,server,now= ait," + "ipv4=3Don,ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/chardev/wildcard/ipv4offipv6off", + .args =3D "-chardev socket,id=3Dcdev0,host=3D,port=3D9000,server,now= ait," + "ipv4=3Doff,ipv6=3Doff" }, + + /* Chardev with 0.0.0.0 address */ + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/chardev/0.0.0.0/all", + .args =3D "-chardev socket,id=3Dcdev0,host=3D0.0.0.0,port=3D9000,ser= ver,nowait" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/chardev/0.0.0.0/ipv4", + .args =3D "-chardev socket,id=3Dcdev0,host=3D0.0.0.0,port=3D9000,ser= ver,nowait," + "ipv4" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/chardev/0.0.0.0/ipv6", + .args =3D "-chardev socket,id=3Dcdev0,host=3D0.0.0.0,port=3D9000,ser= ver,nowait," + "ipv6" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/chardev/0.0.0.0/ipv4on", + .args =3D "-chardev socket,id=3Dcdev0,host=3D0.0.0.0,port=3D9000,ser= ver,nowait," + "ipv4=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/chardev/0.0.0.0/ipv6on", + .args =3D "-chardev socket,id=3Dcdev0,host=3D0.0.0.0,port=3D9000,ser= ver,nowait," + "ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/chardev/0.0.0.0/ipv4off", + .args =3D "-chardev socket,id=3Dcdev0,host=3D0.0.0.0,port=3D9000,ser= ver,nowait," + "ipv4=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/chardev/0.0.0.0/ipv6off", + .args =3D "-chardev socket,id=3Dcdev0,host=3D0.0.0.0,port=3D9000,ser= ver,nowait," + "ipv6=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/chardev/0.0.0.0/ipv4onipv6off", + .args =3D "-chardev socket,id=3Dcdev0,host=3D0.0.0.0,port=3D9000,ser= ver,nowait," + "ipv4=3Don,ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/chardev/0.0.0.0/ipv4offipv6on", + .args =3D "-chardev socket,id=3Dcdev0,host=3D0.0.0.0,port=3D9000,ser= ver,nowait," + "ipv4=3Doff,ipv6=3Don" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/chardev/0.0.0.0/ipv4onipv6on", + .args =3D "-chardev socket,id=3Dcdev0,host=3D0.0.0.0,port=3D9000,ser= ver,nowait," + "ipv4=3Don,ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/chardev/0.0.0.0/ipv4offipv6off", + .args =3D "-chardev socket,id=3Dcdev0,host=3D0.0.0.0,port=3D9000,ser= ver,nowait," + "ipv4=3Doff,ipv6=3Doff" }, + + /* Chardev with :: address */ + { .ipv4 =3D 1, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/chardev/::/all", + .args =3D "-chardev socket,id=3Dcdev0,host=3D::,port=3D9000,server,n= owait" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/chardev/::/ipv4", + .args =3D "-chardev socket,id=3Dcdev0,host=3D::,port=3D9000,server,n= owait," + "ipv4" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/chardev/::/ipv6", + .args =3D "-chardev socket,id=3Dcdev0,host=3D::,port=3D9000,server,n= owait," + "ipv6" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/chardev/::/ipv4on", + .args =3D "-chardev socket,id=3Dcdev0,host=3D::,port=3D9000,server,n= owait," + "ipv4=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/chardev/::/ipv6on", + .args =3D "-chardev socket,id=3Dcdev0,host=3D::,port=3D9000,server,n= owait," + "ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/chardev/::/ipv4off", + .args =3D "-chardev socket,id=3Dcdev0,host=3D::,port=3D9000,server,n= owait," + "ipv4=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/chardev/::/ipv6off", + .args =3D "-chardev socket,id=3Dcdev0,host=3D::,port=3D9000,server,n= owait," + "ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/chardev/::/ipv4onipv6off", + .args =3D "-chardev socket,id=3Dcdev0,host=3D::,port=3D9000,server,n= owait," + "ipv4=3Don,ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/chardev/::/ipv4offipv6on", + .args =3D "-chardev socket,id=3Dcdev0,host=3D::,port=3D9000,server,n= owait," + "ipv4=3Doff,ipv6=3Don" }, + { .ipv4 =3D 1, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/chardev/::/ipv4onipv6on", + .args =3D "-chardev socket,id=3Dcdev0,host=3D::,port=3D9000,server,n= owait," + "ipv4=3Don,ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/chardev/::/ipv4offipv6off", + .args =3D "-chardev socket,id=3Dcdev0,host=3D::,port=3D9000,server,n= owait," + "ipv4=3Doff,ipv6=3Doff" }, + + + + /* Net with "" address */ + /* XXX does not yet support ipv4/ipv6 flags at all */ + /* XXX multilistener bug - should be .ipv6 =3D 1 */ + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/net/wildcard/all", + .args =3D "-netdev socket,id=3Dnet0,listen=3D:9000" }, + /* + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/net/wildcard/ipv4", + .args =3D "-netdev socket,id=3Dnet0,listen=3D:9000,ipv4" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/net/wildcard/ipv6", + .args =3D "-netdev socket,id=3Dnet0,listen=3D:9000,ipv6" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/net/wildcard/ipv4on", + .args =3D "-netdev socket,id=3Dnet0,listen=3D:9000,ipv4=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/net/wildcard/ipv6on", + .args =3D "-netdev socket,id=3Dnet0,listen=3D:9000,ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/net/wildcard/ipv4off", + .args =3D "-netdev socket,id=3Dnet0,listen=3D:9000,ipv4=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/net/wildcard/ipv6off", + .args =3D "-netdev socket,id=3Dnet0,listen=3D:9000,ipv6=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/net/wildcard/ipv4onipv6off", + .args =3D "-netdev socket,id=3Dnet0,listen=3D:9000,ipv4=3Don,ipv6=3D= off" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/net/wildcard/ipv4offipv6on", + .args =3D "-netdev socket,id=3Dnet0,listen=3D:9000,ipv4=3Doff,ipv6= =3Don" }, + { .ipv4 =3D 1, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/net/wildcard/ipv4onipv6on", + .args =3D "-netdev socket,id=3Dnet0,listen=3D:9000,ipv4=3Don,ipv6=3D= on" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/net/wildcard/ipv4offipv6off", + .args =3D "-netdev socket,id=3Dnet0,listen=3D:9000,ipv4=3Doff,ipv6= =3Doff" }, + */ + + /* Net with 0.0.0.0 address */ + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/net/0.0.0.0/all", + .args =3D "-netdev socket,id=3Dnet0,listen=3D0.0.0.0:9000" }, + /* + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/net/0.0.0.0/ipv4", + .args =3D "-netdev socket,id=3Dnet0,listen=3D0.0.0.0:9000,ipv4" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/net/0.0.0.0/ipv6", + .args =3D "-netdev socket,id=3Dnet0,listen=3D0.0.0.0:9000,ipv6" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/net/0.0.0.0/ipv4on", + .args =3D "-netdev socket,id=3Dnet0,listen=3D0.0.0.0:9000,ipv4=3Don"= }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/net/0.0.0.0/ipv6on", + .args =3D "-netdev socket,id=3Dnet0,listen=3D0.0.0.0:9000,ipv6=3Don"= }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/net/0.0.0.0/ipv4off", + .args =3D "-netdev socket,id=3Dnet0,listen=3D0.0.0.0:9000,ipv4=3Doff= " }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/net/0.0.0.0/ipv6off", + .args =3D "-netdev socket,id=3Dnet0,listen=3D0.0.0.0:9000,ipv6=3Doff= " }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/net/0.0.0.0/ipv4onipv6off", + .args =3D "-netdev socket,id=3Dnet0,listen=3D0.0.0.0:9000,ipv4=3Don,= ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/net/0.0.0.0/ipv4offipv6on", + .args =3D "-netdev socket,id=3Dnet0,listen=3D0.0.0.0:9000,ipv4=3Doff= ,ipv6=3Don" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/net/0.0.0.0/ipv4onipv6on", + .args =3D "-netdev socket,id=3Dnet0,listen=3D0.0.0.0:9000,ipv4=3Don,= ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/net/0.0.0.0/ipv4offipv6off", + .args =3D "-netdev socket,id=3Dnet0,listen=3D0.0.0.0:9000,ipv4=3Doff= ,ipv6=3Doff" }, + */ + + /* Net with :: address */ + { .ipv4 =3D 1, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/net/::/all", + .args =3D "-netdev socket,id=3Dnet0,listen=3D[::]:9000" }, + /* + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/net/::/ipv4", + .args =3D "-netdev socket,id=3Dnet0,listen=3D[::]:9000,ipv4" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/net/::/ipv6", + .args =3D "-netdev socket,id=3Dnet0,listen=3D[::]:9000,ipv6" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/net/::/ipv4on", + .args =3D "-netdev socket,id=3Dnet0,listen=3D[::]:9000,ipv4=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/net/::/ipv6on", + .args =3D "-netdev socket,id=3Dnet0,listen=3D[::]:9000,ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/net/::/ipv4off", + .args =3D "-netdev socket,id=3Dnet0,listen=3D[::]:9000,ipv4=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/net/::/ipv6off", + .args =3D "-netdev socket,id=3Dnet0,listen=3D[::]:9000,ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/net/::/ipv4onipv6off", + .args =3D "-netdev socket,id=3Dnet0,listen=3D[::]:9000,ipv4=3Don,ipv= 6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/net/::/ipv4offipv6on", + .args =3D "-netdev socket,id=3Dnet0,listen=3D[::]:9000,ipv4=3Doff,ip= v6=3Don" }, + { .ipv4 =3D 1, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/net/::/ipv4onipv6on", + .args =3D "-netdev socket,id=3Dnet0,listen=3D[::]:9000,ipv4=3Don,ipv= 6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/net/::/ipv4offipv6off", + .args =3D "-netdev socket,id=3Dnet0,listen=3D[::]:9000,ipv4=3Doff,ip= v6=3Doff" }, + */ + + + /* VNC with "" address */ + { .ipv4 =3D 1, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc/wildcard/all", + .args =3D "-vnc :3100" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc/wildcard/ipv4", + .args =3D "-vnc :3100,ipv4" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc/wildcard/ipv6", + .args =3D "-vnc :3100,ipv6" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc/wildcard/ipv4on", + .args =3D "-vnc :3100,ipv4=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc/wildcard/ipv6on", + .args =3D "-vnc :3100,ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc/wildcard/ipv4off", + .args =3D "-vnc :3100,ipv4=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc/wildcard/ipv6off", + .args =3D "-vnc :3100,ipv6=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc/wildcard/ipv4onipv6off", + .args =3D "-vnc :3100,ipv4=3Don,ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc/wildcard/ipv4offipv6on", + .args =3D "-vnc :3100,ipv4=3Doff,ipv6=3Don" }, + { .ipv4 =3D 1, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc/wildcard/ipv4onipv6on", + .args =3D "-vnc :3100,ipv4=3Don,ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc/wildcard/ipv4offipv6off", + .args =3D "-vnc :3100,ipv4=3Doff,ipv6=3Doff" }, + + /* VNC with 0.0.0.0 address */ + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc/0.0.0.0/all", + .args =3D "-vnc 0.0.0.0:3100" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc/0.0.0.0/ipv4", + .args =3D "-vnc 0.0.0.0:3100,ipv4" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc/0.0.0.0/ipv6", + .args =3D "-vnc 0.0.0.0:3100,ipv6" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc/0.0.0.0/ipv4on", + .args =3D "-vnc 0.0.0.0:3100,ipv4=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc/0.0.0.0/ipv6on", + .args =3D "-vnc 0.0.0.0:3100,ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc/0.0.0.0/ipv4off", + .args =3D "-vnc 0.0.0.0:3100,ipv4=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc/0.0.0.0/ipv6off", + .args =3D "-vnc 0.0.0.0:3100,ipv6=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc/0.0.0.0/ipv4onipv6off", + .args =3D "-vnc 0.0.0.0:3100,ipv4=3Don,ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc/0.0.0.0/ipv4offipv6on", + .args =3D "-vnc 0.0.0.0:3100,ipv4=3Doff,ipv6=3Don" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc/0.0.0.0/ipv4onipv6on", + .args =3D "-vnc 0.0.0.0:3100,ipv4=3Don,ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc/0.0.0.0/ipv4offipv6off", + .args =3D "-vnc 0.0.0.0:3100,ipv4=3Doff,ipv6=3Doff" }, + + /* VNC with :: address */ + { .ipv4 =3D 1, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc/::/all", + .args =3D "-vnc :::3100" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc/::/ipv4", + .args =3D "-vnc :::3100,ipv4" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc/::/ipv6", + .args =3D "-vnc :::3100,ipv6" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc/::/ipv4on", + .args =3D "-vnc :::3100,ipv4=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc/::/ipv6on", + .args =3D "-vnc :::3100,ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc/::/ipv4off", + .args =3D "-vnc :::3100,ipv4=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc/::/ipv6off", + .args =3D "-vnc :::3100,ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc/::/ipv4onipv6off", + .args =3D "-vnc :::3100,ipv4=3Don,ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc/::/ipv4offipv6on", + .args =3D "-vnc :::3100,ipv4=3Doff,ipv6=3Don" }, + { .ipv4 =3D 1, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc/::/ipv4onipv6on", + .args =3D "-vnc :::3100,ipv4=3Don,ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc/::/ipv4offipv6off", + .args =3D "-vnc :::3100,ipv4=3Doff,ipv6=3Doff" }, + + + + /* VNC with "" address and range */ + { .ipv4 =3D 1, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc-to/wildcard/all", + .args =3D "-vnc :3100,to=3D9005" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc-to/wildcard/ipv4", + .args =3D "-vnc :3100,to=3D9005,ipv4" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc-to/wildcard/ipv6", + .args =3D "-vnc :3100,to=3D9005,ipv6" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc-to/wildcard/ipv4on", + .args =3D "-vnc :3100,to=3D9005,ipv4=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc-to/wildcard/ipv6on", + .args =3D "-vnc :3100,to=3D9005,ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc-to/wildcard/ipv4off", + .args =3D "-vnc :3100,to=3D9005,ipv4=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc-to/wildcard/ipv6off", + .args =3D "-vnc :3100,to=3D9005,ipv6=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc-to/wildcard/ipv4onipv6off", + .args =3D "-vnc :3100,to=3D9005,ipv4=3Don,ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc-to/wildcard/ipv4offipv6on", + .args =3D "-vnc :3100,to=3D9005,ipv4=3Doff,ipv6=3Don" }, + { .ipv4 =3D 1, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc-to/wildcard/ipv4onipv6on", + .args =3D "-vnc :3100,to=3D9005,ipv4=3Don,ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc-to/wildcard/ipv4offipv6off", + .args =3D "-vnc :3100,to=3D9005,ipv4=3Doff,ipv6=3Doff" }, + + /* VNC with 0.0.0.0 address and range */ + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc-to/0.0.0.0/all", + .args =3D "-vnc 0.0.0.0:3100,to=3D9005" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc-to/0.0.0.0/ipv4", + .args =3D "-vnc 0.0.0.0:3100,to=3D9005,ipv4" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc-to/0.0.0.0/ipv6", + .args =3D "-vnc 0.0.0.0:3100,to=3D9005,ipv6" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc-to/0.0.0.0/ipv4on", + .args =3D "-vnc 0.0.0.0:3100,to=3D9005,ipv4=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc-to/0.0.0.0/ipv6on", + .args =3D "-vnc 0.0.0.0:3100,to=3D9005,ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc-to/0.0.0.0/ipv4off", + .args =3D "-vnc 0.0.0.0:3100,to=3D9005,ipv4=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc-to/0.0.0.0/ipv6off", + .args =3D "-vnc 0.0.0.0:3100,to=3D9005,ipv6=3Doff" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc-to/0.0.0.0/ipv4onipv6off", + .args =3D "-vnc 0.0.0.0:3100,to=3D9005,ipv4=3Don,ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc-to/0.0.0.0/ipv4offipv6on", + .args =3D "-vnc 0.0.0.0:3100,to=3D9005,ipv4=3Doff,ipv6=3Don" }, + { .ipv4 =3D 1, .ipv6 =3D 0, .error =3D 0, + .name =3D "/sockets/vnc-to/0.0.0.0/ipv4onipv6on", + .args =3D "-vnc 0.0.0.0:3100,to=3D9005,ipv4=3Don,ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc-to/0.0.0.0/ipv4offipv6off", + .args =3D "-vnc 0.0.0.0:3100,to=3D9005,ipv4=3Doff,ipv6=3Doff" }, + + /* VNC with :: address and range */ + { .ipv4 =3D 1, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc-to/::/all", + .args =3D "-vnc :::3100,to=3D9005" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc-to/::/ipv4", + .args =3D "-vnc :::3100,to=3D9005,ipv4" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc-to/::/ipv6", + .args =3D "-vnc :::3100,to=3D9005,ipv6" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc-to/::/ipv4on", + .args =3D "-vnc :::3100,to=3D9005,ipv4=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc-to/::/ipv6on", + .args =3D "-vnc :::3100,to=3D9005,ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc-to/::/ipv4off", + .args =3D "-vnc :::3100,to=3D9005,ipv4=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc-to/::/ipv6off", + .args =3D "-vnc :::3100,to=3D9005,ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc-to/::/ipv4onipv6off", + .args =3D "-vnc :::3100,to=3D9005,ipv4=3Don,ipv6=3Doff" }, + { .ipv4 =3D 0, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc-to/::/ipv4offipv6on", + .args =3D "-vnc :::3100,to=3D9005,ipv4=3Doff,ipv6=3Don" }, + { .ipv4 =3D 1, .ipv6 =3D 1, .error =3D 0, + .name =3D "/sockets/vnc-to/::/ipv4onipv6on", + .args =3D "-vnc :::3100,to=3D9005,ipv4=3Don,ipv6=3Don" }, + { .ipv4 =3D 0, .ipv6 =3D 0, .error =3D 1, + .name =3D "/sockets/vnc-to/::/ipv4offipv6off", + .args =3D "-vnc :::3100,to=3D9005,ipv4=3Doff,ipv6=3Doff" }, +}; + +static int check_bind(const char *hostname) +{ + int fd =3D -1; + struct addrinfo ai, *res =3D NULL; + int rc; + int ret =3D -1; + + memset(&ai, 0, sizeof(ai)); + ai.ai_flags =3D AI_CANONNAME | AI_ADDRCONFIG; + ai.ai_family =3D AF_UNSPEC; + ai.ai_socktype =3D SOCK_STREAM; + + /* lookup */ + rc =3D getaddrinfo(hostname, "9000", &ai, &res); + if (rc !=3D 0) { + goto cleanup; + } + + fd =3D qemu_socket(res->ai_family, res->ai_socktype, res->ai_protocol); + if (fd < 0) { + goto cleanup; + } + + if (bind(fd, res->ai_addr, res->ai_addrlen) < 0) { + goto cleanup; + } + + ret =3D 0; + + cleanup: + if (fd !=3D -1) { + close(fd); + } + if (res) { + freeaddrinfo(res); + } + return ret; +} + +static int check_protocol_support(void) +{ + if (check_bind("0.0.0.0") < 0) { + return -1; + } + if (check_bind("::") < 0) { + return -1; + } + + return 0; +} + +static pid_t run_qemu(const char *args) +{ + const char *pidfile =3D "test-sockets-proto.pid"; + char *pidstr; + pid_t child; + int status; + pid_t ret; + const char *binary =3D getenv("QTEST_QEMU_BINARY"); + long pid; + if (binary =3D=3D NULL) { + g_printerr("Missing QTEST_QEMU_BINARY env variable"); + } + g_assert(binary !=3D NULL); + + unlink(pidfile); + child =3D fork(); + if (child =3D=3D 0) { + setenv("QEMU_AUDIO_DRV", "none", true); + char *cmd =3D g_strdup_printf( + "exec %s -pidfile %s -daemonize -nodefconfig -nodefaults " + "-display none %s 1>/dev/null 2>&1", + binary, pidfile, args); + execlp("/bin/sh", "sh", "-c", cmd, NULL); + _exit(1); + } + + do { + ret =3D waitpid(child, &status, 0); + } while (ret =3D=3D -1 && errno =3D=3D EINTR); + + if (WEXITSTATUS(status) !=3D 0) { + return 0; + } + + if (!g_file_get_contents(pidfile, &pidstr, NULL, NULL)) { + return 0; + } + + qemu_strtol(pidstr, NULL, 0, &pid); + return (pid_t)pid; +} + +static void test_listen(const void *opaque) +{ + const QSocketsData *data =3D opaque; + QIOChannelSocket *sioc; + SocketAddress *saddr; + Error *err =3D NULL; + pid_t child; + + /* First test IPv4 */ + saddr =3D g_new(SocketAddress, 1); + saddr->type =3D SOCKET_ADDRESS_TYPE_INET; + saddr->u.inet.host =3D g_strdup("127.0.0.1"); + saddr->u.inet.port =3D g_strdup("9000"); + saddr->u.inet.has_ipv4 =3D true; + saddr->u.inet.ipv4 =3D true; + saddr->u.inet.has_ipv6 =3D true; + saddr->u.inet.ipv6 =3D false; + + child =3D run_qemu(data->args); + + if (!child) { + /* QEMU failed to start, so make sure we are expecting + * this scenario to fail + */ + g_assert(data->error); + goto cleanup; + } else { + g_assert(!data->error); + } + + sioc =3D qio_channel_socket_new(); + qio_channel_socket_connect_sync(sioc, saddr, &err); + + if (err !=3D NULL) { + /* We failed to connect to IPv4, make sure that + * matches the scenario expectation + */ + g_assert(data->ipv4 =3D=3D 0); + error_free(err); + err =3D NULL; + } else { + g_assert(data->ipv4 !=3D 0); + object_unref(OBJECT(sioc)); + } + + kill(child, SIGKILL); + + + /* Now test IPv6 */ + child =3D run_qemu(data->args); + + /* + * The child should always succeed, because its the + * same config as the succesful run we just did above + */ + g_assert(child !=3D 0); + + g_free(saddr->u.inet.host); + saddr->u.inet.host =3D g_strdup("::1"); + saddr->u.inet.ipv4 =3D false; + saddr->u.inet.ipv6 =3D true; + + sioc =3D qio_channel_socket_new(); + qio_channel_socket_connect_sync(sioc, saddr, &err); + + if (err !=3D NULL) { + /* We failed to connect to IPv6, make sure that + * matches the scenario expectation + */ + g_assert(data->ipv6 =3D=3D 0); + error_free(err); + err =3D NULL; + } else { + g_assert(data->ipv6 !=3D 0); + object_unref(OBJECT(sioc)); + } + kill(child, SIGKILL); + + cleanup: + qapi_free_SocketAddress(saddr); +} + + +int main(int argc, char **argv) +{ + int ret; + gsize i; + + if (check_protocol_support() < 0) { + return 0; /* Skip test if we can't bind */ + } + + signal(SIGPIPE, SIG_IGN); + + module_call_init(MODULE_INIT_QOM); + g_test_init(&argc, &argv, NULL); + + for (i =3D 0; i < G_N_ELEMENTS(test_data); i++) { + const QSocketsData *data =3D &test_data[i]; + g_test_add_data_func(data->name, data, test_listen); + } + + ret =3D g_test_run(); + + return ret =3D=3D 0 ? EXIT_SUCCESS : EXIT_FAILURE; +} --=20 2.9.3