From nobody Sun Apr 28 19:25:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1494840972727554.3787813920264; Mon, 15 May 2017 02:36:12 -0700 (PDT) Received: from localhost ([::1]:35651 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dACQF-00025r-7z for importer@patchew.org; Mon, 15 May 2017 05:36:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dACPB-0001Tl-FD for qemu-devel@nongnu.org; Mon, 15 May 2017 05:35:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dACP6-0001xS-JC for qemu-devel@nongnu.org; Mon, 15 May 2017 05:35:05 -0400 Received: from fanzine.igalia.com ([91.117.99.155]:47020) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dACP6-0001x3-7V; Mon, 15 May 2017 05:35:00 -0400 Received: from [194.100.51.2] (helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1dACP4-0000F6-6l; Mon, 15 May 2017 11:34:58 +0200 Received: from berto by perseus.local with local (Exim 4.89) (envelope-from ) id 1dACOm-0007Xl-Fn; Mon, 15 May 2017 12:34:40 +0300 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Message-Id:Date:Subject:Cc:To:From; bh=RltnbZW3dYkWlNWLInx9OmNObIuSay7yrPG6LkMXLoU=; b=mToS6MpmL2XbHFJJ8ijlDERKlC8jDqIYR2HyTDE1KxVzvp5fUuIqwz1f2lFf6HzmwPMAWZtf1SEfuWenwyl8U0JvLBogb8hVowMV2Ic/gxGSvTnaNoR4eBYmKVnhL1HuEtXiqnusCZPaxAGCn0rKX69xmEER6DKBYPgFyi3Sf39u738FP0Vn+l4TvMIeSvhI57v1fTWMQboiW3THjHix53ngIYfeLwwIehPWyvLTT5zn67SnZ+Lo0m12Ez0Ous9ejkW+qV9L30eaxYgwxbUZNjChc8VWNlXpnYLLcprampp8O91xebT6emCXZ2imQtBYLZcw3PEsioJAH/zRcuyKjQ==; From: Alberto Garcia To: qemu-devel@nongnu.org Date: Mon, 15 May 2017 12:34:24 +0300 Message-Id: <20170515093424.28954-1-berto@igalia.com> X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.117.99.155 Subject: [Qemu-devel] [PATCH] stream: fix crash in stream_start() when block_job_create() fails X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The code that tries to reopen a BlockDriverState in stream_start() when the creation of a new block job fails crashes because it attempts to dereference a pointer that is known to be NULL. This is a regression introduced in a170a91fd3eab6155da39e740381867e, likely because the code was copied from stream_complete(). Signed-off-by: Alberto Garcia Tested-by: Kashyap Chamarthy --- block/stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/stream.c b/block/stream.c index 0113710845..52d329f5c6 100644 --- a/block/stream.c +++ b/block/stream.c @@ -280,6 +280,6 @@ void stream_start(const char *job_id, BlockDriverState = *bs, =20 fail: if (orig_bs_flags !=3D bdrv_get_flags(bs)) { - bdrv_reopen(bs, s->bs_flags, NULL); + bdrv_reopen(bs, orig_bs_flags, NULL); } } --=20 2.11.0