From nobody Sun May 19 01:26:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149400145361873.42536816069912; Fri, 5 May 2017 09:24:13 -0700 (PDT) Received: from localhost ([::1]:48051 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6g1Y-0004Js-RJ for importer@patchew.org; Fri, 05 May 2017 12:24:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57706) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6g0n-0003pM-2O for qemu-devel@nongnu.org; Fri, 05 May 2017 12:23:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6g0j-0008K5-Td for qemu-devel@nongnu.org; Fri, 05 May 2017 12:23:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36464) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d6g0j-0008Iz-KH for qemu-devel@nongnu.org; Fri, 05 May 2017 12:23:17 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 30AB061D11; Fri, 5 May 2017 16:23:16 +0000 (UTC) Received: from t460.redhat.com (ovpn-117-5.ams2.redhat.com [10.36.117.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id AE4A881881; Fri, 5 May 2017 16:23:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 30AB061D11 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=berrange@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 30AB061D11 From: "Daniel P. Berrange" To: qemu-devel@nongnu.org Date: Fri, 5 May 2017 17:23:05 +0100 Message-Id: <20170505162305.15763-1-berrange@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 05 May 2017 16:23:16 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] Revert "Change net/socket.c to use socket_*() functions" again X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Stefan Hajnoczi , Ashijeet Acharya , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This reverts commit 883e4f7624e10b98d16d9adaffb8b1795664d899. This code changed net/socket.c from using socket()+connect(), to using socket_connect(). In theory this is great, but in practice this has completely broken the ability to connect the frontend and backend: $ ./x86_64-softmmu/qemu-system-x86_64 \ -device e1000,id=3De0,netdev=3Dhn0,mac=3DDE:AD:BE:EF:AF:05 \ -netdev socket,id=3Dhn0,connect=3Dlocalhost:1234 qemu-system-x86_64: -device e1000,id=3De0,netdev=3Dhn0,mac=3DDE:AD:BE:EF:= AF:05: Property 'e1000.netdev' can't find value 'hn0' The old code would call net_socket_fd_init() synchronously, while letting the connect() complete in the backgorund. The new code moved net_socket_fd_init() so that it is only called after connect() completes in the background. Thus at the time we initialize the NIC frontend, the backend does not exist. The socket_connect() conversion as done is a bad fit for the current code, since it did not try to change the way it deals with async connection completion. Rather than try to fix this, just revert the socket_connect() conversion entirely. The code is about to be converted to use QIOChannel which will let the problem be solved in a cleaner manner. This revert is more suitable for stable branches in the meantime. Signed-off-by: Daniel P. Berrange Acked-by: Jason Wang Reviewed-by: Stefan Hajnoczi --- net/socket.c | 127 ++++++++++++++++++++++++++-----------------------------= ---- 1 file changed, 56 insertions(+), 71 deletions(-) diff --git a/net/socket.c b/net/socket.c index b8c931e..dcae1ae 100644 --- a/net/socket.c +++ b/net/socket.c @@ -489,106 +489,91 @@ static int net_socket_listen_init(NetClientState *pe= er, { NetClientState *nc; NetSocketState *s; - SocketAddress *saddr; - int ret; - Error *local_error =3D NULL; + struct sockaddr_in saddr; + int fd, ret; =20 - saddr =3D socket_parse(host_str, &local_error); - if (saddr =3D=3D NULL) { - error_report_err(local_error); + if (parse_host_port(&saddr, host_str) < 0) + return -1; + + fd =3D qemu_socket(PF_INET, SOCK_STREAM, 0); + if (fd < 0) { + perror("socket"); return -1; } + qemu_set_nonblock(fd); + + socket_set_fast_reuse(fd); =20 - ret =3D socket_listen(saddr, &local_error); + ret =3D bind(fd, (struct sockaddr *)&saddr, sizeof(saddr)); if (ret < 0) { - qapi_free_SocketAddress(saddr); - error_report_err(local_error); + perror("bind"); + closesocket(fd); + return -1; + } + ret =3D listen(fd, 0); + if (ret < 0) { + perror("listen"); + closesocket(fd); return -1; } =20 nc =3D qemu_new_net_client(&net_socket_info, peer, model, name); s =3D DO_UPCAST(NetSocketState, nc, nc); s->fd =3D -1; - s->listen_fd =3D ret; + s->listen_fd =3D fd; s->nc.link_down =3D true; net_socket_rs_init(&s->rs, net_socket_rs_finalize); =20 qemu_set_fd_handler(s->listen_fd, net_socket_accept, NULL, s); - qapi_free_SocketAddress(saddr); return 0; } =20 -typedef struct { - NetClientState *peer; - SocketAddress *saddr; - char *model; - char *name; -} socket_connect_data; - -static void socket_connect_data_free(socket_connect_data *c) -{ - qapi_free_SocketAddress(c->saddr); - g_free(c->model); - g_free(c->name); - g_free(c); -} - -static void net_socket_connected(int fd, Error *err, void *opaque) -{ - socket_connect_data *c =3D opaque; - NetSocketState *s; - char *addr_str =3D NULL; - Error *local_error =3D NULL; - - addr_str =3D socket_address_to_string(c->saddr, &local_error); - if (addr_str =3D=3D NULL) { - error_report_err(local_error); - closesocket(fd); - goto end; - } - - s =3D net_socket_fd_init(c->peer, c->model, c->name, fd, true); - if (!s) { - closesocket(fd); - goto end; - } - - snprintf(s->nc.info_str, sizeof(s->nc.info_str), - "socket: connect to %s", addr_str); - -end: - g_free(addr_str); - socket_connect_data_free(c); -} - static int net_socket_connect_init(NetClientState *peer, const char *model, const char *name, const char *host_str) { - socket_connect_data *c =3D g_new0(socket_connect_data, 1); - int fd =3D -1; - Error *local_error =3D NULL; + NetSocketState *s; + int fd, connected, ret; + struct sockaddr_in saddr; =20 - c->peer =3D peer; - c->model =3D g_strdup(model); - c->name =3D g_strdup(name); - c->saddr =3D socket_parse(host_str, &local_error); - if (c->saddr =3D=3D NULL) { - goto err; - } + if (parse_host_port(&saddr, host_str) < 0) + return -1; =20 - fd =3D socket_connect(c->saddr, net_socket_connected, c, &local_error); + fd =3D qemu_socket(PF_INET, SOCK_STREAM, 0); if (fd < 0) { - goto err; + perror("socket"); + return -1; } + qemu_set_nonblock(fd); =20 + connected =3D 0; + for(;;) { + ret =3D connect(fd, (struct sockaddr *)&saddr, sizeof(saddr)); + if (ret < 0) { + if (errno =3D=3D EINTR || errno =3D=3D EWOULDBLOCK) { + /* continue */ + } else if (errno =3D=3D EINPROGRESS || + errno =3D=3D EALREADY || + errno =3D=3D EINVAL) { + break; + } else { + perror("connect"); + closesocket(fd); + return -1; + } + } else { + connected =3D 1; + break; + } + } + s =3D net_socket_fd_init(peer, model, name, fd, connected); + if (!s) + return -1; + snprintf(s->nc.info_str, sizeof(s->nc.info_str), + "socket: connect to %s:%d", + inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); return 0; - -err: - error_report_err(local_error); - socket_connect_data_free(c); - return -1; } =20 static int net_socket_mcast_init(NetClientState *peer, --=20 2.9.3