From nobody Fri Dec 19 20:11:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1493753388383682.3266507675885; Tue, 2 May 2017 12:29:48 -0700 (PDT) Received: from localhost ([::1]:33312 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5dUY-0007Nb-3X for importer@patchew.org; Tue, 02 May 2017 15:29:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5dOI-0001kf-OU for qemu-devel@nongnu.org; Tue, 02 May 2017 15:23:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5dOH-0001bJ-Tl for qemu-devel@nongnu.org; Tue, 02 May 2017 15:23:18 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:32974) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d5dOH-0001ay-Ow for qemu-devel@nongnu.org; Tue, 02 May 2017 15:23:17 -0400 Received: by mail-qk0-x244.google.com with SMTP id o85so22940662qkh.0 for ; Tue, 02 May 2017 12:23:17 -0700 (PDT) Received: from bigtime.twiddle.net.com ([2602:47:d954:1500:5e51:4fff:fe40:9c64]) by smtp.gmail.com with ESMTPSA id d65sm10664657qkc.53.2017.05.02.12.23.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 May 2017 12:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=A4MgwEOeX4xKUWBJTE5PamsNzrZJ4Ns/0VBFdKYA+hE=; b=l2GW88ZrpVlNl0JJE/9kVJAnAHz61Xib5buTi224A7XFgRCWWUXaMkNDmJij5OZImn Ebv7wi+gJ2zsG4mC7bSAh/9fHPtsiHRmNFQsHwvQDWmMg2kC6Eu9FnyQVT+4FWzNFiv5 E1c/bKKdEo+FVK1CLCy1DdCX+21hkrH8p/42kwEHuXNPWGHrhkQ5BUEz+vEec6sf9ISu zrsGH0LughphCx9VOSl0bvKE4iZzfn053zImaTM2FR7FfFIxzthnyWmM+ULrxIofG1LZ dZh3PBa9TPIxNjArVJFq1XGEX2cWtL3NSS2KzBMUHDPnD9/JLsAvUUeUEAaDxX1F1cX7 852A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=A4MgwEOeX4xKUWBJTE5PamsNzrZJ4Ns/0VBFdKYA+hE=; b=JWwE1Izk5cblL8ysIlA/+/13/bg0HIpJznDYPezjmViWlIi7QA0v5aCq5KEWDf9myu 4zYkeMZTZOVyV3ww9Moqd8WKKhBt6yqzWvZ4XlDKJCmSmmwxX0eoji2AS195pGtg5oCZ L5HM0i9gI2dgf0cetagu/gY3Od21Pry25D4a63n7qnA/4Z+Fzb5J6MAMaM5dKQKfDJ0t 3URhDEBUGt93DUGMic/5/Q1dKc3Mdkgyfj7pCi4czf/frLMCX81kScLy7nnMHY0kHiYZ sj39iJEhHyI7mjOmZde9rtSBKEXrm+ZqLqihA9plu+UHXpB6bjkXLUnMy1mp/2avvtgR wX+Q== X-Gm-Message-State: AN3rC/79QlvSg5s41Coo0SW0+ZbDGMOGTwP8Lx6ejei0ODUCaPHMzWyI Wm9kVeULeyxVyg== X-Received: by 10.55.176.135 with SMTP id z129mr26815885qke.308.1493752997411; Tue, 02 May 2017 12:23:17 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 2 May 2017 12:22:44 -0700 Message-Id: <20170502192300.2124-10-rth@twiddle.net> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170502192300.2124-1-rth@twiddle.net> References: <20170502192300.2124-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH v6 09/25] target/i386: optimize cross-page direct jumps in softmmu X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cota@braap.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Emilio G. Cota" Instead of unconditionally exiting to the exec loop, use the gen_jr helper to jump to the target if it is valid. Perf impact: see next commit's log. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Message-Id: <1493263764-18657-10-git-send-email-cota@braap.org> Signed-off-by: Richard Henderson --- target/i386/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index f0e48dc..ea113fe 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -2154,9 +2154,9 @@ static inline void gen_goto_tb(DisasContext *s, int t= b_num, target_ulong eip) gen_jmp_im(eip); tcg_gen_exit_tb((uintptr_t)s->tb + tb_num); } else { - /* jump to another page: currently not optimized */ + /* jump to another page */ gen_jmp_im(eip); - gen_eob(s); + gen_jr(s, cpu_tmp0); } } =20 --=20 2.9.3