From nobody Mon Feb 9 12:15:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1493294688758630.8479322835692; Thu, 27 Apr 2017 05:04:48 -0700 (PDT) Received: from localhost ([::1]:60224 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3iAA-0007Wm-AK for importer@patchew.org; Thu, 27 Apr 2017 08:04:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3i61-000414-3I for qemu-devel@nongnu.org; Thu, 27 Apr 2017 08:00:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d3i60-0001WL-CM for qemu-devel@nongnu.org; Thu, 27 Apr 2017 08:00:29 -0400 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]:35505) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d3i60-0001VW-5t for qemu-devel@nongnu.org; Thu, 27 Apr 2017 08:00:28 -0400 Received: by mail-wr0-x244.google.com with SMTP id g12so3523217wrg.2 for ; Thu, 27 Apr 2017 05:00:27 -0700 (PDT) Received: from bigtime.twiddle.net.com (251.red-80-29-7.adsl.static.ccgg.telefonica.net. [80.29.7.251]) by smtp.gmail.com with ESMTPSA id i199sm3056470wmf.33.2017.04.27.05.00.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Apr 2017 05:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=A4MgwEOeX4xKUWBJTE5PamsNzrZJ4Ns/0VBFdKYA+hE=; b=KfrbowanULw7P5vkFIdQcJVKSIXGWXLdvdDFxuwddnR4KmgEvmP8ZHCJaYplDuxzje Eo+q8eMU1WbZdlTr8/rxnZUuYduQlHaNUNdeDzMvh99LuwMfMyil0SrXK3vZivHZdIEh bUOhp/1gMvEKRWVPtfpdw58vOe//vzc59icFkZWhIWdGAoChyeIkZ60lshl4eNy8v1ad C6y7LxuPjVxlmMxKYu7NIboRRdsZAKJAHsds2WM01eWEmzGSaGVtKXSWV39SRnYN8IXt BD6EVO6xSdbkt4+6rAprXEHCTuKUs/yHu5Hgaagkj1tLffMsD8UqNL5d30Dy2ugm4/A3 vIBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=A4MgwEOeX4xKUWBJTE5PamsNzrZJ4Ns/0VBFdKYA+hE=; b=B1GmzsEqAZtaIeaX0pJqg1EOcWuVL2F0HrLy2jGmDisjT7Rm+ezclzsdRyXJCxt8Ne wfT0BpZHazbV/156A2rLXPNa0LkaySUXiWejG/RBQpTnq+shMR8BToVq8JHIG+wsDD/3 5ewikI53hBw7KW50ilnWU/le0zx4ym2Hh5SCXoSCJ0IdtHXlBhaJb7T8pjz7hw5xk5t/ Dp7atDUxl+cCtA0n0TW5sbQSxvvlm+agJToBs4jNzHKYGuuZuc5HaxkxY9DBoebgpCWP +Fi5uDeUPQreCKtZIn5ZmyLR6rsgoTGp0C8nMAa8JhZ/23cjMnvCKiwBQLS0kEyZzpmM 4OXA== X-Gm-Message-State: AN3rC/4XDLkMDVy5375ZNwMr48fgKXyerI0khy9h6Axa81dFZoS+T8hr 1rjtKGv6DztEqfSsu5U= X-Received: by 10.223.133.97 with SMTP id 88mr3398440wrh.166.1493294426845; Thu, 27 Apr 2017 05:00:26 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 27 Apr 2017 13:59:58 +0200 Message-Id: <20170427120006.20564-12-rth@twiddle.net> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170427120006.20564-1-rth@twiddle.net> References: <20170427120006.20564-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::244 Subject: [Qemu-devel] [PATCH v5 11/19] target/i386: optimize cross-page direct jumps in softmmu X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cota@braap.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Emilio G. Cota" Instead of unconditionally exiting to the exec loop, use the gen_jr helper to jump to the target if it is valid. Perf impact: see next commit's log. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Message-Id: <1493263764-18657-10-git-send-email-cota@braap.org> Signed-off-by: Richard Henderson --- target/i386/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/translate.c b/target/i386/translate.c index f0e48dc..ea113fe 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -2154,9 +2154,9 @@ static inline void gen_goto_tb(DisasContext *s, int t= b_num, target_ulong eip) gen_jmp_im(eip); tcg_gen_exit_tb((uintptr_t)s->tb + tb_num); } else { - /* jump to another page: currently not optimized */ + /* jump to another page */ gen_jmp_im(eip); - gen_eob(s); + gen_jr(s, cpu_tmp0); } } =20 --=20 2.9.3