From nobody Sat May 4 10:55:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149322793357981.00882170708098; Wed, 26 Apr 2017 10:32:13 -0700 (PDT) Received: from localhost ([::1]:56393 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3QnS-0002o9-SE for importer@patchew.org; Wed, 26 Apr 2017 13:32:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3QmG-0002FP-Co for qemu-devel@nongnu.org; Wed, 26 Apr 2017 13:30:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d3QmD-0000eX-4l for qemu-devel@nongnu.org; Wed, 26 Apr 2017 13:30:56 -0400 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:35864) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d3QmC-0000eM-Uu for qemu-devel@nongnu.org; Wed, 26 Apr 2017 13:30:53 -0400 Received: by mail-wr0-x241.google.com with SMTP id v42so939556wrc.3 for ; Wed, 26 Apr 2017 10:30:52 -0700 (PDT) Received: from bigtime.twiddle.net.com (251.red-80-29-7.adsl.static.ccgg.telefonica.net. [80.29.7.251]) by smtp.gmail.com with ESMTPSA id b188sm209174wmh.6.2017.04.26.10.30.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Apr 2017 10:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=kbDhKSQ5jWbXK+cVXQP+giKpCG+UfDYJH/PeIprrXhw=; b=ki0ntHwPcy4wzlmxRhnEPi7+dMCHbmqbC9M5WpFVWhXiZvNKOxHJgXReIpjkHSgCes w/JeZxLvkrHF3J+jRAT9xbbeaIKWO95qUnbbMo4zLGOPG362LCWmqkmnOmNXXLFDBO8d ScLqx74iyJpeOvFD9tP/2WKQU6TQAZwjH1kD/UvLfYRG7zXjvWMsqmd/sLggwG2yRA3N Vf/legOv+VOYYNPJgKGuAeOy2lTRJQQHlErCLgchvsQZrT6rkX1WClydujtCtOEWVfK0 ec7kAFSS/tvtjxprMdQdqSl53aOX3Y8hxTLj7kK2mp0a0bnhVYnCaMkBJJ86OjOpiuMa umXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=kbDhKSQ5jWbXK+cVXQP+giKpCG+UfDYJH/PeIprrXhw=; b=EixL9U8G3AjpPchZUpL0+RyP8fMvb8Ew40xR4NOM2cIR7Cyu2rvpZPIM8AGfOpuRfq 0OaQjmFkAnKuhcf6iY2+kdvulD83xuvPlPDKf9JmT6QgCuLTvn53Bycle6i3AEd4urfn vouVqJ5WdEfetPSzKDERaiUfZJ7Ytenfd3Z3lkEbugDeV4R0XJ+hxstzoDM0usodd7Sd uXfqiArZTqPMcb0P0t+z7yCSWmDZC93jICBs+XLrZgAN6LvMPbclijg9roFskhNVFaqN JY0PPt9pqgYAEeAztqAg2WZS2G/ln8OdBHdGTO2ZHH6o6JqgejbOxCQUwivT1Uwu5Qu1 IXpg== X-Gm-Message-State: AN3rC/6hO/qj68LkP1hhJ9HxOEtZgD+XTkjVE/CJewCM+VnlaVFz+1XW yaYxXIViu9eLAg== X-Received: by 10.223.161.65 with SMTP id r1mr737264wrr.114.1493227851847; Wed, 26 Apr 2017 10:30:51 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 26 Apr 2017 19:30:44 +0200 Message-Id: <20170426173044.32525-2-rth@twiddle.net> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170426173044.32525-1-rth@twiddle.net> References: <20170426173044.32525-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::241 Subject: [Qemu-devel] [PULL] tcg: Initialize return value after exit_atomic X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, stefanha@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Users of tcg_gen_atomic_cmpxchg and do_atomic_op rightfully utilize the output. Even though this code is dead, it gets translated, and without the initialization we encounter a tcg_error. Reported-by: Nikunj A Dadhania Tested-by: Nikunj A Dadhania Tested-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index 95a39b7..6b1f415 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -2861,6 +2861,9 @@ void tcg_gen_atomic_cmpxchg_i64(TCGv_i64 retv, TCGv a= ddr, TCGv_i64 cmpv, #endif #else gen_helper_exit_atomic(tcg_ctx.tcg_env); + /* Produce a result, so that we have a well-formed opcode stream + with respect to uses of the result in the (dead) code following= . */ + tcg_gen_movi_i64(retv, 0); #endif /* CONFIG_ATOMIC64 */ } else { TCGv_i32 c32 =3D tcg_temp_new_i32(); @@ -2966,6 +2969,9 @@ static void do_atomic_op_i64(TCGv_i64 ret, TCGv addr,= TCGv_i64 val, #endif #else gen_helper_exit_atomic(tcg_ctx.tcg_env); + /* Produce a result, so that we have a well-formed opcode stream + with respect to uses of the result in the (dead) code following= . */ + tcg_gen_movi_i64(ret, 0); #endif /* CONFIG_ATOMIC64 */ } else { TCGv_i32 v32 =3D tcg_temp_new_i32(); --=20 2.9.3