From nobody Wed Apr 16 07:44:33 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1492767900194468.3094149584773; Fri, 21 Apr 2017 02:45:00 -0700 (PDT) Received: from localhost ([::1]:58239 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1V7a-0000OZ-Nf for importer@patchew.org; Fri, 21 Apr 2017 05:44:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1V6C-0007wi-A9 for qemu-devel@nongnu.org; Fri, 21 Apr 2017 05:43:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d1V6B-0000W5-Ak for qemu-devel@nongnu.org; Fri, 21 Apr 2017 05:43:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58042) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d1V6B-0000W1-4Z for qemu-devel@nongnu.org; Fri, 21 Apr 2017 05:43:31 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1212116F8A3; Fri, 21 Apr 2017 09:43:30 +0000 (UTC) Received: from localhost (ovpn-116-83.ams2.redhat.com [10.36.116.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8A6C27FBD9; Fri, 21 Apr 2017 09:43:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1212116F8A3 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=stefanha@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1212116F8A3 From: Stefan Hajnoczi To: Date: Fri, 21 Apr 2017 10:43:12 +0100 Message-Id: <20170421094316.19361-3-stefanha@redhat.com> In-Reply-To: <20170421094316.19361-1-stefanha@redhat.com> References: <20170421094316.19361-1-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 21 Apr 2017 09:43:30 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL for-2.9 2/6] throttle: do not use invalid config in test X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The (burst) max parameter cannot be smaller than the avg parameter. There is a test case that uses avg =3D 56, max =3D 1 and gets away with it because no input validation is performed by the test case. This patch switches to valid test input parameters. Signed-off-by: Stefan Hajnoczi Reviewed-by: Alberto Garcia Message-id: 20170301115026.22621-3-stefanha@redhat.com Signed-off-by: Stefan Hajnoczi --- tests/test-throttle.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/test-throttle.c b/tests/test-throttle.c index bd7c501..089e937 100644 --- a/tests/test-throttle.c +++ b/tests/test-throttle.c @@ -205,8 +205,8 @@ static void test_config_functions(void) orig_cfg.buckets[THROTTLE_OPS_READ].avg =3D 69; orig_cfg.buckets[THROTTLE_OPS_WRITE].avg =3D 23; =20 - orig_cfg.buckets[THROTTLE_BPS_TOTAL].max =3D 0; /* should be corrected= */ - orig_cfg.buckets[THROTTLE_BPS_READ].max =3D 1; /* should not be corre= cted */ + orig_cfg.buckets[THROTTLE_BPS_TOTAL].max =3D 0; /* should be correcte= d */ + orig_cfg.buckets[THROTTLE_BPS_READ].max =3D 56; /* should not be corr= ected */ orig_cfg.buckets[THROTTLE_BPS_WRITE].max =3D 120; =20 orig_cfg.buckets[THROTTLE_OPS_TOTAL].max =3D 150; @@ -246,8 +246,8 @@ static void test_config_functions(void) g_assert(final_cfg.buckets[THROTTLE_OPS_READ].avg =3D=3D 69); g_assert(final_cfg.buckets[THROTTLE_OPS_WRITE].avg =3D=3D 23); =20 - g_assert(final_cfg.buckets[THROTTLE_BPS_TOTAL].max =3D=3D 15.3);/* fix= ed */ - g_assert(final_cfg.buckets[THROTTLE_BPS_READ].max =3D=3D 1); /* not= fixed */ + g_assert(final_cfg.buckets[THROTTLE_BPS_TOTAL].max =3D=3D 15.3); /* fi= xed */ + g_assert(final_cfg.buckets[THROTTLE_BPS_READ].max =3D=3D 56); /* no= t fixed */ g_assert(final_cfg.buckets[THROTTLE_BPS_WRITE].max =3D=3D 120); =20 g_assert(final_cfg.buckets[THROTTLE_OPS_TOTAL].max =3D=3D 150); --=20 2.9.3