From nobody Thu May 2 15:03:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1492599279822123.12906525979383; Wed, 19 Apr 2017 03:54:39 -0700 (PDT) Received: from localhost ([::1]:47105 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0nFs-0003Ql-MZ for importer@patchew.org; Wed, 19 Apr 2017 06:54:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0nER-0002WW-92 for qemu-devel@nongnu.org; Wed, 19 Apr 2017 06:53:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0nEN-00027T-Nw for qemu-devel@nongnu.org; Wed, 19 Apr 2017 06:53:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51946) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d0nEN-00026z-F0 for qemu-devel@nongnu.org; Wed, 19 Apr 2017 06:53:03 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 59FAF65CFA; Wed, 19 Apr 2017 10:53:02 +0000 (UTC) Received: from evilvm.brq.redhat.com (unknown [10.34.130.252]) by smtp.corp.redhat.com (Postfix) with ESMTP id 37D4A8F7F6; Wed, 19 Apr 2017 10:53:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 59FAF65CFA Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vfeenstr@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 59FAF65CFA From: Vinzenz 'evilissimo' Feenstra To: qemu-devel@nongnu.org Date: Wed, 19 Apr 2017 12:52:58 +0200 Message-Id: <20170419105258.4488-2-vfeenstr@redhat.com> In-Reply-To: <20170419105258.4488-1-vfeenstr@redhat.com> References: <20170419105258.4488-1-vfeenstr@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 19 Apr 2017 10:53:02 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v6 1/1] qga: Add `guest-get-timezone` command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sameeh@daynix.com, marcandre.lureau@gmail.com, mdroth@linux.vnet.ibm.com, Vinzenz Feenstra Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Vinzenz Feenstra Adds a new command `guest-get-timezone` reporting the currently configured timezone on the system. The information on what timezone is currently is configured is useful in case of Windows VMs where the offset of the hardware clock is required to have the same offset. This can be used for management systems like `oVirt` to detect the timezone difference and warn administrators of the misconfiguration. Signed-off-by: Vinzenz Feenstra --- qga/commands.c | 38 ++++++++++++++++++++++++++++++++++++++ qga/qapi-schema.json | 26 ++++++++++++++++++++++++++ 2 files changed, 64 insertions(+) diff --git a/qga/commands.c b/qga/commands.c index 4d92946..999538d 100644 --- a/qga/commands.c +++ b/qga/commands.c @@ -499,3 +499,41 @@ int ga_parse_whence(GuestFileWhence *whence, Error **e= rrp) error_setg(errp, "invalid whence code %"PRId64, whence->u.value); return -1; } + +GuestTimezone *qmp_guest_get_timezone(Error **errp) +{ +#if !GLIB_CHECK_VERSION(2, 28, 0) + error_setg(errp, QERR_UNSUPPORTED); + return NULL; +#else + GuestTimezone *info =3D NULL; + GTimeZone *tz =3D NULL; + gint64 now =3D 0; + gint32 intv =3D 0; + gchar const *name =3D NULL; + + info =3D g_new0(GuestTimezone, 1); + tz =3D g_time_zone_new_local(); + if (tz =3D=3D NULL) { + error_setg(errp, QERR_QGA_COMMAND_FAILED, + "Couldn't retrieve local timezone"); + goto error; + } + + now =3D g_get_real_time() / G_USEC_PER_SEC; + intv =3D g_time_zone_find_interval(tz, G_TIME_TYPE_UNIVERSAL, now); + info->offset =3D g_time_zone_get_offset(tz, intv); + name =3D g_time_zone_get_abbreviation(tz, intv); + if (name !=3D NULL) { + info->has_zone =3D true; + info->zone =3D g_strdup(name); + } + g_time_zone_unref(tz); + + return info; + +error: + g_free(info); + return NULL; +#endif +} diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index a02dbf2..5183ea2 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -1042,3 +1042,29 @@ 'data': { 'path': 'str', '*arg': ['str'], '*env': ['str'], '*input-data': 'str', '*capture-output': 'bool' }, 'returns': 'GuestExec' } + + +## +# @GuestTimezone: +# +# @zone: Timezone name +# @offset: Offset to UTC in seconds, negative numbers for time zones west= of +# GMT, positive numbers for east +# +# Since: 2.10 +## +{ 'struct': 'GuestTimezone', + 'data': { '*zone': 'str', 'offset': 'int' } } + + +## +# @guest-get-timezone: +# +# Retrieves the timezone information from the guest. +# +# Returns: A GuestTimezone dictionary. +# +# Since: 2.10 +## +{ 'command': 'guest-get-timezone', + 'returns': 'GuestTimezone' } --=20 2.9.3