From nobody Mon Feb 9 16:51:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1492553961334377.23365875995046; Tue, 18 Apr 2017 15:19:21 -0700 (PDT) Received: from localhost ([::1]:44866 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0bSx-0001ZI-Ra for importer@patchew.org; Tue, 18 Apr 2017 18:19:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0bRK-0000d4-Lh for qemu-devel@nongnu.org; Tue, 18 Apr 2017 18:17:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0bRJ-0002Qm-SZ for qemu-devel@nongnu.org; Tue, 18 Apr 2017 18:17:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46146) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d0bRJ-0002QQ-MX for qemu-devel@nongnu.org; Tue, 18 Apr 2017 18:17:37 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B499D3D95F; Tue, 18 Apr 2017 22:17:36 +0000 (UTC) Received: from localhost (ovpn-116-28.gru2.redhat.com [10.97.116.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 79B5E17B92; Tue, 18 Apr 2017 22:17:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B499D3D95F Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B499D3D95F From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Tue, 18 Apr 2017 19:17:19 -0300 Message-Id: <20170418221724.5707-2-ehabkost@redhat.com> In-Reply-To: <20170418221724.5707-1-ehabkost@redhat.com> References: <20170418221724.5707-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 18 Apr 2017 22:17:36 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC v2 1/6] pci: Inline pci_host_bus_register() inside pci_bus_init() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aik@ozlabs.ru, David Gibson , Laszlo Ersek , Marcel Apfelbaum , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" There's no need for a separate function just to append an item to pci_host_bridges. Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Signed-off-by: Eduardo Habkost Reviewed-by: David Gibson Reviewed-by: Marcel Apfelbaum --- hw/pci/pci.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 259483b1c0..328f36cd21 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -312,13 +312,6 @@ static void pcibus_reset(BusState *qbus) } } =20 -static void pci_host_bus_register(DeviceState *host) -{ - PCIHostState *host_bridge =3D PCI_HOST_BRIDGE(host); - - QLIST_INSERT_HEAD(&pci_host_bridges, host_bridge, next); -} - PCIBus *pci_find_primary_bus(void) { PCIBus *primary_bus =3D NULL; @@ -369,6 +362,8 @@ static void pci_bus_init(PCIBus *bus, DeviceState *pare= nt, MemoryRegion *address_space_io, uint8_t devfn_min) { + PCIHostState *phb =3D PCI_HOST_BRIDGE(parent); + assert(PCI_FUNC(devfn_min) =3D=3D 0); bus->devfn_min =3D devfn_min; bus->address_space_mem =3D address_space_mem; @@ -377,7 +372,7 @@ static void pci_bus_init(PCIBus *bus, DeviceState *pare= nt, /* host bridge */ QLIST_INIT(&bus->child); =20 - pci_host_bus_register(parent); + QLIST_INSERT_HEAD(&pci_host_bridges, phb, next); } =20 bool pci_bus_is_express(PCIBus *bus) --=20 2.11.0.259.g40922b1