From nobody Sun Apr 28 22:56:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491915190798490.19651323347284; Tue, 11 Apr 2017 05:53:10 -0700 (PDT) Received: from localhost ([::1]:39123 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cxvID-0000Z3-5g for importer@patchew.org; Tue, 11 Apr 2017 08:53:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cxvHL-0000G8-GE for qemu-devel@nongnu.org; Tue, 11 Apr 2017 08:52:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cxvHI-0005rl-FH for qemu-devel@nongnu.org; Tue, 11 Apr 2017 08:52:15 -0400 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:34292) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cxvHI-0005rJ-6z for qemu-devel@nongnu.org; Tue, 11 Apr 2017 08:52:12 -0400 Received: by mail-wr0-x241.google.com with SMTP id u18so25040431wrc.1 for ; Tue, 11 Apr 2017 05:52:11 -0700 (PDT) Received: from bark.daynix ([141.226.163.173]) by smtp.gmail.com with ESMTPSA id h3sm21367616wrb.43.2017.04.11.05.52.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Apr 2017 05:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=tGrlHF9TZLN+PyFPItamfjMDn2apC24F+y7MBdhHiow=; b=zhq9WkhZFQCL3XKEG4+R4AyPjWFmYKZGgiYdneWwM7frKgC9ZaiyEJnIYRC8V45/pQ hkNmaAWGEa9rZw7/6PHc7KEG7ecTDvqXAkFWJGt+1NaN8mK1jAef5IYPqOPoDKUlCROw D13ESttJ/dTxQfTdNft96AQaPvtrfmP3N/JGxZP+YkHfVoc42zds+FOAFffTZ8GJkMn0 L6+8od1pDaAXGASbRy6oh4/FZU3ro7BZWyThiyBJD27OTfK1teUmmKX5vOAE1QIaUVfj DcR1kiv6uT7HI0nnJHZ05LZtdRVs+IXmQRLNCUcRpBv1GUDvZhfkdPlRFkBJCtuJ00kZ 01bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tGrlHF9TZLN+PyFPItamfjMDn2apC24F+y7MBdhHiow=; b=LNYqQQYzzb8Pj/LqsWjOmeyndWxHU5n6HROVPDNlSaTyJQWWbsDbNl+qFEvLldMsfU nVJxRaWFOG2cPfcVGflmm7lewku+vrNBJJUs9VaCJHX4lJ71AIHsHAkLPdFny4MAhLkn L9XQ7ZA7whRta6RBDUWddEQl8eRJowlaTwzZ0uDS7557JMZSSYIVEFm2PkcyvuhJ+sLB Jm3LnAdHW6D9dQrsnoD797uwa94OHnnPJASARBjN9W4rbSDAUfqLC+ICW3BKSf2KSg5I IdIPfsZ5y7fPyIa/i7TSBl+P8W4bzWh/IuHmKLUoxI0afCQinOcPvFWzE7XJoWap7IJt NUtA== X-Gm-Message-State: AN3rC/4IAzub8R/mk6v+w9VX/oqqBg9DvA3dQIqo1vvTHubhNEoK3pcoxLs35P8dCEeW/w== X-Received: by 10.223.135.84 with SMTP id 20mr9926419wrz.199.1491915130720; Tue, 11 Apr 2017 05:52:10 -0700 (PDT) From: Sameeh Jubran To: qemu-devel@nongnu.org, Michael Roth Date: Tue, 11 Apr 2017 15:52:05 +0300 Message-Id: <20170411125205.23121-1-sameeh@daynix.com> X-Mailer: git-send-email 2.9.3 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::241 Subject: [Qemu-devel] [PATCH] qga-win: Enable 'can-offline' field in 'guest-get-vcpus' reply X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Vugenfirer Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The QGA schema states: @can-offline: Whether offlining the VCPU is possible. This member is always filled in by the guest agent when the structure is returned, and always ignored on input (hence it can be omitted then). Currently 'can-offline' is missing entirely from the reply. This causes errors in libvirt which is expecting the reply to be compliant with the schema docs. BZ#1438735: https://bugzilla.redhat.com/show_bug.cgi?id=3D1438735 Signed-off-by: Sameeh Jubran Reviewed-by: Eric Blake --- qga/commands-win32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 19d72b2..f0d72a0 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -1344,7 +1344,7 @@ GuestLogicalProcessorList *qmp_guest_get_vcpus(Error = **errp) vcpu =3D g_malloc0(sizeof *vcpu); vcpu->logical_id =3D current++; vcpu->online =3D true; - vcpu->has_can_offline =3D false; + vcpu->has_can_offline =3D true; =20 entry =3D g_malloc0(sizeof *entry); entry->value =3D vcpu; --=20 2.9.3