[Qemu-devel] [PATCH] target/ppc: Fix size of struct PPCElfPrstatus

Anton Blanchard posted 1 patch 6 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20170411060456.21594-1-anton@ozlabs.org
Test checkpatch passed
Test docker passed
Test s390x passed
target/ppc/arch_dump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Qemu-devel] [PATCH] target/ppc: Fix size of struct PPCElfPrstatus
Posted by Anton Blanchard 6 years, 11 months ago
From: Anton Blanchard <anton@samba.org>

gdb refuses to parse QEMU memory dumps because struct PPCElfPrstatus
is the wrong size. Fix it.

Signed-off-by: Anton Blanchard <anton@samba.org>
Fixes: e62fbc54d459 ("target-ppc: dump-guest-memory support")
---
 target/ppc/arch_dump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c
index 28d9cc7d79..8e9397aa58 100644
--- a/target/ppc/arch_dump.c
+++ b/target/ppc/arch_dump.c
@@ -50,7 +50,7 @@ struct PPCUserRegStruct {
 struct PPCElfPrstatus {
     char pad1[112];
     struct PPCUserRegStruct pr_reg;
-    reg_t pad2[4];
+    char pad2[40];
 } QEMU_PACKED;
 
 
-- 
2.11.0


Re: [Qemu-devel] [PATCH] target/ppc: Fix size of struct PPCElfPrstatus
Posted by David Gibson 6 years, 11 months ago
On Tue, Apr 11, 2017 at 04:04:56PM +1000, Anton Blanchard wrote:
> From: Anton Blanchard <anton@samba.org>
> 
> gdb refuses to parse QEMU memory dumps because struct PPCElfPrstatus
> is the wrong size. Fix it.
> 
> Signed-off-by: Anton Blanchard <anton@samba.org>
> Fixes: e62fbc54d459 ("target-ppc: dump-guest-memory support")

Applied to ppc-for-2.10, thanks.

> ---
>  target/ppc/arch_dump.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c
> index 28d9cc7d79..8e9397aa58 100644
> --- a/target/ppc/arch_dump.c
> +++ b/target/ppc/arch_dump.c
> @@ -50,7 +50,7 @@ struct PPCUserRegStruct {
>  struct PPCElfPrstatus {
>      char pad1[112];
>      struct PPCUserRegStruct pr_reg;
> -    reg_t pad2[4];
> +    char pad2[40];
>  } QEMU_PACKED;
>  
>  

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson