From nobody Mon Feb 9 15:10:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491422095830807.8022377376867; Wed, 5 Apr 2017 12:54:55 -0700 (PDT) Received: from localhost ([::1]:42201 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvr14-0008UF-2t for importer@patchew.org; Wed, 05 Apr 2017 15:54:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvquh-0002zf-Tb for qemu-devel@nongnu.org; Wed, 05 Apr 2017 15:48:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvque-0008A3-TA for qemu-devel@nongnu.org; Wed, 05 Apr 2017 15:48:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47550) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cvquc-00088W-Fr; Wed, 05 Apr 2017 15:48:14 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7188696EF; Wed, 5 Apr 2017 19:48:13 +0000 (UTC) Received: from red.redhat.com (ovpn-124-8.rdu2.redhat.com [10.10.124.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id CD8615C54B; Wed, 5 Apr 2017 19:48:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7188696EF Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=eblake@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7188696EF From: Eric Blake To: qemu-devel@nongnu.org Date: Wed, 5 Apr 2017 14:47:40 -0500 Message-Id: <20170405194741.18956-13-eblake@redhat.com> In-Reply-To: <20170405194741.18956-1-eblake@redhat.com> References: <20170405194741.18956-1-eblake@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 05 Apr 2017 19:48:13 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v3 12/13] fdc-test: Avoid deprecated 'change' command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , armbru@redhat.com, "open list:Floppy" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Use the preferred blockdev-change-medium command instead. Admittedly, use of 'device' is also deprecated over the newer use of 'id', but the test is exploiting that the name 'floppy0' is auto-created by the board, and I could not figure out where the command line lives that would need to be tweaked to provide a non-random 'id' to this device. Signed-off-by: Eric Blake Reviewed-by: John Snow --- v3: update commit message to point out that we are still using deprecated 'device' --- tests/fdc-test.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/fdc-test.c b/tests/fdc-test.c index 738c6b4..f5ff68d 100644 --- a/tests/fdc-test.c +++ b/tests/fdc-test.c @@ -298,8 +298,9 @@ static void test_media_insert(void) /* Insert media in drive. DSKCHK should not be reset until a step pulse * is sent. */ - qmp_discard_response("{'execute':'change', 'arguments':{" - " 'device':'floppy0', 'target': %s, 'arg': 'raw' = }}", + qmp_discard_response("{'execute':'blockdev-change-medium', 'arguments'= :{" + " 'device':'floppy0', 'filename': %s, " + "'format': 'raw' }}", test_image); dir =3D inb(FLOPPY_BASE + reg_dir); --=20 2.9.3