From nobody Tue Feb 10 09:24:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491337860092845.1359268606526; Tue, 4 Apr 2017 13:31:00 -0700 (PDT) Received: from localhost ([::1]:37508 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvV6Q-0007DN-LV for importer@patchew.org; Tue, 04 Apr 2017 16:30:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvV0Y-0001ec-AD for qemu-devel@nongnu.org; Tue, 04 Apr 2017 16:24:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvV0W-0002oq-6O for qemu-devel@nongnu.org; Tue, 04 Apr 2017 16:24:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41724) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cvV0W-0002oa-19 for qemu-devel@nongnu.org; Tue, 04 Apr 2017 16:24:52 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 12A9E4E4C6; Tue, 4 Apr 2017 20:24:51 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 913A55C464; Tue, 4 Apr 2017 20:24:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 12A9E4E4C6 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 12A9E4E4C6 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Tue, 4 Apr 2017 17:24:11 -0300 Message-Id: <20170404202429.14643-4-ehabkost@redhat.com> In-Reply-To: <20170404202429.14643-1-ehabkost@redhat.com> References: <20170404202429.14643-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 04 Apr 2017 20:24:51 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 03/21] xen-backend: Remove FIXME comment about user_creatable flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Peter Maydell , Thomas Huth , sstabellini@kernel.org, Alexander Graf , Markus Armbruster , Marcel Apfelbaum , Laszlo Ersek Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" xen-backend can be plugged/unplugged dynamically when using the Xen accelerator, so keep the user_creatable flag on the device class and remove the FIXME comment. Cc: Juergen Gross , Cc: Peter Maydell , Cc: Thomas Huth Cc: sstabellini@kernel.org Cc: Markus Armbruster , Cc: Marcel Apfelbaum , Cc: Laszlo Ersek Signed-off-by: Eduardo Habkost --- Changes series v1 -> v2: * (New patch added to series) --- hw/xen/xen_backend.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c index b39dce4cab..56df27992f 100644 --- a/hw/xen/xen_backend.c +++ b/hw/xen/xen_backend.c @@ -618,10 +618,7 @@ static void xendev_class_init(ObjectClass *klass, void= *data) =20 dc->props =3D xendev_properties; set_bit(DEVICE_CATEGORY_MISC, dc->categories); - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ + /* xen-backend devices can be plugged/unplugged dynamically */ dc->user_creatable =3D true; } =20 --=20 2.11.0.259.g40922b1