From nobody Mon Feb 9 16:45:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491249092596237.00896388310184; Mon, 3 Apr 2017 12:51:32 -0700 (PDT) Received: from localhost ([::1]:60938 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cv80h-0002hD-EQ for importer@patchew.org; Mon, 03 Apr 2017 15:51:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cv7tl-0005JF-QK for qemu-devel@nongnu.org; Mon, 03 Apr 2017 15:44:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cv7tj-0003Bd-9M for qemu-devel@nongnu.org; Mon, 03 Apr 2017 15:44:21 -0400 Received: from mail-wr0-x22c.google.com ([2a00:1450:400c:c0c::22c]:34972) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cv7tj-0003B4-2A for qemu-devel@nongnu.org; Mon, 03 Apr 2017 15:44:19 -0400 Received: by mail-wr0-x22c.google.com with SMTP id k6so179297808wre.2 for ; Mon, 03 Apr 2017 12:44:18 -0700 (PDT) Received: from donizetti.lan (94-39-184-28.adsl-ull.clienti.tiscali.it. [94.39.184.28]) by smtp.gmail.com with ESMTPSA id 18sm19436935wrt.52.2017.04.03.12.44.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Apr 2017 12:44:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=eSbSbf99x5ZbjP/TvEbt6f4U4er83LbBx7jKJCL0Nac=; b=UOWQwfnX4UshqGrU3kViTXFS8dLGThVrAXmrGyFGpIncyzUEQb7XExoWuK11EPNjit tb587z3YbsiT2Unt2CFzSc5LkgZi6EV8bC+1ovyAqlJPDtf9LKtihSspDD62QciDjQwN 3OKsy3bW+v+4mI1qvoDvP19XJLKaPWI110wZpNbhXcksxnoOlwGOEc0rcJS4mydCvJ/n S2+RcJQG+xgxarvGcdGi0CqAnR1dbtN5NEtAsDJf4NHkFZtMETJOzHuVzmjt1xzxOyOC TIwA4jqZAnh2MFMGsVoPVL6gRLWorFFE/M05a6THikvK3rYcZ7fYRbOHGjPFv90IjZqR D8Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=eSbSbf99x5ZbjP/TvEbt6f4U4er83LbBx7jKJCL0Nac=; b=XKaG1IGYH1cq/qEevXWB1Wrjs0p1ac6JxZAOq51sf/dZe8ckxkn3pTy8dE9us/jfa7 tdxfpr/F1ZlM3Dan3HWt5ER5pSMCOe9Rtlnc+YebToSXZbWEMXzGNcUa/QGJbmp6MPtl WTGeGmu8gQPyvLeEwyUouCLiymq+IF/9bz+pyIh9Wx0AxnBFzKfYy1jLvg9JHMBZS8SN XN6RKU7cFa+C9KdqxG7DY59XmtT3/fzh+NMOzmJ+0NHHwlyCbOeXclf0kJeEfOZLlm2e Ja+G8kl42uVZ4M0QTmi/ytN1LWpLQW/kPGhp5S5VOtZL4zME7elK7f7DX8wTofbOT4/y vi0g== X-Gm-Message-State: AFeK/H0vSTktb1DPGDrByWju1lqnjeFH91KGbT0zZ3gcN8JHh4O5WE44jvWryDGVu7dXFQ== X-Received: by 10.223.153.142 with SMTP id y14mr16351032wrb.193.1491248657946; Mon, 03 Apr 2017 12:44:17 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 3 Apr 2017 21:44:07 +0200 Message-Id: <20170403194409.21276-5-pbonzini@redhat.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170403194409.21276-1-pbonzini@redhat.com> References: <20170403194409.21276-1-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22c Subject: [Qemu-devel] [PULL 4/6] nbd: fix memory leak on socket_connect failed X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yaolujing Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: yaolujing When TCP connection fails between nbd server and client, the local var, sioc, memory leak. This patch fixes the memory leak. Signed-off-by: yaolujing Reviewed-by: Eric Blake Message-Id: <1491005709-29989-1-git-send-email-yaolujing@huawei.com> Signed-off-by: Paolo Bonzini --- block/nbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/nbd.c b/block/nbd.c index 1b832c2..3150712 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -311,6 +311,7 @@ static QIOChannelSocket *nbd_establish_connection(Socke= tAddress *saddr, saddr, &local_err); if (local_err) { + object_unref(OBJECT(sioc)); error_propagate(errp, local_err); return NULL; } --=20 1.8.3.1