From nobody Mon Feb 9 15:10:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491248758735853.5244492437419; Mon, 3 Apr 2017 12:45:58 -0700 (PDT) Received: from localhost ([::1]:60912 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cv7vJ-0006Us-Av for importer@patchew.org; Mon, 03 Apr 2017 15:45:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cv7ti-0005Gr-W0 for qemu-devel@nongnu.org; Mon, 03 Apr 2017 15:44:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cv7th-0003AY-Gq for qemu-devel@nongnu.org; Mon, 03 Apr 2017 15:44:19 -0400 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]:34000) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cv7th-00039t-9F for qemu-devel@nongnu.org; Mon, 03 Apr 2017 15:44:17 -0400 Received: by mail-wr0-x244.google.com with SMTP id w43so36363138wrb.1 for ; Mon, 03 Apr 2017 12:44:17 -0700 (PDT) Received: from donizetti.lan (94-39-184-28.adsl-ull.clienti.tiscali.it. [94.39.184.28]) by smtp.gmail.com with ESMTPSA id 18sm19436935wrt.52.2017.04.03.12.44.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Apr 2017 12:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7iiTi/IV8wF9dF9btOPV+HmOX8boONcVmGxby6Us94Y=; b=LfDlvJ+NZtECcNVZUPJvFKvx3+ykmi/en/ZwEWwa1kRqKA3QO3KdjtZgUECxJuRMHP 5adevH9KgMf4UpfFaRwJxQgx3VycuTxlg4UIZtQgyj/Ke6bfQC4pXmHvdBtYPDQoJHDK prINcpJFav3ZpmVposvZ1mqahEw0j1GWWknoFcNBNF07N23ymvSBRhfeENUPwsxPVkjP WtxOVBOzjy/YiJ7W1GDTvhaNtOJmJlsFW0CuZNAFAundLYRPrPBTLxCSCpLBk8h89r5t 1qJQQRFwEfqPBfWPfVu1SOHNooIZZ9f0k6l9cpDsXBYhTPoN0+iSd3tQjMVrUTbQF+P0 KASw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=7iiTi/IV8wF9dF9btOPV+HmOX8boONcVmGxby6Us94Y=; b=p0uPMeG9zaR1QuLTPHBS/rwuSJ3oXhFBOsy27hDyhNbBrVJUYQ1IMo2l5GVGc/yS6T 5BwQMVOFFNqTKnISfLjzmNXPGXO0tyBA+U144uxlJetTY4l0BMzc/Kd3aZYj+vKeFhhy aM1mkH9FHoZ5kqsrY3Bs2lxqAPwqNaMKoYoXNedCbnmIpNNtDeLMWGBgIFVFjF8WDI/E /7w+/V8ZZy6BU65Ovr0Kh0e47MUEQjHe0r8LTjIJQfqDYKniwMG1nPYn5SIGsU+c5Oap 35oaG8kjkvBf6wOTiNy0oJXZUMofllpfanZ6aoKd8+Ua3uaLK8PLlyhYef0zzDxtbb5W tqaQ== X-Gm-Message-State: AFeK/H0ZaHOsUPASJqMzobpWZhccpVGYRWdYbkkcQ5OkYgzKcZfrdrhOBDili2MmkM0oKA== X-Received: by 10.223.183.29 with SMTP id l29mr17912466wre.42.1491248655911; Mon, 03 Apr 2017 12:44:15 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 3 Apr 2017 21:44:05 +0200 Message-Id: <20170403194409.21276-3-pbonzini@redhat.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170403194409.21276-1-pbonzini@redhat.com> References: <20170403194409.21276-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::244 Subject: [Qemu-devel] [PULL 2/6] target-i386: fix "info lapic" segfault on isapc X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tejaswini Poluri Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Tejaswini Poluri Start QEMU with "qemu-system-x86_64 -nographic -M isapc -serial none-monitor stdio" and enter "info lapic" at the monitor prompt =C3=A2=E2=80=A1=E2=80=99 Segmentation fault Signed-off-by: Tejaswini Poluri Message-Id: <1490685583-16987-1-git-send-email-tejaswinipoluri3@gmail.com> Signed-off-by: Paolo Bonzini --- target/i386/helper.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/target/i386/helper.c b/target/i386/helper.c index e2af340..f11cac6 100644 --- a/target/i386/helper.c +++ b/target/i386/helper.c @@ -326,6 +326,10 @@ void x86_cpu_dump_local_apic_state(CPUState *cs, FILE = *f, { X86CPU *cpu =3D X86_CPU(cs); APICCommonState *s =3D APIC_COMMON(cpu->apic_state); + if (!s) { + cpu_fprintf(f, "local apic state not available\n"); + return; + } uint32_t *lvt =3D s->lvt; =20 cpu_fprintf(f, "dumping local APIC state for CPU %-2u\n\n", --=20 1.8.3.1