From nobody Mon Feb 9 14:14:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149100789080369.48674932657013; Fri, 31 Mar 2017 17:51:30 -0700 (PDT) Received: from localhost ([::1]:43409 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7GL-0007q2-B3 for importer@patchew.org; Fri, 31 Mar 2017 20:51:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7CF-0004t8-HQ for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7CE-0006Xk-JU for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46894) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7CE-0006WH-EZ for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:14 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 63786C04F4A1; Sat, 1 Apr 2017 00:47:13 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id AA4006031D; Sat, 1 Apr 2017 00:47:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 63786C04F4A1 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 63786C04F4A1 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:13 -0300 Message-Id: <20170401004624.30886-9-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sat, 01 Apr 2017 00:47:13 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 08/19] ioapic: Remove user_creatable flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , "Michael S. Tsirkin" , Alexander Graf , Markus Armbruster , Paolo Bonzini , Marcel Apfelbaum , Igor Mammedov , Laszlo Ersek , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" An ioapic device is already created by the q35 initialization code, and using "-device ioapic" or "-device kvm-ioapic" will always fail with "Only 1 ioapics allowed". Remove the user_creatable flag from the ioapic device classes. Cc: Igor Mammedov Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Eduardo Habkost --- hw/i386/kvm/ioapic.c | 5 ----- hw/intc/ioapic.c | 5 ----- 2 files changed, 10 deletions(-) diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c index cdc35de661..98ca480792 100644 --- a/hw/i386/kvm/ioapic.c +++ b/hw/i386/kvm/ioapic.c @@ -167,11 +167,6 @@ static void kvm_ioapic_class_init(ObjectClass *klass, = void *data) k->post_load =3D kvm_ioapic_put; dc->reset =3D kvm_ioapic_reset; dc->props =3D kvm_ioapic_properties; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo kvm_ioapic_info =3D { diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c index 38af393538..37c4386ae3 100644 --- a/hw/intc/ioapic.c +++ b/hw/intc/ioapic.c @@ -448,11 +448,6 @@ static void ioapic_class_init(ObjectClass *klass, void= *data) k->post_load =3D ioapic_update_kvm_routes; dc->reset =3D ioapic_reset_common; dc->props =3D ioapic_properties; - /* - * FIXME: Set only for compatibility on q35 machine-type. - * Probably never meant to be user-creatable - */ - dc->user_creatable =3D true; } =20 static const TypeInfo ioapic_info =3D { --=20 2.11.0.259.g40922b1