From nobody Mon Feb 9 11:29:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149100803085034.48643849093196; Fri, 31 Mar 2017 17:53:50 -0700 (PDT) Received: from localhost ([::1]:43423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7Ia-0001GY-Fl for importer@patchew.org; Fri, 31 Mar 2017 20:53:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu7C6-0004lW-62 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu7C2-0006Bp-Es for qemu-devel@nongnu.org; Fri, 31 Mar 2017 20:47:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47114) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cu7Bq-0005uO-H4; Fri, 31 Mar 2017 20:46:50 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4734CC065862; Sat, 1 Apr 2017 00:46:48 +0000 (UTC) Received: from localhost (ovpn-116-5.gru2.redhat.com [10.97.116.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 64BE117CFB; Sat, 1 Apr 2017 00:46:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4734CC065862 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ehabkost@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 4734CC065862 From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 31 Mar 2017 21:46:08 -0300 Message-Id: <20170401004624.30886-4-ehabkost@redhat.com> In-Reply-To: <20170401004624.30886-1-ehabkost@redhat.com> References: <20170401004624.30886-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Sat, 01 Apr 2017 00:46:49 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Jason Wang , Markus Armbruster , Gerd Hoffmann , "Edgar E. Iglesias" , qemu-block@nongnu.org, Alexander Graf , Shannon Zhao , Marcel Apfelbaum , Richard Henderson , Laszlo Ersek , Thomas Huth , "Gabriel L . Somlo" , Alistair Francis , Beniamino Galvani , Alex Williamson , qemu-arm@nongnu.org, Igor Mammedov , Scott Wood , John Snow , David Gibson , Kevin Wolf , Prasad J Pandit , Max Reitz , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" commit 33cd52b5d7b9adfd009e95f07e6c64dd88ae2a31 unset cannot_instantiate_with_device_add_yet in TYPE_SYSBUS, making all kinds of untested devices available to -device and device_add. The problem with that is: setting has_dynamic_sysbus on a machine-type lets it accept all the 288 sysbus device types we have in QEMU, and most of them were never meant to be used with -device. That's a lot of untested code. Fortunately today we have just a few has_dynamic_sysbus=3D1 machines: virt, pc-q35-*, ppce500, and spapr. virt, ppce500, and spapr have extra checks to ensure just a few device types can be instantiated: * virt supports only TYPE_VFIO_CALXEDA_XGMAC, TYPE_VFIO_AMD_XGBE. * ppce500 supports only TYPE_ETSEC_COMMON. * spapr supports only TYPE_SPAPR_PCI_HOST_BRIDGE. q35 has no code to block unsupported sysbus devices, however, and accepts all device types. Fortunately, only the following 20 device types are compiled into the qemu-system-x86_64 and qemu-system-i386 binaries: * allwinner-ahci * amd-iommu * cfi.pflash01 * esp * fw_cfg_io * fw_cfg_mem * generic-sdhci * hpet * intel-iommu * ioapic * isabus-bridge * kvmclock * kvm-ioapic * kvmvapic * SUNW,fdtwo * sysbus-ahci * sysbus-fdc * sysbus-ohci * unimplemented-device * virtio-mmio Instead of requiring each machine-type with has_dynamic_sysbus=3D1 to implement its own mechanism to block unsupported devices, we can use the user_creatable flag to ensure we won't let the user plug anything that will never work. This patch adds user_creatable=3Dtrue explicitly to the 24 device types mentioned above, to keep compatibility, and set user_creatable=3Dfalse on TYPE_SYS_BUS_DEVICE. Subsequent patches will remove user_creatable=3Dtrue from the devices that were not meant to be creatable using -device despite being currently accepted by q35. Cc: Peter Maydell Cc: Alexander Graf Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: "Michael S. Tsirkin" Cc: Scott Wood Cc: Jason Wang Cc: David Gibson Cc: Gerd Hoffmann Cc: Alex Williamson Cc: qemu-block@nongnu.org Cc: qemu-ppc@nongnu.org Cc: Alistair Francis Cc: Beniamino Galvani Cc: "Edgar E. Iglesias" Cc: Gabriel L. Somlo Cc: Igor Mammedov Cc: Laszlo Ersek Cc: Marcel Apfelbaum Cc: Prasad J Pandit Cc: qemu-arm@nongnu.org Cc: Shannon Zhao Cc: Thomas Huth Signed-off-by: Eduardo Habkost --- hw/block/fdc.c | 10 ++++++++++ hw/block/pflash_cfi01.c | 5 +++++ hw/core/sysbus.c | 11 +++++++++++ hw/i386/amd_iommu.c | 5 +++++ hw/i386/intel_iommu.c | 5 +++++ hw/i386/kvm/clock.c | 5 +++++ hw/i386/kvm/ioapic.c | 5 +++++ hw/i386/kvmvapic.c | 5 +++++ hw/ide/ahci.c | 10 ++++++++++ hw/intc/ioapic.c | 5 +++++ hw/isa/isa-bus.c | 5 +++++ hw/misc/unimp.c | 5 +++++ hw/net/fsl_etsec/etsec.c | 1 + hw/nvram/fw_cfg.c | 10 ++++++++++ hw/ppc/spapr_pci.c | 1 + hw/scsi/esp.c | 5 +++++ hw/sd/sdhci.c | 5 +++++ hw/timer/hpet.c | 5 +++++ hw/usb/hcd-ohci.c | 5 +++++ hw/vfio/amd-xgbe.c | 1 + hw/vfio/calxeda-xgmac.c | 1 + hw/virtio/virtio-mmio.c | 5 +++++ 22 files changed, 115 insertions(+) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index a328693d15..a06c8e358c 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -2880,6 +2880,11 @@ static void sysbus_fdc_class_init(ObjectClass *klass= , void *data) =20 dc->props =3D sysbus_fdc_properties; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo sysbus_fdc_info =3D { @@ -2906,6 +2911,11 @@ static void sun4m_fdc_class_init(ObjectClass *klass,= void *data) =20 dc->props =3D sun4m_fdc_properties; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo sun4m_fdc_info =3D { diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 594d4cf6fe..f48dc20035 100644 --- a/hw/block/pflash_cfi01.c +++ b/hw/block/pflash_cfi01.c @@ -927,6 +927,11 @@ static void pflash_cfi01_class_init(ObjectClass *klass= , void *data) dc->props =3D pflash_cfi01_properties; dc->vmsd =3D &vmstate_pflash; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 =20 diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c index c0f560b289..2d4121dd67 100644 --- a/hw/core/sysbus.c +++ b/hw/core/sysbus.c @@ -326,6 +326,17 @@ static void sysbus_device_class_init(ObjectClass *klas= s, void *data) DeviceClass *k =3D DEVICE_CLASS(klass); k->init =3D sysbus_device_init; k->bus_type =3D TYPE_SYSTEM_BUS; + /* + * device_add plugs devices into suitable bus. For "real" buses, + * that actually connects the device. For sysbus, the connections + * need to be made separately, and device_add can't do that. The + * device would be left unconnected, and will probably not work + * + * However, a few machines and a few devices can handle a few sysbus + * devices, if the device subclass overrides user_creatable=3Dtrue and + * the machine has has_dynamic_sysbus=3D1. + */ + k->user_creatable =3D false; } =20 static const TypeInfo sysbus_device_type_info =3D { diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index f86a40aa30..1d139f3f6a 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -1186,6 +1186,11 @@ static void amdvi_class_init(ObjectClass *klass, voi= d* data) dc->vmsd =3D &vmstate_amdvi; dc->hotpluggable =3D false; dc_class->realize =3D amdvi_realize; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo amdvi =3D { diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 22d8226e43..5e5125f34b 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -2601,6 +2601,11 @@ static void vtd_class_init(ObjectClass *klass, void = *data) dc->hotpluggable =3D false; x86_class->realize =3D vtd_realize; x86_class->int_remap =3D vtd_int_remap; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo vtd_info =3D { diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c index 13eca374cd..0dbf083b17 100644 --- a/hw/i386/kvm/clock.c +++ b/hw/i386/kvm/clock.c @@ -286,6 +286,11 @@ static void kvmclock_class_init(ObjectClass *klass, vo= id *data) dc->realize =3D kvmclock_realize; dc->vmsd =3D &kvmclock_vmsd; dc->props =3D kvmclock_properties; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo kvmclock_info =3D { diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c index 98ca480792..cdc35de661 100644 --- a/hw/i386/kvm/ioapic.c +++ b/hw/i386/kvm/ioapic.c @@ -167,6 +167,11 @@ static void kvm_ioapic_class_init(ObjectClass *klass, = void *data) k->post_load =3D kvm_ioapic_put; dc->reset =3D kvm_ioapic_reset; dc->props =3D kvm_ioapic_properties; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo kvm_ioapic_info =3D { diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c index 82a49556af..fbada19253 100644 --- a/hw/i386/kvmvapic.c +++ b/hw/i386/kvmvapic.c @@ -856,6 +856,11 @@ static void vapic_class_init(ObjectClass *klass, void = *data) dc->reset =3D vapic_reset; dc->vmsd =3D &vmstate_vapic; dc->realize =3D vapic_realize; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo vapic_type =3D { diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index f60826d6e0..b1b7780d56 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1721,6 +1721,11 @@ static void sysbus_ahci_class_init(ObjectClass *klas= s, void *data) dc->props =3D sysbus_ahci_properties; dc->reset =3D sysbus_ahci_reset; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo sysbus_ahci_info =3D { @@ -1815,6 +1820,11 @@ static void allwinner_ahci_class_init(ObjectClass *k= lass, void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->vmsd =3D &vmstate_allwinner_ahci; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo allwinner_ahci_info =3D { diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c index 37c4386ae3..38af393538 100644 --- a/hw/intc/ioapic.c +++ b/hw/intc/ioapic.c @@ -448,6 +448,11 @@ static void ioapic_class_init(ObjectClass *klass, void= *data) k->post_load =3D ioapic_update_kvm_routes; dc->reset =3D ioapic_reset_common; dc->props =3D ioapic_properties; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo ioapic_info =3D { diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c index 348e0eab9d..576dbf1763 100644 --- a/hw/isa/isa-bus.c +++ b/hw/isa/isa-bus.c @@ -221,6 +221,11 @@ static void isabus_bridge_class_init(ObjectClass *klas= s, void *data) =20 set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->fw_name =3D "isa"; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo isabus_bridge_info =3D { diff --git a/hw/misc/unimp.c b/hw/misc/unimp.c index bcbb585888..284f096beb 100644 --- a/hw/misc/unimp.c +++ b/hw/misc/unimp.c @@ -90,6 +90,11 @@ static void unimp_class_init(ObjectClass *klass, void *d= ata) =20 dc->realize =3D unimp_realize; dc->props =3D unimp_properties; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo unimp_info =3D { diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c index aa2b0d5a85..b230b88753 100644 --- a/hw/net/fsl_etsec/etsec.c +++ b/hw/net/fsl_etsec/etsec.c @@ -416,6 +416,7 @@ static void etsec_class_init(ObjectClass *klass, void *= data) dc->realize =3D etsec_realize; dc->reset =3D etsec_reset; dc->props =3D etsec_properties; + dc->user_creatable =3D true; } =20 static TypeInfo etsec_info =3D { diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 316fca9bc1..60bf4fdd2e 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -1101,6 +1101,11 @@ static void fw_cfg_io_class_init(ObjectClass *klass,= void *data) =20 dc->realize =3D fw_cfg_io_realize; dc->props =3D fw_cfg_io_properties; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo fw_cfg_io_info =3D { @@ -1167,6 +1172,11 @@ static void fw_cfg_mem_class_init(ObjectClass *klass= , void *data) =20 dc->realize =3D fw_cfg_mem_realize; dc->props =3D fw_cfg_mem_properties; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo fw_cfg_mem_info =3D { diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 98c52e411f..360eeb2e40 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -1990,6 +1990,7 @@ static void spapr_phb_class_init(ObjectClass *klass, = void *data) dc->props =3D spapr_phb_properties; dc->reset =3D spapr_phb_reset; dc->vmsd =3D &vmstate_spapr_pci; + dc->user_creatable =3D true; set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); hp->plug =3D spapr_phb_hot_plug_child; hp->unplug =3D spapr_phb_hot_unplug_child; diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index eee831efeb..1087b8f14f 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -728,6 +728,11 @@ static void sysbus_esp_class_init(ObjectClass *klass, = void *data) dc->reset =3D sysbus_esp_hard_reset; dc->vmsd =3D &vmstate_sysbus_esp_scsi; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo sysbus_esp_info =3D { diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 6d6a791ee9..186555188b 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1360,6 +1360,11 @@ static void sdhci_sysbus_class_init(ObjectClass *kla= ss, void *data) dc->props =3D sdhci_sysbus_properties; dc->realize =3D sdhci_sysbus_realize; dc->reset =3D sdhci_poweron_reset; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo sdhci_sysbus_info =3D { diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index a2c18b30c3..b5dab1c8e2 100644 --- a/hw/timer/hpet.c +++ b/hw/timer/hpet.c @@ -771,6 +771,11 @@ static void hpet_device_class_init(ObjectClass *klass,= void *data) dc->reset =3D hpet_reset; dc->vmsd =3D &vmstate_hpet; dc->props =3D hpet_device_properties; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo hpet_device_info =3D { diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index 3ada35e954..0e17fb1e60 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -2159,6 +2159,11 @@ static void ohci_sysbus_class_init(ObjectClass *klas= s, void *data) dc->desc =3D "OHCI USB Controller"; dc->props =3D ohci_sysbus_properties; dc->reset =3D usb_ohci_reset_sysbus; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo ohci_sysbus_info =3D { diff --git a/hw/vfio/amd-xgbe.c b/hw/vfio/amd-xgbe.c index 2c60310cf9..f0b6624530 100644 --- a/hw/vfio/amd-xgbe.c +++ b/hw/vfio/amd-xgbe.c @@ -38,6 +38,7 @@ static void vfio_amd_xgbe_class_init(ObjectClass *klass, = void *data) dc->realize =3D amd_xgbe_realize; dc->desc =3D "VFIO AMD XGBE"; dc->vmsd =3D &vfio_platform_amd_xgbe_vmstate; + dc->user_creatable =3D true; } =20 static const TypeInfo vfio_amd_xgbe_dev_info =3D { diff --git a/hw/vfio/calxeda-xgmac.c b/hw/vfio/calxeda-xgmac.c index bb15d588e5..6fae3c5772 100644 --- a/hw/vfio/calxeda-xgmac.c +++ b/hw/vfio/calxeda-xgmac.c @@ -38,6 +38,7 @@ static void vfio_calxeda_xgmac_class_init(ObjectClass *kl= ass, void *data) dc->realize =3D calxeda_xgmac_realize; dc->desc =3D "VFIO Calxeda XGMAC"; dc->vmsd =3D &vfio_platform_calxeda_xgmac_vmstate; + dc->user_creatable =3D true; } =20 static const TypeInfo vfio_calxeda_xgmac_dev_info =3D { diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index 5807aa87fe..b595512a3d 100644 --- a/hw/virtio/virtio-mmio.c +++ b/hw/virtio/virtio-mmio.c @@ -450,6 +450,11 @@ static void virtio_mmio_class_init(ObjectClass *klass,= void *data) dc->reset =3D virtio_mmio_reset; set_bit(DEVICE_CATEGORY_MISC, dc->categories); dc->props =3D virtio_mmio_properties; + /* + * FIXME: Set only for compatibility on q35 machine-type. + * Probably never meant to be user-creatable + */ + dc->user_creatable =3D true; } =20 static const TypeInfo virtio_mmio_info =3D { --=20 2.11.0.259.g40922b1