From nobody Sat May 4 22:07:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1490821566895781.8604703425182; Wed, 29 Mar 2017 14:06:06 -0700 (PDT) Received: from localhost ([::1]:60960 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctKn6-0006IQ-Tr for importer@patchew.org; Wed, 29 Mar 2017 17:06:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctKmO-0005zv-BP for qemu-devel@nongnu.org; Wed, 29 Mar 2017 17:05:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctKmL-0008Fg-8U for qemu-devel@nongnu.org; Wed, 29 Mar 2017 17:05:20 -0400 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:35232) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ctKmL-0008F6-0s for qemu-devel@nongnu.org; Wed, 29 Mar 2017 17:05:17 -0400 Received: by mail-lf0-x243.google.com with SMTP id v2so2823875lfi.2 for ; Wed, 29 Mar 2017 14:05:16 -0700 (PDT) Received: from localhost.localdomain (89-77-183-36.dynamic.chello.pl. [89.77.183.36]) by smtp.gmail.com with ESMTPSA id c66sm14966lfg.9.2017.03.29.14.05.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Mar 2017 14:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=zir/V40KDOSO/0a4w+ODr4IXrJ6IAQ6mio2hFVJ3vew=; b=ZOAyTpkXkY6SumXb3kOkJYCc2XjveSENJaQS3+TS5Kta8V5WfqURA0esxBM2Pf6ooQ EKuUAcWYIK06Bf7I6kfCIfU0vpRVtj9zO9YodpN2RvbKOoOH+AMTVIY3Gsq3hE/Th7k5 QowR3nlWq94KZNO8rq76Zr/Kt2rcOGmZh7sh8KWrikJf8YMdxpDkf/W5Ht2Dzf/DOl+D JEbcSKUb7JVKaSfd/MYYWSWawScVXo3Lv+EK+WOTusCqI9G/ZW3+bSvr8Pq4kBCOhKSD vaAZ2fohozKbjIEUnHQeHlRtXYvuJNBd9yXKt59Ct3BAdPtk42/sqRjfm1EwV7cxoQLn g+XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zir/V40KDOSO/0a4w+ODr4IXrJ6IAQ6mio2hFVJ3vew=; b=FDafJq+VLqBg4uvYiv/dSkSHHpssNIA7sXu+/wh8vYGg6cpIiWjaVCAdHZg6tT83VR zibd2STsMkg+et6RjR+wvw6uLg7EJ0N2IVDemGwiQkwEP7J5+L49da1VLtQX245KnPkd CIpRLSmdFrpF/AUnTi1+relXd8brGXZ47/YFdD1MR+0dW2SMca5yz5x23wjiXqyz9j/B JITgyGlTQkfGdT9o6RVqRmfC+c62ZSNvpK49KdCK3/fNKkwZRS9B7IsCnuNwcfwPiRYT klB05HMtnG+7nUuEcuYiwbj16YtdlqK9iqk0hadChuT9cDsG+92GSqiLirbG0WGLrLMZ 52qA== X-Gm-Message-State: AFeK/H2YLGLwipoS2XcwLTA3sUjglM586kgP6ZO3qI+BzRx09G2LOn3aEdynW7RbACrvAw== X-Received: by 10.46.74.2 with SMTP id x2mr911959lja.87.1490821515442; Wed, 29 Mar 2017 14:05:15 -0700 (PDT) From: Iwona Kotlarska To: Date: Wed, 29 Mar 2017 23:04:39 +0200 Message-Id: <20170329210439.18062-1-iwona260909@gmail.com> X-Mailer: git-send-email 2.12.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::243 Subject: [Qemu-devel] [PATCH RESEND v2] hmp: fix "info cpu" segfault X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ehabkost@redhat.com, qemu-devel@nongnu.org, Iwona Kotlarska , marcel@redhat.com, pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Running QEMU with "qemu-system-x86_64 -M none -nographic -m 256" and execut= ing "dump-guest-memory /dev/null 0 8192" results in segfault. Fix by checking if we have CPU. Signed-off-by: Iwona Kotlarska --- v1 --> v2 Added brackets around if body. Changed subject. target/i386/arch_dump.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/target/i386/arch_dump.c b/target/i386/arch_dump.c index 5a2e4be5d0..43992a440c 100644 --- a/target/i386/arch_dump.c +++ b/target/i386/arch_dump.c @@ -390,9 +390,11 @@ int cpu_get_dump_info(ArchDumpInfo *info, GuestPhysBlock *block; =20 #ifdef TARGET_X86_64 - X86CPU *first_x86_cpu =3D X86_CPU(first_cpu); - - lma =3D !!(first_x86_cpu->env.hflags & HF_LMA_MASK); + X86CPU *first_x86_cpu =3D NULL; + first_x86_cpu =3D X86_CPU(first_cpu); + if (first_cpu !=3D NULL) { + lma =3D !!(first_x86_cpu->env.hflags & HF_LMA_MASK); + } #endif =20 if (lma) { --=20 2.12.0