From nobody Fri May 3 17:04:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1490812855869626.2014156922844; Wed, 29 Mar 2017 11:40:55 -0700 (PDT) Received: from localhost ([::1]:60398 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctIWb-0007aD-Nk for importer@patchew.org; Wed, 29 Mar 2017 14:40:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctIVe-00076q-Ui for qemu-devel@nongnu.org; Wed, 29 Mar 2017 14:39:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctIVb-0001Ch-Tp for qemu-devel@nongnu.org; Wed, 29 Mar 2017 14:39:55 -0400 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:33655) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ctIVb-0001CK-Lo for qemu-devel@nongnu.org; Wed, 29 Mar 2017 14:39:51 -0400 Received: by mail-lf0-x243.google.com with SMTP id r36so2525226lfi.0 for ; Wed, 29 Mar 2017 11:39:51 -0700 (PDT) Received: from localhost.localdomain (89-77-183-36.dynamic.chello.pl. [89.77.183.36]) by smtp.gmail.com with ESMTPSA id a16sm1447049lfk.24.2017.03.29.11.39.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Mar 2017 11:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=pAz3eMjEEasxKkGDL+7tc4YyW4EapyoKUV+VsFDU0pM=; b=LTKSxQZe7dtAshuD/WA7YfRZGuxlbNB+JzH6CsQ21yr44ypsK33+H+RUwo72ZFB3nO Pgv6ZQYvql/RW5FssrissBL1sLDDakY0ZNVRUoZsA5lFuQ3qHw4nMnYCxGLp/8/t51Vo e0+TdttJXWin4HKUP9omwc7ph8oCoamELAhX8O179eUOcho2NPb/MuhBFA5GfeDxbjU7 dmig9TK5rJNRniQ0kK2t8ejOwmkHRGlzVEnh4auOjKfK6kFuGrQ9MD+d+vD9LD4DFTup 9Uk5es8O12OOy8GL1ois9BtJtFazDISHQalBTL99Lec4DNtDjXcTFelH/RbaFURQY3TA Q52A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pAz3eMjEEasxKkGDL+7tc4YyW4EapyoKUV+VsFDU0pM=; b=J5fhSgWi8KZDJGt12TaDiBcAgPvDj5oUCgfuMcBwgoWctD/FDcewcCFaYgiE5y3sbX bBDxTvghUMWgJkOCMoSxebv7UQsyBNS0Z4gKidPcYf+Z10l1pbwLLa6aG5MbHPRyqWxt aFq+l9hpcTT++I7ihcmhL0+I+KYNk2zZ+NKSdVktA8DrkKPM4kgCm1G6Yk41HIYF7xdg 0gU1gdTRiUP3oSLw+VOPpukALzdUQ8aA+2J/JVumlm08FvAfdUTqtV7/Ro2qYk+5Nafz 13WWllCxAmF4YI9EEDwZEpGfs53Xm5Km1OVNlX4cKPB8NWJ6pjdT7ZJqPOojjUAdhYcO g4iA== X-Gm-Message-State: AFeK/H0i4TtAJuBz5T0unxi6oYTf6BKewFGKFVf2NO3qa1xKvBmZ4CuwUC0ZF42W+vYRaw== X-Received: by 10.46.20.85 with SMTP id 21mr762766lju.19.1490812789986; Wed, 29 Mar 2017 11:39:49 -0700 (PDT) From: Iwona Kotlarska To: Date: Wed, 29 Mar 2017 20:39:14 +0200 Message-Id: <20170329183914.4197-1-iwona260909@gmail.com> X-Mailer: git-send-email 2.12.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::243 Subject: [Qemu-devel] [PATCH v2] hmp: fix "info cpu" segfault X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ehabkost@redhat.com, qemu-devel@nongnu.org, Iwona Kotlarska , marcel@redhat.com, pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Running QEMU with "qemu-system-x86_64 -M none -nographic -m 256" and execut= ing "dump-guest-memory /dev/null 0 8192" results in segfault. Fix by checking if we have CPU. Signed-off-by: Iwona Kotlarska --- target/i386/arch_dump.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/target/i386/arch_dump.c b/target/i386/arch_dump.c index 5a2e4be5d0..43992a440c 100644 --- a/target/i386/arch_dump.c +++ b/target/i386/arch_dump.c @@ -390,9 +390,11 @@ int cpu_get_dump_info(ArchDumpInfo *info, GuestPhysBlock *block; =20 #ifdef TARGET_X86_64 - X86CPU *first_x86_cpu =3D X86_CPU(first_cpu); - - lma =3D !!(first_x86_cpu->env.hflags & HF_LMA_MASK); + X86CPU *first_x86_cpu =3D NULL; + first_x86_cpu =3D X86_CPU(first_cpu); + if (first_cpu !=3D NULL) { + lma =3D !!(first_x86_cpu->env.hflags & HF_LMA_MASK); + } #endif =20 if (lma) { --=20 2.12.0