From nobody Mon May 6 00:09:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1490806502096460.49728536204725; Wed, 29 Mar 2017 09:55:02 -0700 (PDT) Received: from localhost ([::1]:60047 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctGs8-0002uT-Bs for importer@patchew.org; Wed, 29 Mar 2017 12:55:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctGr3-0002Iv-Di for qemu-devel@nongnu.org; Wed, 29 Mar 2017 12:53:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctGqy-0000sS-8T for qemu-devel@nongnu.org; Wed, 29 Mar 2017 12:53:53 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:35291) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ctGqy-0000qE-0y for qemu-devel@nongnu.org; Wed, 29 Mar 2017 12:53:48 -0400 Received: by mail-lf0-x241.google.com with SMTP id v2so2249724lfi.2 for ; Wed, 29 Mar 2017 09:53:47 -0700 (PDT) Received: from localhost.localdomain (89-77-183-36.dynamic.chello.pl. [89.77.183.36]) by smtp.gmail.com with ESMTPSA id e124sm1381962lfg.8.2017.03.29.09.53.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Mar 2017 09:53:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=jX1suiZc2Qwc4Q5JZAN4MHDG7q0qDYd0yOb34E60wys=; b=DD8TWf8DQ+gdRFmMVbfm2qxpuYFCpp7facPbvDAZjgxF1RSh0a1uxjBhc3/BhNNkh3 aJn7LUYEXue6RVASxCtNpkO0lu+wKh1bcS7ema2H9BgOZq7wkl7WexGVJm5oBU1xenzq +21wHg7nWGB3D3e1r1KVSB+c1RQlOAwPB+dzshA9kF/7mXj8zsDKPToUaScD48+PwLDU MLB7opmMBPztK8m45Tt8Nw7g0ab9DD5Rx56ZiIMuP8PVvCI8RkJ10qiZjnN2P5RDiGfg MipEKC7EwOIdJW75Q1vAbhii7bauJMtqENxNsfzjMYjw91igXSvlIWAZg3xSMINVqqhh v2sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=jX1suiZc2Qwc4Q5JZAN4MHDG7q0qDYd0yOb34E60wys=; b=Op8vZLPQA0lmIUMHTQfml1twKtMvtboJkxN2M5tCuvJ9fkiR9cv8k7ZpCZGcZdfImd 9IlzZ1QbS14i21vCRrgr4iNIMWNJ1oVfC8i4Fx6lZOpZCJfhoqBgiZXX4wiueyaca28t BxdnTG2VIX/jd3BhX0buGnCVVL3UE3TkBa0M0Zk3xSkgfZEfUeDxErN0TL1J5cL5imcM dlOyXJVY9HL8AqGeIQmxxb+1diOvHTabEmDzTWeL6QOtyMbc6UrOuCbZV9mLaYAjLLyY gnNm9GBPXHIe9uIHllAz04QBLWXKfQm7lZudmOIXs7lGdQKAoSVuZZwd7AZ5TGZmJ8v0 ukZw== X-Gm-Message-State: AFeK/H1H2z9Df5aMoVBVfP4jkog1X3AKWUq59c49mwiPjtqTwsB/8PK99ssQLeTqQTtKtQ== X-Received: by 10.25.20.202 with SMTP id 71mr512962lfu.102.1490806426574; Wed, 29 Mar 2017 09:53:46 -0700 (PDT) From: Iwona Kotlarska To: Date: Wed, 29 Mar 2017 18:52:51 +0200 Message-Id: <20170329165251.28740-1-iwona260909@gmail.com> X-Mailer: git-send-email 2.12.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::241 Subject: [Qemu-devel] [PATCH] hmp: fix "info cpu" segfault X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ehabkost@redhat.com, qemu-devel@nongnu.org, Iwona Kotlarska , marcel@redhat.com, pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Running "dump-guest-memory /dev/null 0 8192" results in segfault. Fix by checking if we have CPU. Signed-off-by: Iwona Kotlarska --- target/i386/arch_dump.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/i386/arch_dump.c b/target/i386/arch_dump.c index 5a2e4be5d0..45cda6afb1 100644 --- a/target/i386/arch_dump.c +++ b/target/i386/arch_dump.c @@ -390,9 +390,10 @@ int cpu_get_dump_info(ArchDumpInfo *info, GuestPhysBlock *block; =20 #ifdef TARGET_X86_64 - X86CPU *first_x86_cpu =3D X86_CPU(first_cpu); - - lma =3D !!(first_x86_cpu->env.hflags & HF_LMA_MASK); + X86CPU *first_x86_cpu =3D NULL; + first_x86_cpu =3D X86_CPU(first_cpu); + if (first_cpu !=3D NULL) + lma =3D !!(first_x86_cpu->env.hflags & HF_LMA_MASK); #endif =20 if (lma) { --=20 2.12.0