From nobody Tue Feb 10 07:21:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1490302913946845.7861566387816; Thu, 23 Mar 2017 14:01:53 -0700 (PDT) Received: from localhost ([::1]:58619 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cr9rk-0004r7-Kw for importer@patchew.org; Thu, 23 Mar 2017 17:01:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cr9cp-000839-GX for qemu-devel@nongnu.org; Thu, 23 Mar 2017 16:46:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cr9cm-0000RO-DZ for qemu-devel@nongnu.org; Thu, 23 Mar 2017 16:46:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36434) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cr9cm-0000Ql-7g for qemu-devel@nongnu.org; Thu, 23 Mar 2017 16:46:24 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3721061D33 for ; Thu, 23 Mar 2017 20:46:24 +0000 (UTC) Received: from secure.mitica (ovpn-116-230.ams2.redhat.com [10.36.116.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id E7BC97FCC7; Thu, 23 Mar 2017 20:46:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3721061D33 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=quintela@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3721061D33 From: Juan Quintela To: qemu-devel@nongnu.org Date: Thu, 23 Mar 2017 21:45:16 +0100 Message-Id: <20170323204544.12015-24-quintela@redhat.com> In-Reply-To: <20170323204544.12015-1-quintela@redhat.com> References: <20170323204544.12015-1-quintela@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 23 Mar 2017 20:46:24 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 23/51] ram: Everything was init to zero, so use memset X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dgilbert@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" And then init only things that are not zero by default. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/ram.c | 25 +++---------------------- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index c6ba92c..a890179 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -611,15 +611,6 @@ static void migration_bitmap_sync_range(RAMState *rs, = ram_addr_t start, &rs->num_dirty_pages_period); } =20 -static void migration_bitmap_sync_init(RAMState *rs) -{ - rs->start_time =3D 0; - rs->bytes_xfer_prev =3D 0; - rs->num_dirty_pages_period =3D 0; - rs->xbzrle_cache_miss_prev =3D 0; - rs->iterations_prev =3D 0; -} - /** * ram_pagesize_summary: calculate all the pagesizes of a VM * @@ -1984,21 +1975,11 @@ err: return ret; } =20 -static int ram_save_init_globals(RAMState *rs) +static int ram_state_init(RAMState *rs) { int64_t ram_bitmap_pages; /* Size of bitmap in pages, including gaps */ =20 - rs->dirty_rate_high_cnt =3D 0; - rs->bitmap_sync_count =3D 0; - rs->zero_pages =3D 0; - rs->norm_pages =3D 0; - rs->iterations =3D 0; - rs->xbzrle_bytes =3D 0; - rs->xbzrle_pages =3D 0; - rs->xbzrle_cache_miss =3D 0; - rs->xbzrle_cache_miss_rate =3D 0; - rs->xbzrle_overflows =3D 0; - migration_bitmap_sync_init(rs); + memset(rs, 0, sizeof(*rs)); qemu_mutex_init(&migration_bitmap_mutex); =20 if (migrate_use_xbzrle()) { @@ -2088,7 +2069,7 @@ static int ram_save_setup(QEMUFile *f, void *opaque) =20 /* migration has already setup the bitmap, reuse it. */ if (!migration_in_colo_state()) { - if (ram_save_init_globals(rs) < 0) { + if (ram_state_init(rs) < 0) { return -1; } } --=20 2.9.3