From nobody Mon Feb 9 18:46:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1490291023292294.19975236054086; Thu, 23 Mar 2017 10:43:43 -0700 (PDT) Received: from localhost ([::1]:57693 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cr6lx-0000Ni-TQ for importer@patchew.org; Thu, 23 Mar 2017 13:43:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cr6i8-0005V5-0d for qemu-devel@nongnu.org; Thu, 23 Mar 2017 13:39:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cr6i4-0002SZ-29 for qemu-devel@nongnu.org; Thu, 23 Mar 2017 13:39:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50326) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cr6i3-0002SM-SP for qemu-devel@nongnu.org; Thu, 23 Mar 2017 13:39:39 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E6A827713 for ; Thu, 23 Mar 2017 17:39:39 +0000 (UTC) Received: from donizetti.redhat.com (ovpn-116-97.ams2.redhat.com [10.36.116.97]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v2NHdS1l032060; Thu, 23 Mar 2017 13:39:38 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E6A827713 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=pbonzini@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E6A827713 From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 23 Mar 2017 18:39:25 +0100 Message-Id: <20170323173928.14439-8-pbonzini@redhat.com> In-Reply-To: <20170323173928.14439-1-pbonzini@redhat.com> References: <20170323173928.14439-1-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 23 Mar 2017 17:39:40 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 07/10] blockjob: strengthen a bit test-blockjob-txn X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jcody@redhat.com, jsnow@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Unlike test-blockjob-txn, QMP releases the reference to the transaction before the jobs finish. Thus, while working on the next patch, qemu-iotest 124 showed a failure that the unit tests did not have. Make the unit test just a little nastier, so that it fails too. Signed-off-by: Paolo Bonzini Reviewed-by: John Snow Reviewed-by: Stefan Hajnoczi --- tests/test-blockjob-txn.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/test-blockjob-txn.c b/tests/test-blockjob-txn.c index 4ccbda1..bfc2aaa 100644 --- a/tests/test-blockjob-txn.c +++ b/tests/test-blockjob-txn.c @@ -165,6 +165,11 @@ static void test_pair_jobs(int expected1, int expected= 2) job2 =3D test_block_job_start(2, true, expected2, &result2); block_job_txn_add_job(txn, job2); =20 + /* Release our reference now to trigger as many nice + * use-after-free bugs as possible. + */ + block_job_txn_unref(txn); + if (expected1 =3D=3D -ECANCELED) { block_job_cancel(job1); } @@ -185,8 +190,6 @@ static void test_pair_jobs(int expected1, int expected2) =20 g_assert_cmpint(result1, =3D=3D, expected1); g_assert_cmpint(result2, =3D=3D, expected2); - - block_job_txn_unref(txn); } =20 static void test_pair_jobs_success(void) --=20 2.9.3