From nobody Sun May 5 21:26:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1490279022091202.59273001778877; Thu, 23 Mar 2017 07:23:42 -0700 (PDT) Received: from localhost ([::1]:56767 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cr3eO-0000hF-I0 for importer@patchew.org; Thu, 23 Mar 2017 10:23:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cr3d6-00089j-BO for qemu-devel@nongnu.org; Thu, 23 Mar 2017 10:22:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cr3d2-0001le-9u for qemu-devel@nongnu.org; Thu, 23 Mar 2017 10:22:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56540) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cr3d2-0001la-28 for qemu-devel@nongnu.org; Thu, 23 Mar 2017 10:22:16 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CC836C04D2F1; Thu, 23 Mar 2017 14:22:15 +0000 (UTC) Received: from evilvm.brq.redhat.com (dhcp131-51.brq.redhat.com [10.34.131.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF19019150; Thu, 23 Mar 2017 14:22:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CC836C04D2F1 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vfeenstr@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com CC836C04D2F1 From: Vinzenz 'evilissimo' Feenstra To: qemu-devel@nongnu.org Date: Thu, 23 Mar 2017 01:27:04 +0100 Message-Id: <20170323002704.11167-2-vfeenstr@redhat.com> In-Reply-To: <20170323002704.11167-1-vfeenstr@redhat.com> References: <20170323002704.11167-1-vfeenstr@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 23 Mar 2017 14:22:16 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v4] qga: Add `guest-get-timezone` command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sameeh@daynix.com, Vinzenz Feenstra , mdroth@linux.vnet.ibm.com, marcandre.lureau@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Vinzenz Feenstra Adds a new command `guest-get-timezone` reporting the currently configured timezone on the system. The information on what timezone is currently is configured is useful in case of Windows VMs where the offset of the hardware clock is required to have the same offset. This can be used for management systems like `oVirt` to detect the timezone difference and warn administrators of the misconfiguration. Signed-off-by: Vinzenz Feenstra --- qga/commands.c | 34 ++++++++++++++++++++++++++++++++++ qga/qapi-schema.json | 26 ++++++++++++++++++++++++++ 2 files changed, 60 insertions(+) diff --git a/qga/commands.c b/qga/commands.c index 4d92946..8a0ff0a 100644 --- a/qga/commands.c +++ b/qga/commands.c @@ -499,3 +499,37 @@ int ga_parse_whence(GuestFileWhence *whence, Error **e= rrp) error_setg(errp, "invalid whence code %"PRId64, whence->u.value); return -1; } + +GuestTimezone *qmp_guest_get_timezone(Error **errp) +{ + GuestTimezone *info =3D g_new0(GuestTimezone, 1); + GTimeZone *tz =3D g_time_zone_new_local(); + if (tz =3D=3D NULL) { + error_setg(errp, QERR_QGA_COMMAND_FAILED, + "Couldn't retrieve local timezone"); + goto error; + } + + gint32 interval =3D g_time_zone_find_interval(tz, G_TIME_TYPE_STANDARD= , 0); + if (interval !=3D -1) { + info->offset =3D g_time_zone_get_offset(tz, interval); + gchar const *name =3D g_time_zone_get_abbreviation(tz, interval); + if (name !=3D NULL) { + info->zone =3D g_strdup(name); + } else { + info->zone =3D NULL; + } + } else { + error_setg(errp, QERR_QGA_COMMAND_FAILED, + "Failed to lookup timezone interval"); + goto error; + } + g_time_zone_unref(tz); + return info; + +error: + g_time_zone_unref(tz); + g_free(info); + return NULL; +} + diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index a02dbf2..20d12a8 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -1042,3 +1042,29 @@ 'data': { 'path': 'str', '*arg': ['str'], '*env': ['str'], '*input-data': 'str', '*capture-output': 'bool' }, 'returns': 'GuestExec' } + + +## +# @GuestTimezone: +# +# @zone: Timezone name +# @offset: Offset to UTC in seconds. For western timezones the offset has= a +# negative value and for eastern the offset is positive value +# +# Since: 2.10 +## +{ 'struct': 'GuestTimezone', + 'data': { '*zone': 'str', 'offset': 'int' } } + + +## +# @guest-get-timezone: +# +# Retrieves the timezone information from the guest. +# +# Returns: A GuestTimezone dictionary. +# +# Since: 2.10 +## +{ 'command': 'guest-get-timezone', + 'returns': 'GuestTimezone' } --=20 2.9.3