From nobody Mon May 6 21:13:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1490105775795520.882474713488; Tue, 21 Mar 2017 07:16:15 -0700 (PDT) Received: from localhost ([::1]:40488 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqKa6-0001Yg-8s for importer@patchew.org; Tue, 21 Mar 2017 10:16:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqKYm-0000eE-Pp for qemu-devel@nongnu.org; Tue, 21 Mar 2017 10:14:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqKYi-00038o-Rm for qemu-devel@nongnu.org; Tue, 21 Mar 2017 10:14:52 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:32961) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cqKYi-00038h-K4 for qemu-devel@nongnu.org; Tue, 21 Mar 2017 10:14:48 -0400 Received: by mail-wm0-x244.google.com with SMTP id n11so3167611wma.0 for ; Tue, 21 Mar 2017 07:14:48 -0700 (PDT) Received: from bark.daynix ([141.226.163.173]) by smtp.gmail.com with ESMTPSA id z21sm25168079wrz.31.2017.03.21.07.14.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Mar 2017 07:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=dMLMFrsZ5jLfDkkx/xeUfENnqVkZ4LdoEaNglRM2F+Q=; b=yPcsvTZvKQ8oEvPQc5VINWDTTANc/Htu3faTBaJzlORfIZBpAv13zG9I4A9Ljh/vFx 58gVtTx+1PXBvqIrQeAvAdv63CTe3Fz8NEKTuwB9CsUPS+tTCNT3C/ov3igTQUKa4jdM U42NMNhczvFSWcLoDIUIolwaZxzzkvj/n0ntrLI9/zUQLxGP0fDLl8akEknY7h1Xtiuc N3jtFckxPf+Cn8S8Pedx1SkbikQWrQ2/ba3OpjJTKPEn1twPw2fv8K56LqTfXAK7sk+L 6USJDEbMGyz0SJFxzWkd0Gui4XyxBDPUPzXKpvCS67Zko7Y9dOh8n4bH0WltyTMkcxTW sO1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dMLMFrsZ5jLfDkkx/xeUfENnqVkZ4LdoEaNglRM2F+Q=; b=blrwXar4BIwiQKIqce1E+pAY1WuXLFUHN7m1bq1X45Z0DTx4WEArQt3hqd/L0zvkOP oFYLU4s/MvSc7N4RIAiwEQq1nLMKOfh1og+9qdMxDUHlw+i7T54RpzD0Ku36n1jxE/wp FGgDheEckWR3/A5uXM+eVk+HBR37vCGHVFCv5JB7r/G3n9KORJLyVMPXVt0X4Tpb6LLh g70BBasO84fLpx2+WP2OYUxRJYrdjzmXED2jua0bgejQM64+TDY3DmG7Fnr499Pf/Lit j6GI9/iMsTNWiD0PA18iHwcKIZ1JGXs1LwFgrzRyyVpAG5tL8KKlMCY7Y6/MoKJTPj/o JYBA== X-Gm-Message-State: AFeK/H0FI6N9rg+QE8K/YIAhvAKOk+vMv/p7t1FC3+VLJkgcPJE3nskmd3vkWd4+732ZmA== X-Received: by 10.28.183.4 with SMTP id h4mr3055559wmf.32.1490105687472; Tue, 21 Mar 2017 07:14:47 -0700 (PDT) From: Sameeh Jubran To: qemu-devel@nongnu.org, Michael Roth Date: Tue, 21 Mar 2017 16:14:35 +0200 Message-Id: <20170321141435.23701-1-sameeh@daynix.com> X-Mailer: git-send-email 2.9.3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::244 Subject: [Qemu-devel] [PATCH qemu-ga] qemu-ga: Don't display errors to the user on thaw command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Vugenfirer Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Errors that are related to ur inner implementation for the thaw command shouldn't be displayed to the user. Signed-off-by: Sameeh Jubran --- qga/vss-win32/requester.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index 0cd2f0e..272e71b 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -463,7 +463,7 @@ void requester_thaw(int *num_vols, ErrorSet *errset) hr =3D WaitForAsync(pAsync); } if (FAILED(hr)) { - err_set(errset, hr, "failed to complete backup"); + fprintf(stderr, "failed to complete backup"); } break; =20 @@ -480,18 +480,18 @@ void requester_thaw(int *num_vols, ErrorSet *errset) =20 case VSS_E_UNEXPECTED_PROVIDER_ERROR: if (WaitForSingleObject(vss_ctx.hEventTimeout, 0) !=3D WAIT_OBJECT= _0) { - err_set(errset, hr, "unexpected error in VSS provider"); + fprintf(stderr, "unexpected error in VSS provider"); break; } /* fall through if hEventTimeout is signaled */ =20 case (HRESULT)VSS_E_HOLD_WRITES_TIMEOUT: - err_set(errset, hr, "couldn't hold writes: " + fprintf(stderr, "couldn't hold writes: " "fsfreeze is limited up to 10 seconds"); break; =20 default: - err_set(errset, hr, "failed to do snapshot set"); + fprintf(stderr, "failed to do snapshot set"); } =20 if (err_is_set(errset)) { --=20 2.9.3